[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if Status is ignored This introduces a WARN_UNUSED_RESULT macro. It can be used at

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/185/ -- To view, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: > Turns out there's a gcc bug that prevents this from working > sometimes (including for DiskIoMgr::Init()).

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Turns out there's a gcc bug that prevents this from working sometimes (including for DiskIoMgr::Init()).

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#7). Change subject: IMPALA-2615: warn if Status is ignored

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/180/ -- To view, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: Code-Review+2 Missed one clang-tidy warning. Really need to figure out how to run it locally. -- To

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#6). Change subject: IMPALA-2615: warn if Status is ignored

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/166/ -- To

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/166/ -- To view, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 5: Also fixed the clang-tidy warnings (I had posted a draft earlier so I could use the dryrun jenkins job).

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if Status is ignored This introduces a WARN_UNUSED_RESULT macro. It can be used at the end of function

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#5). Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/3//COMMIT_MSG Commit Message: PS3, Line 10: in

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#4). Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: Code-Review+1 (1 comment) I'm ok with +2ing this as soon as clang-tidy warnings induced by these new

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 3: this draft looks fine to me. -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit