Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4878
To unsubscribe, visit
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2615: warn if Status is ignored
..
IMPALA-2615: warn if Status is ignored
This introduces a WARN_UNUSED_RESULT macro. It can be used at
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 7: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/4878
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 7:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/185/
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 7:
> Turns out there's a gcc bug that prevents this from working
> sometimes (including for DiskIoMgr::Init()).
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 7:
Turns out there's a gcc bug that prevents this from working sometimes
(including for DiskIoMgr::Init()).
Hello Impala Public Jenkins, Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4878
to look at the new patch set (#7).
Change subject: IMPALA-2615: warn if Status is ignored
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc
File
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 6:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/180/
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 6: Code-Review+2
Missed one clang-tidy warning. Really need to figure out how to run it locally.
--
To
Hello Impala Public Jenkins, Jim Apple, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4878
to look at the new patch set (#6).
Change subject: IMPALA-2615: warn if Status is ignored
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 5: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/166/
--
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/166/
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4878
To unsubscribe, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 5:
Also fixed the clang-tidy warnings (I had posted a draft earlier so I could use
the dryrun jenkins job).
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-2615: warn if Status is ignored
..
IMPALA-2615: warn if Status is ignored
This introduces a WARN_UNUSED_RESULT macro. It can be used at the end
of function
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4878
to look at the new patch set (#5).
Change subject: IMPALA-2615: warn if Status is ignored
..
IMPALA-2615: warn if
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4878/3//COMMIT_MSG
Commit Message:
PS3, Line 10: in
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4878
to look at the new patch set (#4).
Change subject: IMPALA-2615: warn if Status is ignored
..
IMPALA-2615: warn if
Jim Apple has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 3: Code-Review+1
(1 comment)
I'm ok with +2ing this as soon as clang-tidy warnings induced by these new
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2615: warn if Status is ignored
..
Patch Set 3:
this draft looks fine to me.
--
To view, visit http://gerrit.cloudera.org:8080/4878
To unsubscribe, visit
23 matches
Mail list logo