Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 7: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5251
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 7:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/77/
--
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 6: Code-Review+2
No, not necessary as mentioned early. Sorry, thought Marcel had +2 this one.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 6:
Any more comments? I don't think there were any more to address here, unless we
want
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 6:
It doesn't seem to cause any actual problems, so maybe I'll hold off on it.
That will
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 4:
(1 comment)
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5251
to look at the new patch set (#6).
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 4:
(2 comments)
Dan: so there's actually a special case in exprs/scalar-fn-call.cc that
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 4:
> > What about the try/catch block in timestamp-functions-ir.cc.
> > Shouldn't that code
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 4:
> What about the try/catch block in timestamp-functions-ir.cc.
> Shouldn't that
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 4:
What about the try/catch block in timestamp-functions-ir.cc. Shouldn't that
code be moved
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 4: Code-Review+2
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
Patch Set 3:
Rebased
--
To view, visit http://gerrit.cloudera.org:8080/5251
To unsubscribe, visit
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
..
IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
The bugs was that the functions did not
14 matches
Mail list logo