[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5251 To

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/77/ --

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 6: Code-Review+2 No, not necessary as mentioned early. Sorry, thought Marcel had +2 this one.

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 6: Any more comments? I don't think there were any more to address here, unless we want

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 6: It doesn't seem to cause any actual problems, so maybe I'll hold off on it. That will

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5251 to look at the new patch set (#6). Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp ..

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-01 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: (2 comments) Dan: so there's actually a special case in exprs/scalar-fn-call.cc that

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: > > What about the try/catch block in timestamp-functions-ir.cc. > > Shouldn't that code

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: > What about the try/catch block in timestamp-functions-ir.cc. > Shouldn't that

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: What about the try/catch block in timestamp-functions-ir.cc. Shouldn't that code be moved

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-30 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 3: Rebased -- To view, visit http://gerrit.cloudera.org:8080/5251 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-11-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp The bugs was that the functions did not