[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7711 To

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a 'backends' tab to query

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1139/ -- To

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7711 to look at the new patch set (#6). Change subject: IMPALA-5811: Add 'backends' tab to query details pages

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe,

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7711 to look at the new patch set (#5). Change subject: IMPALA-5811: Add 'backends' tab to query details pages

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 4: Code-Review+1 (1 comment) LGTM aside from one minor thing. Will give others a chance to

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 3: (2 comments) Added a test, thanks for the suggestion!

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 3: (1 comment) Could we add a basic test to run a couple of queries (including a DDL

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-22 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-18 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a 'backends' tab to query details pages

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 2: That's deliberate - preserve the last seen set of states. I could change something to

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 2: > Presumably the query was a DDL statement, so there was no > coordinator. Thanks for the

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a 'backends' tab to query details pages

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: Presumably the query was a DDL statement, so there was no coordinator. Thanks for the

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: Great supportability change. Mind adding a screenshot of the newly added tab? --

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 1: I tried this on my local machine while a query was running and hit a segfault in

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7711 Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a