[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 1: (44 comments) http://gerrit.cloudera.org:8080/#/c/4758/1//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 4: (24 comments) Thanks for the comments, please see PS4. As pointed out in one of the replies

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves performance

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-10-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3942 To

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 4: (2 comments) I think this makes sense. I mention an alternative inline, I'm OK either

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#5). Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. AnayticExpr.analyze() replaces the original

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/2/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (5 comments) The overall approach looks sane - had a few high-level

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. IMPALA-3676,4321: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#4). Change subject: IMPALA-2521: Add clustered hint to insert statements .. IMPALA-2521: Add clustered hint to insert statements This change introduces a clustered/noclustered hint for

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4758 Change subject: IMPALA-3676: Use clang as a static analysis tool .. IMPALA-3676: Use clang as a static analysis tool This patch adds a

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3420: use gold by default .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4751 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4732 To unsubscribe,

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). Change subject: IMPALA-2521: Add clustered hint to insert statements .. IMPALA-2521: Add clustered hint to insert statements This change introduces a clustered/noclustered hint for

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 1: (23 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-19 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#6). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4651 To unsubscribe,

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() This patch is mostly mechanical

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4758/1/be/src/util/aligned-new.h File

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. IMPALA-3920: TotalStorageWaitTime counter not populated

[Impala-ASF-CR] IMPALA-4269: Codegen merging exchange node

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4269: Codegen merging exchange node .. Patch Set 1: Code-Review+2 Change is a straightforward application of an existing pattern and I'm confident we

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage Previously, the

[Impala-ASF-CR] IMPALA-4269: Codegen merging exchange node

2016-10-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4759 Change subject: IMPALA-4269: Codegen merging exchange node .. IMPALA-4269: Codegen merging exchange node This change enables codegen for

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 8: (16 comments) http://gerrit.cloudera.org:8080/#/c/4047/7//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 3: (23 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 6: Build failed:

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#8). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4758/2/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 8: (7 comments)

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 6: Build failed:

[Impala-ASF-CR] IMPALA-3676,4321: Use clang as a static analysis tool

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-3676,4321: Use clang as a static analysis tool .. IMPALA-3676,4321: Use clang as a static analysis tool This patch adds a script to run clang-tidy over the

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. IMPALA-4230: ASF policy issues from 2.7.0 rc3. In our IPMC vote to release 2.7.0 rc3, Justing

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4582 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4756/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 4: (8 comments) Nice! Current PS looks good to me. Do you intent to add Kudu support in a

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3420: use gold by default .. IMPALA-3420: use gold by default Also pass the flag that enables ld.gold directly to the compiler. This is

[Impala-ASF-CR] IMPALA-3420: use gold by default

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3420: use gold by default .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4751 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 2: (3 comments) Thanks for adding the test. Almost good to be merged.

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#5). Change subject: IMPALA-2521: Add clustered hint to insert statements .. IMPALA-2521: Add clustered hint to insert statements This change introduces a clustered/noclustered hint for

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 4: (8 comments) > (8 comments) > > Nice! Current PS looks good to me. Do you intent to add

[Impala-ASF-CR] IMPALA-4269: Codegen merging exchange node

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4269: Codegen merging exchange node .. IMPALA-4269: Codegen merging exchange node This change enables codegen for the tuple row comparator

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-19 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 9: Code-Review+2 Rebase and carry MJ's +2. -- To view, visit

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-19 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has uploaded a new patch set (#2). Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate StmtRewrite lost parentheses of

[Impala-ASF-CR] IMPALA-4301: Fix IGNORE NULLS with subquery rewriting.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4301: Fix IGNORE NULLS with subquery rewriting. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4732 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 1: (1 comment) Thanks for finding and fixing this! Let me know if you have trouble with

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/4/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for

[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test

2016-10-19 Thread Laszlo Gaal (Code Review)
Hello Michael Ho, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4755 to review the following change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test ..

[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4755 To unsubscribe,

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 5: You're right, of course, I was confused. Ignore my previous comment. -- To

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 8: It's not clear to me how this is really any different from needs-to-return. Don't they

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 6: Code-Review+2 rebase, carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/4582 To

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 8: Not really - flush_resources without need_to_return implies 2a, whereas

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-10-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 8: Another way of looking at it is that ignoring flush_resources is a resource