Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5162
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
IMPALA-4343,IMPALA-4354: qgen: model
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#19).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new patch set (#2).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4440: lineage timestamps can go backwards across
daylight savings transitions
..
Patch Set 3: Code-Review+2
Rebase, carry +2.
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 2:
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Code-Review+2
Carry the +2
--
To view, visit http://gerrit.cloudera.org:8080/4863
To
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5164
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
IMPALA-4502: test_partition_ddl_predicates
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4432: Handle internal codegen disabling properly
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5105/5/be/src/exec/exec-node.cc
File
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4440: lineage timestamps can go backwards across
daylight savings transitions
..
Patch Set 2:
(3 comments)
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 18: Code-Review+1
Rebased and ran the relevant tests locally, carry +1.
--
To view, visit
Alex Behm has posted comments on this change.
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
Patch Set 1:
(1 comment)
Tim Armstrong has uploaded a new patch set (#3).
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing infrastructure for codegening builtin UDAs and
Michael Ho has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4715/5/be/src/bufferpool/suballocator.h
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5161
Change subject: IMPALA-1430: enable codegen for native UDAs
..
IMPALA-1430: enable codegen for native UDAs
This uses the existing
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5129
to look at the new patch set (#2).
Change subject: IMPALA-4440: lineage timestamps can go backwards across
daylight savings transitions
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#18).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Code-Review+1
Replaced NULL with nullptr as discussed in previous comments. Carry +1.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
Patch Set 1:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1: Code-Review+1
(3 comments)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
Patch Set 1: Code-Review+2
(1 comment)
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Verified-1
Build failed:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1:
(1 comment)
Alex Behm has uploaded a new patch set (#2).
Change subject: IMPALA-1788: Fold constant expressions.
..
IMPALA-1788: Fold constant expressions.
Adds a new ExprRewriteRule for replacing constant expressions
with their literal
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4014: Introduce query-wide execution state.
..
Patch Set 3:
(18 comments)
Looked over the ref count logic so far.
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5125
to look at the new patch set (#3).
Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 2: Code-Review+1
--
To view, visit
Dimitris Tsirogiannis has uploaded a new patch set (#2).
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
IMPALA-2890: Support ALTER TABLE statements for Kudu tables
With this commit, we add
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4511: Add missing total_time_counter() to PFE::Exec()
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5149
To unsubscribe,
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5165
Change subject: IMPALA-3200: move bufferpool under runtime
..
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5164
to look at the new patch set (#3).
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
Sailesh Mukil has uploaded a new patch set (#2).
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS filesystems
This is
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4363: Add Parquet timestamp validation
..
Patch Set 7:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4968/7/be/src/exec/parquet-column-readers.cc
File
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 5:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 2:
(8 comments)
I understand the problem, and I think I see what you're doing
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
Patch Set 1: Code-Review+1
(1 comment)
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19:
Build failed:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3342: Add thread counters to monitor plan fragment
execution
..
Patch Set 9: Code-Review+2
Looks good to me.
--
To view, visit
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
Patch Set 2:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
Patch Set 2: Code-Review+2
carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/5152
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1: Code-Review+1
(3 comments)
Thanks for the review. Carry +1
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
Patch Set 2: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3342: Add thread counters to monitor plan fragment
execution
..
Patch Set 9: Code-Review+1
Looks okay to me once Henry signs off.
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-4432: Handle internal codegen disabling properly
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5105/5/be/src/exec/exec-node.cc
File
Lars Volker has uploaded a new patch set (#6).
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
IMPALA-4494: Fix crash in SimpleScheduler
The scheduler maintains a local list of active backends, which is
updated
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
..
Patch Set 2: Verified-1
Build failed:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
..
Patch Set 3: Code-Review+2
The Cmake script didn't handle be tests living in a subdirectory - fixed it.
--
To
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4516: Don't hold process wide lock
connection_to_sessions_map_lock_ while cancelling queries
..
Patch Set 1:
Stress test running successfully for 5
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5173
Change subject: IMPALA-4516: Don't hold process wide lock
connection_to_sessions_map_lock_ while cancelling queries
..
IMPALA-4516:
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.
..
Patch Set 3: Verified-1
Build failed:
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4514: Fix broken exhaustive builds caused by
non-nullable columns
..
IMPALA-4514: Fix broken exhaustive builds caused by non-nullable columns
Hello Michael Brown,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5135
to look at the new patch set (#5).
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
Alex Behm has posted comments on this change.
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
Patch Set 2:
(2 comments)
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5152
To unsubscribe,
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced
David Knupp has uploaded a new patch set (#3).
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
IMPALA-4510: Selectively filter args for metric verification tests
run-tests.py is a wrapper
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.
..
Patch Set 3:
Build failed:
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1:
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5135
To
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19:
Build failed:
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19:
Build failed:
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.
..
Patch Set 3:
Build failed:
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5162
to look at the new patch set (#4).
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4432: Handle internal codegen disabling properly
..
Patch Set 6:
(4 comments)
Thanks, this is much easier to follow now. It'd be good for Tim to take
David Knupp has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 4:
While I'm in this file, make a quick fix to not run tests if the user just
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 1:
(1 comment)
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4440: lineage timestamps can go backwards across
daylight savings transitions
..
Patch Set 3: Verified+1
--
To view, visit
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4514: Fix broken exhaustive builds caused by
non-nullable columns
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5157
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5162
to look at the new patch set (#3).
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
Alex Behm has posted comments on this change.
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
Patch Set 2:
(18 comments)
David Knupp has uploaded a new patch set (#4).
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
IMPALA-4510: Selectively filter args for metric verification tests
run-tests.py is a wrapper
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4440: lineage timestamps can go backwards across
daylight savings transitions
..
IMPALA-4440: lineage timestamps can go backwards across
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4478: Initial Kudu client mem tracking for sink
..
IMPALA-4478: Initial Kudu client mem tracking for sink
The Kudu client allocates memory
Michael Brown has posted comments on this change.
Change subject: IMPALA-4510: Selectively filter args for metric verification
tests
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5135
To
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.
..
Patch Set 3:
Build failed:
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
Patch Set 1:
(1 comment)
Forgotten comment and some minor test fixes.
Dimitris Tsirogiannis has uploaded a new patch set (#3).
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
IMPALA-2890: Support ALTER TABLE statements for Kudu tables
With this commit, we add
Michael Brown has posted comments on this change.
Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs
from query model
..
Patch Set 4: Code-Review+1
I've simply chosen different names for the objects,
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4511: Add missing total_time_counter() to PFE::Exec()
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5149
To
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4511: Add missing total_time_counter() to PFE::Exec()
..
IMPALA-4511: Add missing total_time_counter() to PFE::Exec()
Also add sanity check
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
Hello Marcel Kornacker, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5165
to look at the new patch set (#3).
Change subject: IMPALA-3200: move bufferpool under runtime
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4502: test_partition_ddl_predicates breaks on non-HDFS
filesystems
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5164
Bharath Vissapragada has uploaded a new patch set (#2).
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
This patch improves the
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
Patch Set 2:
Moved disk-id-mapping logic to a new class as discussed with Alex.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe,
Alex Behm has posted comments on this change.
Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
..
Patch Set 2:
(18 comments)
High-level comments. Let's get through them first and then I can dig
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4516: Don't hold process wide lock
connection_to_sessions_map_lock_ while cancelling queries
..
Patch Set 1:
Change looks safe to me. We should update
Taras Bobrovytsky has uploaded a new patch set (#2).
Change subject: Preview: IMPALA-4467: Add support for CRUD operations in stress
test
..
Preview: IMPALA-4467: Add support for CRUD operations in stress test
NOTE: This is a
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4494: Fix crash in SimpleScheduler
..
Patch Set 6: Code-Review+1
(1 comment)
Thanks for your patience, I think this is looking good.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
..
Patch Set 3:
Build started:
Dimitris Tsirogiannis has uploaded a new patch set (#4).
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
IMPALA-2890: Support ALTER TABLE statements for Kudu tables
With this commit, we add
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables
..
Patch Set 2:
(19 comments)
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3200: move bufferpool under runtime
..
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent of the runtime system
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#17).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 16:
(3 comments)
Thanks for the review. I addressed the comments in PS17 and will rebase
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4956
to look at the new patch set (#9).
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory
..
Patch Set 7:
(1 comment)
99 matches
Mail list logo