[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7168 Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. IMPALA-5494: NOT IN predicate shares the

[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. Patch Set 2: removed extraneous space characters. -- To view, visit

[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. This

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5495: Improve error message if no impalad role is configured .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7167/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Henry Robinson (Code Review)
Hello anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7167 to look at the new patch set (#2). Change subject: IMPALA-5495: Improve error message if no impalad role is configured

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-06-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. Patch Set 1: (3 comments) I've read through roughly half of impala_adls.xml and noticed a few things.

[Impala-ASF-CR] IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs .. Patch Set 5: -Verified (2 comments) It looks like I ran the tests against the wrong

[Impala-ASF-CR] WIP Test Modification

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. Change subject: WIP Test Modification .. Abandoned Pushed by mistake -- To view, visit http://gerrit.cloudera.org:8080/7173 To unsubscribe, visit

[Impala-ASF-CR] WIP Test Modification

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7173 Change subject: WIP Test Modification .. WIP Test Modification Change-Id: I6b1bd6bb7febbaa8a76e34581ad4b6c849a96620 --- M

[Impala-ASF-CR] IMPALA-5333: [DOCS] Document Impala ADLS support

2017-06-13 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7175 Change subject: IMPALA-5333: [DOCS] Document Impala ADLS support .. IMPALA-5333: [DOCS] Document Impala ADLS support Change-Id:

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5495: Improve error message if no impalad role is configured .. Patch Set 2: Code-Review+2 Thanks for fixing this :) -- To view, visit

[Impala-ASF-CR] IMPALA-5499: avoid ephemeral port conflicts

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5499: avoid ephemeral port conflicts .. IMPALA-5499: avoid ephemeral port conflicts We should not select the same port twice, which could happen because

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-13 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 4: (17 comments) Thanks for the detailed review. addressed review comments.

[Impala-ASF-CR] IMPALA-5499: avoid ephemeral port conflicts

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5499: avoid ephemeral port conflicts .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7171/1/be/src/statestore/statestore-test.cc File

[Impala-ASF-CR] IMPALA-5499: avoid ephemeral port conflicts

2017-06-13 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5499: avoid ephemeral port conflicts .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7171/1/be/src/util/network-util.cc File

[Impala-ASF-CR] IMPALA-5499: avoid ephemeral port conflicts

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5499: avoid ephemeral port conflicts .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7171/1/be/src/statestore/statestore-test.cc File

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#6). Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. IMPALA-5061: Populate null_count in parquet::statistics The null_count in the statistics field is

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-13 Thread sandeep akinapelli (Code Review)
sandeep akinapelli has uploaded a new patch set (#4). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change introduces a

[Impala-ASF-CR] IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#6). Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs .. IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs There was a race

[Impala-ASF-CR] IMPALA-5263: test infra: support CA bundles with secure clusters

2017-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters .. IMPALA-5263: test infra: support CA bundles with secure clusters This patch

[Impala-ASF-CR] IMPALA-5263: test infra: support CA bundles with secure clusters

2017-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7152 To

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 6: (9 comments)

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5495: Improve error message if no impalad role is configured .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7167

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role is configured

2017-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5495: Improve error message if no impalad role is configured .. IMPALA-5495: Improve error message if no impalad role is configured

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message

2017-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message .. Patch Set 6: Code-Review+2 Thanks for fixing the nits. I'll run the pre commit job

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7168/3/tests/metadata/test_explain.py

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#6). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message

2017-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option

2017-06-13 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new change for review. http://gerrit.cloudera.org:8080/7178 Change subject: IMPALA-5506: Add stdin description to help information of query_file option .. IMPALA-5506: Add stdin description to help

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#5). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 6: (6 comments) Thanks for adding the new test!

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: This is a reasonable extension of the single node optimization. I haven't gone

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

2017-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 4: (4 comments) We're almost done here, nice work!

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 3: (1 comment) Thanks for finding and fixing this.

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

2017-06-13 Thread Donghui Xu (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7166 to look at the new patch set (#4). Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

2017-06-13 Thread Donghui Xu (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7166 to look at the new patch set (#5). Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message

2017-06-13 Thread Donghui Xu (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7166 to look at the new patch set (#6). Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-13 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. IMPALA-5061: Populate null_count in parquet::statistics The null_count in the statistics field is

[Impala-ASF-CR] IMPALA-5286/IMPALA-5283: Kudu column name case cleanup

2017-06-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-5286/IMPALA-5283: Kudu column name case cleanup .. IMPALA-5286/IMPALA-5283: Kudu column name case cleanup Impala is case insensitive for column

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5483: Automatically disable codegen for small queries .. IMPALA-5483: Automatically disable codegen for small queries This is similar to the single-node

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: Interested what you think about this approach - it seems like a big win for some

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7168/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. Patch Set 10: (23 comments)

[Impala-ASF-CR] IMPALA-5483: Automatically disable codegen for small queries

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5483: Automatically disable codegen for small queries .. Patch Set 3: 1. Pretty big. The single node optimisation defaults to 100 rows total, this is

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

2017-06-13 Thread Donghui Xu (Code Review)
Donghui Xu has uploaded a new patch set (#3). Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction .. IMPALA-5492: Fix incorrect newline character in the LDAP message

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

2017-06-13 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction .. Patch Set 3: (2 comments) I have resolved the problems you

[Impala-ASF-CR] IMPALA-5263: test infra: support CA bundles with secure clusters

2017-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-06-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6812/3/be/src/exec/hdfs-parquet-scanner.cc File

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4856: Port data stream service to KRPC .. IMPALA-4856: Port data stream service to KRPC This patch ports the data-flow parts of ImpalaInternalService to

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7103/2/be/src/rpc/rpc.h File be/src/rpc/rpc.h:

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-06-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5720 to look at the new patch set (#13). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 3: (17 comments)

[Impala-ASF-CR] IMPALA-5495: Improve error message if no impalad role configured

2017-06-13 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5495: Improve error message if no impalad role configured .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7167/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/7103/2/be/src/rpc/rpc.h File be/src/rpc/rpc.h:

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7103/2/be/src/rpc/rpc.h File be/src/rpc/rpc.h: PS2,

[native-toolchain-CR] Support gcc 6.3.0 and 7.1.0

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Support gcc 6.3.0 and 7.1.0 .. Support gcc 6.3.0 and 7.1.0 The default still remains gcc 4.9.2 but this lets us play around with different GCC

[Impala-ASF-CR] IMPALA-5499: avoid ephemeral port conflicts

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7171 Change subject: IMPALA-5499: avoid ephemeral port conflicts .. IMPALA-5499: avoid ephemeral port conflicts We should not select the

[Impala-ASF-CR] IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs

2017-06-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs .. Patch Set 5: (2 comments)

[native-toolchain-CR] Support gcc 6.3.0 and 7.1.0

2017-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Support gcc 6.3.0 and 7.1.0 .. Patch Set 2: Verified+1 Ran a successful test build -- To view, visit http://gerrit.cloudera.org:8080/7156 To unsubscribe,

[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. Patch Set 2: (4 comments) Patch looks good to me overall, I can +1 it

[Impala-ASF-CR] IMPALA-5061: Populate null count in parquet::statistics

2017-06-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5061: Populate null_count in parquet::statistics .. Patch Set 5: (9 comments)