[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7476 To unsubscribe,

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. IMPALA-5689: Avoid inverting non-equi left joins When checking if a join can be inverted,

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 3: Yeah I didn't realise it was a draft. If you address Taras' comments then rebase I

[Impala-ASF-CR] IMPALA-5739: Correctly handle sles12 SP2

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-5739: Correctly handle sles12 SP2 .. IMPALA-5739: Correctly handle sles12 SP2 This takes care of the difference in outputs for SLES 12 SP1 and

[Impala-ASF-CR] IMPALA-5739: Correctly handle sles12 SP2

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5739: Correctly handle sles12 SP2 .. Patch Set 2: Verified+1 Thanks Hector! I don't think there's any point running our standard pre-commit tests since

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5739 Correctly handle sles12 SP2

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5739 Correctly handle sles12 SP2 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7535/1//COMMIT_MSG Commit Message: Line 7:

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 27: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/948/ -- To

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/946/ -- To view,

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7514/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7408/4/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 6: Code-Review+1 Carry +1 from kwho -- To view, visit http://gerrit.cloudera.org:8080/7408 To

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5715 To

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/2/tests/query_test/test_insert_parquet.py File

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/949/

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IMPALA-4669: [KUTIL] Add kudu_util library to the build. A few miscellaneous changes to

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 27: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe,

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. Patch Set 1: Does the toolchain version need to be bumped as well? -- To view, visit

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-28 Thread Bikramjeet Vig (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7527 to look at the new patch set (#2). Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-5636: Change the metadata in parquet .. IMPALA-5636: Change the metadata in parquet When writing in parquet format, Impala does not use repetition level. But

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Code-Review+2 Rebased the change after hitting the same Kudu issue again. Carrying Tim's +2. --

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/953/ -- To view,

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-28 Thread Lars Volker (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7518 to look at the new patch set (#3). Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. IMPALA-5009:

[Impala-ASF-CR] IMPALA-5636: change the metadata in parquet

2017-07-28 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7514 to look at the new patch set (#4). Change subject: IMPALA-5636: change the metadata in parquet .. IMPALA-5636:

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: Code-Review+1 The explanation seems acceptable to me, we won't be missing out on a huge

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-28 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Build a ConcatenatedStreams wrapper for ScannerContext::Stream The ConcatenatedStreams class

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-28 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Build a ConcatenatedStreams wrapper for ScannerContext::Stream The ConcatenatedStreams class

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-28 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7521 To unsubscribe,

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5636: Change the metadata in parquet .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/952/ -- To view, visit

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. Patch Set 1: We have been building OpenSSL-1.0.1p all along so the toolchain version isn't changed per-se.

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-28 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7514 to look at the new patch set (#5). Change subject: IMPALA-5636: Change the metadata in parquet .. IMPALA-5636:

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. Patch Set 1: Code-Review+2 No, if it's already in the current toolchain version you don't need a separate

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-28 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-28 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-28 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: Code-Review+1 Great analysis. -- To view, visit http://gerrit.cloudera.org:8080/7521 To

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5636: Change the metadata in parquet .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7514 To unsubscribe, visit

[native-toolchain-CR] Bump breakpad version to include fix for IMPALA-4226

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7538 Change subject: Bump breakpad version to include fix for IMPALA-4226 .. Bump breakpad version to include fix for IMPALA-4226 Change-Id:

[native-toolchain-CR] Bump breakpad version to include fix for IMPALA-4226

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Bump breakpad version to include fix for IMPALA-4226 .. Patch Set 1: Patches applied cleanly. -- To view, visit http://gerrit.cloudera.org:8080/7538 To

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-28 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#4). Change subject: IMPALA-5394: Handle blocked HS2 connections .. IMPALA-5394: Handle blocked HS2 connections - TThreadPoolServer calls getTransport() on a client from the Server

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Code-Review+1 Looks good to me. Will give Jim a chance to weigh in if he has further comments. -- To

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py To support KRPC on legacy platforms

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7532 To unsubscribe,

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7408 to look at the new patch set (#5). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417:

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5722: Fix string to decimal cast .. IMPALA-5722: Fix string to decimal cast When converting a string to a decimal, we didn't handle the case where the

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/956/ -- To view, visit

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id:

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4554 To unsubscribe, visit

[native-toolchain-CR] Bump breakpad version to include fix for IMPALA-4226

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Bump breakpad version to include fix for IMPALA-4226 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7538 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Hit another flaky test :( - Trying again. -- To view, visit http://gerrit.cloudera.org:8080/4554

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/954/ -- To view,

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#5). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/7530/4/be/src/exprs/timestamp-functions-ir.cc

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-28 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7517 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-28 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-07-28 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. IMPALA-4939, IMPALA-4939: Decimal V2 multiplication Implement the new DECIMAL return type rules for