[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-06 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7870 to look at the new patch set (#4). Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-06 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7977 Change subject: IMPALA-5902: add ThreadSanitizer build .. IMPALA-5902: add ThreadSanitizer build This is sufficient to get Impala to

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1202/ -- To

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7933 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/7977/1/be/src/common/init.cc File

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7977/1/tests/common/environ.py File

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. IMPALA-4826: Fix error during a scan on repeated root schema in

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1203/ -- To view, visit

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. IMPALA-5589: change "set" in impala-shell to show

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 1: Filed IMPALA-5905 -- To view, visit http://gerrit.cloudera.org:8080/7977 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5902: add ThreadSanitizer build .. IMPALA-5902: add ThreadSanitizer build This is sufficient to get Impala to come up and run queries with thread sanitizer

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7977 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml File

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > > > > (1 comment) > > > > > > The tests in this change use only

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > > > (1 comment) > > > > The tests in this change use only 3 query

[Impala-ASF-CR] IMPALA-5812: Fix NPE when joining on empty const select

2017-09-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5812: Fix NPE when joining on empty const select .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7971/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7933 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5317: add DATE_TRUNC() function .. IMPALA-5317: add DATE_TRUNC() function Added a UDF builtin function date_trunc. Reuse many of the

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7313 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 6: (2 comments) Fixed the tests. Figured out that the problem was with

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 2: Code-Review+1 LGTM, Joe may want to take a look, too. -- To view, visit

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. Patch Set 2: (10 comments)

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 1: (8 comments) Nice, thanks for taking this on. Can you file a ticket to add this to

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-06 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7910 to look at the new patch set (#5). Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. IMPALA-5867: Fix

[Impala-ASF-CR] IMPALA-5812: Fix NPE when joining on empty const select

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5812: Fix NPE when joining on empty const select .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1201/ -- To

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG Commit Message: PS3, Line 22: 1. A

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7933/2/be/src/exec/hdfs-parquet-scanner.cc

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-06 Thread Tianyi Wang (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7910 to look at the new patch set (#4). Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. IMPALA-5867: Fix

[Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan

2017-09-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan .. Abandoned Need to rewrite this patch completely. -- To view, visit

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > For this options serialization question, we have a C++ >

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull conditional. .. Patch Set 5: * Correct! The BE code and all the associated function plumbing for IFNULL should be removed. * We

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5888: free other local allocations in Parquet .. IMPALA-5888: free other local allocations in Parquet Testing: I wasn't able to produce

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7933 To unsubscribe,

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5902: add ThreadSanitizer build .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7977 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. IMPALA-4620: Refactor evalcost computation in query analysis This patch adds a

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7948 To

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#6). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#7). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 3: Code-Review+2 I was able to look at this with fresh eyes. Looks good, I will start the merge. -- To

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1204/ -- To view, visit

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1205/ --

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull conditional. .. Patch Set 5: Alex, Thanks for your reviews. I put together a new diff which ties to do the re-write. The

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Joe McDonnell (Code Review)
Hello Sailesh Mukil, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7730 to look at the new patch set (#12). Change subject: IMPALA-5750: Catch exceptions from boost thread creation

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 11: (1 comment) Rebased all the way and incorporated changes from IMPALA-5892.

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: For this options serialization question, we have a C++ implementation of

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1206/ --

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. IMPALA-5892: Allow reporting status independent of fragment instance

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps

2017-09-06 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7983 Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps .. [DOCS] Explain Boost setting needed for 96-bit timestamps

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7730 To unsubscribe,

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7943

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.

2017-09-06 Thread Philip Zeyliger (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7829 to look at the new patch set (#5). Change subject: IMPALA-5211: Simplifying ifnull conditional. .. IMPALA-5211:

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7313 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.) .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5812: Fix NPE when joining on empty const select

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5812: Fix NPE when joining on empty const select .. IMPALA-5812: Fix NPE when joining on empty const select A NPE is thrown during the

[Impala-ASF-CR] IMPALA-5812: Fix NPE when joining on empty const select

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5812: Fix NPE when joining on empty const select .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7971 To

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 7: (15 comments) Still thinking about the warning/logging.

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. IMPALA-5750: Catch exceptions from boost thread creation The boost thread

[Impala-ASF-CR] IMPALA-5750: Catch exceptions from boost thread creation

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5750: Catch exceptions from boost thread creation .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7730 To

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG Commit Message: PS3, Line 22:

[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.

2017-09-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has abandoned this change. Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7937 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1641: adds an end-to-end test to capture current behavior.

2017-09-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. Change subject: IMPALA-1641: adds an end-to-end test to capture current behavior. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5812: Fix NPE when joining on empty const select

2017-09-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5812: Fix NPE when joining on empty const select .. IMPALA-5812: Fix NPE when joining on empty const select A NPE is thrown during the creation of the

[Impala-ASF-CR] IMPALA-4620: Refactor evalcost computation in query analysis

2017-09-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-4620: Refactor evalcost computation in query analysis .. IMPALA-4620: Refactor evalcost computation in query analysis This patch adds a computeEvalCost

[Impala-ASF-CR] IMPALA-5812: Fix NPE when joining on empty const select

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5812: Fix NPE when joining on empty const select .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7971 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5888: free other local allocations in Parquet

2017-09-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5888: free other local allocations in Parquet .. Patch Set 2: Code-Review+1 This makes sense to me. -- To view, visit

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7870 To

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7975 Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: I4fb177b80f6c193af3f6b6bf9d7b205ab31d2f3e ---

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to a71ecfd .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7975 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4826: Fix error during a scan on repeated root schema in Parquet.

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4826: Fix error during a scan on repeated root schema in Parquet. .. Patch Set 4: Build started:

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: I4fb177b80f6c193af3f6b6bf9d7b205ab31d2f3e --- M buildall.sh 1 file changed, 1

[native-toolchain-CR] Bump Kudu version to a71ecfd

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to a71ecfd .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7975 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options

2017-09-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query options .. Patch Set 4: My apologies! I failed to run some of the tests in my

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 3: (1 comment) One reason that this is a lot safer than the old code is that all of the data

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 1: (10 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 4: (2 comments) Responding to comments, will look at code next.

[Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5902: add ThreadSanitizer build .. IMPALA-5902: add ThreadSanitizer build This is sufficient to get Impala to come up and run queries

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 2: (3 comments) Also rebased all the way.

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Joe McDonnell (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7943 to look at the new patch set (#3). Change subject: IMPALA-5892: Allow reporting status independent of fragment instance

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance

2017-09-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5892: Allow reporting status independent of fragment instance .. Patch Set 3: Code-Review+2 Carrying Dan's +2. -- To view, visit