[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: > > The HDFS-5776 JIRA mentions that it's implemented for the pread() > > code

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: > The HDFS-5776 JIRA mentions that it's implemented for the pread() > code path,

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4676: remove the last reference to BlockStorageLocation

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4676: remove the last reference to BlockStorageLocation .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5633 To

[Impala-ASF-CR] IMPALA-4676: remove the last reference to BlockStorageLocation

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4676: remove the last reference to BlockStorageLocation .. IMPALA-4676: remove the last reference to BlockStorageLocation Change-Id:

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/150/ --

[Impala-ASF-CR] Change one instance of namenode to NameNode

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Change one instance of namenode to NameNode .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5594/1//COMMIT_MSG Commit Message: Line 7:

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5635 To

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 6: (10 comments)

[Impala-ASF-CR] IMPALA-4536: Decimal Parquet slots should be validated

2017-01-06 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4536: Decimal Parquet slots should be validated .. Patch Set 1: > If there's any interest, I could add this functionality to the > parquet-reader

[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Global search/replace: audience="Cloudera" -> audience="hidden". .. Patch Set 2: Code-Review+1 Verified+1 I've resolved the conflict with another CR and verified

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Global search/replace: audience="Cloudera" -> audience="hidden".

2017-01-06 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: Global search/replace: audience="Cloudera" -> audience="hidden". .. Global search/replace: audience="Cloudera" -> audience="hidden". For this change to land in

[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: Apply attribute to hide main data source topic in keydef tag. .. Apply attribute to hide main data source topic in keydef tag. Use the same audience=

[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Apply attribute to hide main data source topic in keydef tag. .. Patch Set 2: Code-Review+2 Verified+1 (2 comments) I'll +2 this myself after verifying. The

[Impala-ASF-CR] Apply attribute to hide main data source topic in keydef tag.

2017-01-06 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: Apply attribute to hide main data source topic in keydef tag. .. Apply attribute to hide main data source topic in keydef tag. Use the same audience= attr as the

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 2: > Patch Set 1: Verified+1 Next time, can you please use

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5631/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. IMPALA-4716: Expr rewrite causes IllegalStateException The DECODE constructor in CaseExpr uses

[Impala-ASF-CR] IMPALA-3398: Remove references to a particular Cloudera server.

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Remove references to a particular Cloudera server. .. Patch Set 3: > Patch Set 2: Verified+1 Hi John. In the future, can you please use

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: (13 comments)

[Impala-ASF-CR] Add audience="hidden" to DITAVal.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: Add audience="hidden" to DITAVal. .. Add audience="hidden" to DITAVal. That's an alias for audience="Cloudera", which will be removed in a subsequent

[Impala-ASF-CR] Add audience="hidden" to DITAVal.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add audience="hidden" to DITAVal. .. Patch Set 2: Code-Review+2 Verified+1 Trivial change by itself, but it's the foundation for some other CRs. -- To view,

[Impala-ASF-CR] Add audience="hidden" to DITAVal.

2017-01-06 Thread John Russell (Code Review)
Hello Anonymous Coward #250, Ambreen Kazi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5591 to look at the new patch set (#2). Change subject: Add audience="hidden" to DITAVal. .. Add

[Impala-ASF-CR] Remove one instance of invisible metatag.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: Remove one instance of invisible metatag. .. Remove one instance of invisible metatag. A 'category' metatag with the value 'CDH'. There's one other

[Impala-ASF-CR] Remove one instance of invisible metatag.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Remove one instance of invisible metatag. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5627 To unsubscribe, visit

[Impala-ASF-CR] Make sure 'errata' page is hidden.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: Make sure 'errata' page is hidden. .. Make sure 'errata' page is hidden. The errata page is in an early experimental form and not expected to be ready

[Impala-ASF-CR] Make sure 'errata' page is hidden.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Make sure 'errata' page is hidden. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5625 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3398: Remove references to a particular Cloudera server.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: IMPALA-3398: Remove references to a particular Cloudera server. .. IMPALA-3398: Remove references to a particular Cloudera server. Sometimes the

[Impala-ASF-CR] IMPALA-3398: Remove references to a particular Cloudera server.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3398: Remove references to a particular Cloudera server. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5621 To

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5596 To

[Impala-ASF-CR] Take out (stale) architecture diagram w/ Cloudera-specific terminology.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: Take out (stale) architecture diagram w/ Cloudera-specific terminology. .. Take out (stale) architecture diagram w/ Cloudera-specific terminology.

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread John Russell (Code Review)
John Russell has submitted this change and it was merged. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. IMPALA-3402: Change version numbers in shared variables file. Some instances of 'CDH'

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5626 To unsubscribe,

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4212: Add sink output expressions to explain output

2017-01-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4212: Add sink output expressions to explain output .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5635 To

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5626 To unsubscribe,

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. Patch Set 1: Did some quick tests locally to make sure HDFS still works; currently running

[Impala-ASF-CR] IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads

2017-01-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5635 Change subject: IMPALA-4740: Add option to use hdfsPread() for HDFS hedged reads .. IMPALA-4740: Add option to use hdfsPread() for HDFS

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread John Russell (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5626 to look at the new patch set (#2). Change subject: IMPALA-3402: Change version numbers in shared variables file. ..

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-4617: remove IsConstant() analysis from be .. IMPALA-4617: remove IsConstant() analysis from be This change avoids the need to duplicate the logic in

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3402: Change version numbers in shared variables file.

2017-01-06 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3402: Change version numbers in shared variables file. .. Patch Set 1: (1 comment) Just making a little followup change that I'll post as patch set 2

[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.

2017-01-06 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5634 Change subject: IMPALA-278: Mention DIV arithmetic operator. .. IMPALA-278: Mention DIV arithmetic operator. Also touch up the

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-06 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5389 to look at the new patch set (#5). Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows

[Impala-ASF-CR] IMPALA-4676: remove the last reference to BlockStorageLocation

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5633 Change subject: IMPALA-4676: remove the last reference to BlockStorageLocation .. IMPALA-4676: remove the last reference to

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5401 To unsubscribe,

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. IMPALA-2605: Omit the sort and mini stress tests These stress tests were sometimes causing

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2017-01-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4490 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5631/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5631 Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. IMPALA-4716: Expr rewrite causes

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2017-01-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 3: Agree with Tim about the template code changes, and there's less

[Impala-ASF-CR] IMPALA-3882: Simplify some query exec state locking

2017-01-06 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking .. Patch Set 6: (1 comment) Abandoned this for now: Sailesh's comment lead me down a rat hole that I don't

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-1430: enable codegen for native UDAs .. IMPALA-1430: enable codegen for native UDAs This uses the existing infrastructure for codegening builtin UDAs and

[Impala-ASF-CR] IMPALA-1430: enable codegen for native UDAs

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430: enable codegen for native UDAs .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5161/6/be/src/exprs/agg-fn-evaluator.cc File

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: I had to rebase to get a Jenkins build going, so there are spurious diffs in

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 3: > (1 comment) I was wrong: -fwrapv does stop ubsan from checking for

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior sanitizer, aka "ubsan". Ubsan checks for undefined

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/151/ -- To

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 5: Code-Review+2 rebase carry TIm's +2 -- To view, visit http://gerrit.cloudera.org:8080/5401 To

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5401 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/150/ -- To view,

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 3: Code-Review+2 (1 comment) Carry +2

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-06 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Jim Apple, Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5615 to look at the new patch set (#3). Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr

[Impala-ASF-CR] IMPALA-2605: Omit the sort and mini stress tests

2017-01-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2605: Omit the sort and mini stress tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5401/3/tests/stress/test_mini_stress.py File

[Impala-ASF-CR] IMPALA-4536: Decimal Parquet slots should be validated

2017-01-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4536: Decimal Parquet slots should be validated .. Patch Set 1: > If there's any interest, I could add this functionality to the > parquet-reader tool,

[Impala-ASF-CR] IMPALA-4707: fix use-after-free in QueryExecMgr

2017-01-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr .. Patch Set 2: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/149/ --