[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread Ishaan Joshi (Code Review)
Ishaan Joshi has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5877/7/tests/conftest.py File test

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 19: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/247/ -- To view, visi

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5931/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5933 To unsubscribe,

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. IMPALA-4810: Make DECIMAL expr-test cases table driven That way, we can easily run all

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5917/1/testdata/workloads/f

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. IMPALA-4849: IllegalStateException from rewritten CASE expr In SelectList.reset(), we call

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5914/1//COMMIT_MSG Commit Me

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. IMPALA-4731: Crash when sorting on non-deterministic expr When sorting on a non-deterministic

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5828 To unsubscribe,

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. IMPALA-1427: Improvements to "Unknown disk-ID" warning - Removes the runtime unknown d

[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5923 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/36/ -- To view, visit h

[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-07 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5923 To unsubscribe, visit http://ger

[Impala-ASF-CR] [DOCS] Apply conditionalization to tags.

2017-02-07 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: [DOCS] Apply conditionalization to tags. .. Abandoned These same changes are part of gerrit # 5923 which is much more comprehensive. Not worth the conflict resolution ju

[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5923/1/docs/impala_keydefs.ditamap File docs/impala_k

[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-07 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. IMPALA-4643: [DOCS] Set up many new keydefs Make keydefs corresponding to most of the links (especially external link

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 19: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/247/ -- To view, visit http://g

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#19). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Imple

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/18/be/src/udf/udf.h File be/src/udf/udf.h: PS18, Line 582:

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/246/ -- To

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 3: Code-Review+2 (1 comment) Carry Michael's +2. http://gerrit.cloudera.org:8080/#/c/5933/2/be/

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Hello Michael Ho, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5933 to look at the new patch set (#3). Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven ...

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/18/be/src/udf/udf.h File be/src/udf/udf.h: PS1

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/2/be/src/exprs/expr-test.

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG Commit Message: PS1, Lin

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Hello Michael Ho, Zach Amsden, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5933 to look at the new patch set (#2). Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven ...

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/5161/18/fe/src/main/java/org/apache/impal

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. IMPALA-3909 (follow-up): Properly qualify min() and max() in header parq

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5916 T

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5877 To unsubscr

[Impala-ASF-CR] IMPALA-4643: [DOCS] Set up many new keydefs

2017-02-07 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Set up many new keydefs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5923/1/docs/impala_keydefs.ditamap File docs/impala_k

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG Commit Message: PS1, Li

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5933/1/be/src/exprs/expr-test

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/5931/1/docs/shared/impala_common

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: Code-Review+1 Looks pretty straightforward -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#18). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLAC

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-07 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5931/1/docs/shared/impala_common.x

[Impala-ASF-CR] Impala ABM / LZCNT support

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: Impala ABM / LZCNT support .. Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns out this can be done much

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5816/4/be/src/exec/union-node.cc File be/src/exec/unio

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#17). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLAC

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/16/testdata/workloads/functional-query/queries/QueryTest/ex

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5933 Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. IMPALA-4810: Make DECIMAL expr-test cases table driven That way, w

[Impala-ASF-CR] IMPALA-3410 [DOCS] Rework Impala security topics to be generic

2017-02-07 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new change for review. http://gerrit.cloudera.org:8080/5931 Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic .. IMPALA-3410 [DOCS] Rework Impala security topics to be g

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. IMPALA-4828: Alter Kudu schema outside Impala may crash on read Creating a table in Impala, cha

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5840/2/be/src/exec/kudu-scanner

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/5847/4/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/udf/udf.cc File be/src/udf/udf.cc: Line 520: s

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/exprs/string-functions-ir.cc File be/src/exprs/s

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. Patch Set 3: (20 comments) http://gerrit.cloudera.org:8080/#/c/5847/3//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-02-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. Patch Set 5: (56 comments) Thanks for the reviews. http://gerrit.cloudera.org:8080/#/c/5816/5//COMMIT

[Impala-ASF-CR] IMPALA-3748: Part 1: Clean up resource estimation in planner

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3748: Part 1: Clean up resource estimation in planner .. IMPALA-3748: Part 1: Clean up resource estimation in planner This is in preparation to use this cod

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5840/2/be/src/exec/kudu-scanne

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/245/ -- To

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-3586: Implement union passthrough .. IMPALA-3586: Implement union passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5916/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5916/2//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Full trace, if someone is interested. 16:35:06 INFO:bootstrap_virtualenv:Installin

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Looks like it is not related to the PATCH. Can someone please re-trigger this job?

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryru

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 2: Code-Review+2 (1 comment) Thank you for keeping the code tidy, Henry! http://g

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/24

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 16: (9 comments) http://gerrit.cloudera.org:8080/#/c/5776/16/be/src/exprs/string-functions-ir.cc File be/src/exprs/str

[Impala-ASF-CR] IMPALA-3586: Implement Union Passthrough

2017-02-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#6). Change subject: IMPALA-3586: Implement Union Passthrough .. IMPALA-3586: Implement Union Passthrough The union node acts as pass through operator and forwards row batches from

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5916/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3909 (follow-up): Properly qualify min() and max() in header

2017-02-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header .. IMPALA-3909 (follow-up): Properly qualify min() and max() in header parquet-column-stats.h

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5917/1/fe/src/main/java/org/apache/impa

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5909/1/be/src/util/def

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (22 comments) Took a look, had some comments. http://gerrit.cloudera.org:8080/#/c/5792/7/be/s

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#16). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLAC

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/exprs/string-functions-ir.cc File be/src/exprs/s

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 15: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/exprs/string-functions-ir.cc File b

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to latest Kudu master .. Patch Set 1: Ran a private test run. -- To view, visit http://gerrit.cloudera.org:8080/5929 To unsubscribe, visit h

[Impala-ASF-CR] Bump Kudu version to latest Kudu master

2017-02-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5929 Change subject: Bump Kudu version to latest Kudu master .. Bump Kudu version to latest Kudu master Change-Id: Ib72a0b63cdffb852bd17e69f

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 18: Alex, can you take a look at this? In particular, patchset 18 vs 17. -- To view, visit ht

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5909/1/www/memz.tmpl File

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 7: Code-Review+1 Carrying +1. -- To view, visit http://gerrit.cloudera.org:8080/5877

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread David Knupp (Code Review)
Hello Michael Brown, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5877 to look at the new patch set (#7). Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5877/6//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5840/2/be/src/exec/kud

[Impala-ASF-CR] IMPALA-4839: Remove implicit 'localhost' for KUDU MASTER HOSTS

2017-02-07 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS .. Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5877/6//COMMIT_MSG

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/243/ -- To

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 18: The full test run caught a gap in my pre-review testing - the input argument types for

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5161 to look at the new patch set (#18). Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs ...

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 8: Code-Review+2 Rebased, carrying +2. Thanks for the reviews. -- To view, visit htt