[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 9: Code-Review+2 carry +2, rebased -- To view, visit

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/567/

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 7533364 .. Bump Kudu version to 7533364 Change-Id: I88dc2d425bd3aff70c95d51818d0450709123d27 Reviewed-on:

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6797 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6797 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-5238: transfer reservations between trackers .. IMPALA-5238: transfer reservations between trackers This is a primitive needed to implement claiming and

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5220: memory maintenance cleanup .. IMPALA-5220: memory maintenance cleanup Remove logic that tries to release pages from TcMalloc's

[Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-5169: Add support for async pins in buffer pool .. IMPALA-5169: Add support for async pins in buffer pool Makes Pin() do async reads behind-the-scenes,

[Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5169: Add support for async pins in buffer pool .. Patch Set 10: (14 comments)

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6707/3/www/query_plan.tmpl File

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 8: Code-Review+2 (1 comment) Merged in related refactoring patch which also had a

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-05-10 Thread Matthew Jacobs (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6526 to look at the new patch set (#8). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#5). Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention Holding

[Impala-ASF-CR] IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6849 Change subject: IMPALA-5137: Support TIMESTAMPs in Kudu range predicate DDL .. IMPALA-5137: Support TIMESTAMPs in Kudu range predicate

[Impala-ASF-CR] IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu .. IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu This change builds on the support for

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#4). Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention Holding

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-10 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 23: (10 comments) Thanks for the review, please see PS24.

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/6707/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Abandoned merging with https://gerrit.cloudera.org/#/c/6526/ -- To view, visit

[Impala-ASF-CR] IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock contention

2017-05-10 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention .. IMPALA-1972/IMPALA-3882: Fix QueryExecState::lock_ contention Holding

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-10 Thread Lars Volker (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#24). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166:

[Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5169: Add support for async pins in buffer pool .. Patch Set 10: (14 comments) This public abstraction looks good now. Mostly some renaming suggestions to

[Impala-ASF-CR] Bump Kudu version to 7533364

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 7533364 .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/566/ -- To view, visit

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-10 Thread Lars Volker (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6495 to look at the new patch set (#23). Change subject: IMPALA-4166: Add SORT BY sql clause .. IMPALA-4166:

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6842 To

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM On

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4499: Table name missing from exec summary .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6832 To unsubscribe,

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4499: Table name missing from exec summary .. IMPALA-4499: Table name missing from exec summary For scan nodes, previously only HDFS

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. IMPALA-5294: Kudu INSERT partitioning fails with constants An INSERT into a Kudu

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6828 To

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. IMPALA-5085: large rows in BufferedTupleStreamV2 The stream defaults to pages of default_page_len_. If a row

[Impala-ASF-CR] IMPALA-5085: large rows in BufferedTupleStreamV2

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2 .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/6638/3//COMMIT_MSG Commit Message: PS3, Line

[Impala-ASF-CR] IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.

2017-05-10 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6527/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-5238: transfer reservations between trackers .. IMPALA-5238: transfer reservations between trackers This is a primitive needed to implement claiming and

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 4: Code-Review+1 (2 comments) > How about a rebase? Done

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6792 to look at the new patch set (#4). Change subject: IMPALA-5167: Reduce the number of Kudu clients created ..

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exprs/scalar-expr.h File

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 6: (6 comments) quick comments

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/565/ -- To view, visit

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 11: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#6). Change subject: IMPALA-4623: Enable file handle cache .. IMPALA-4623: Enable file handle cache Currently, every scan range maintains a file handle, even when multiple scan ranges

[Impala-ASF-CR] IMPALA-4623: Enable file handle cache

2017-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4623: Enable file handle cache .. Patch Set 4: (4 comments) Fixed the test comments and fixed some errors in the code found by other existing tests

[Impala-ASF-CR] IMPALA-5036: Parquet count star optimization

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5036: Parquet count star optimization .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 22: (13 comments) http://gerrit.cloudera.org:8080/#/c/6495/22/common/thrift/JniCatalog.thrift File

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4499: Table name missing from exec summary .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/564/ -- To

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/563/

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 3: fwiw the jenkins nodes (both public and private) appear to have vm_overcommit 0

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 3: How about a rebase? -- To view, visit http://gerrit.cloudera.org:8080/6792 To

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 3: Code-Review+2 > I measured the max rss w/ this change to be 88mb, down from 14gb is

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6842 to look at the new patch set (#3). Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM ..

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 2: I measured the max rss w/ this change to be 88mb, down from 14gb is what I

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6842 To

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 2: Looks good. I will let Dan +2 it. -- To view, visit

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM On jenkins.impala.io

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5297: Set Kudu minicluster memory limit

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Set Kudu minicluster memory limit .. Patch Set 1: posted to test gerrit-verify-dryrun -- To view, visit http://gerrit.cloudera.org:8080/6844 To

[Impala-ASF-CR] IMPALA-5297: Set Kudu minicluster memory limit

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6844 Change subject: IMPALA-5297: Set Kudu minicluster memory limit .. IMPALA-5297: Set Kudu minicluster memory limit By default, Kudu

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 10: Code-Review+2 (1 comment) We should test this on a range of Linux distributions

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-05-10 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 10: Thanks for the review, Tim - do you have any further comments? -- To view, visit

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5238: transfer reservations between trackers .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6708/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-5238: transfer reservations between trackers .. IMPALA-5238: transfer reservations between trackers This is a primitive needed to implement claiming and

[Impala-ASF-CR] IMPALA-5238: transfer reservations between trackers

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5238: transfer reservations between trackers .. IMPALA-5238: transfer reservations between trackers This is a primitive needed to implement claiming and

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. Patch Set 1: Looking at git history, the large allocations were added here, so let's be sure

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created .. Patch Set 3: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5483/7/be/src/exec/exec-node.h File

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-10 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#12). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM

2017-05-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6842 Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM .. IMPALA-5297: Reduce free-pool-test mem requirement

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-10 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#11). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 10: (57 comments) http://gerrit.cloudera.org:8080/#/c/5483/9/be/src/exec/aggregation-node.cc File

[Impala-ASF-CR] IMPALA-5152: Gather all tables with missing metadata in analysis

2017-05-10 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-5152: Gather all tables with missing metadata in analysis .. Abandoned This is temporarily on hold to focus on a cleaner but more invasive solution. Abandoning so

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-05-10 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#10). Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. IMPALA-4192:

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2373: Extrapolate row counts for HDFS tables.

2017-05-10 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6840 Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. .. IMPALA-2373: Extrapolate row counts for HDFS tables. The main idea

[Impala-ASF-CR] IMPALA-5169: Add support for async pins in buffer pool

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-5169: Add support for async pins in buffer pool .. IMPALA-5169: Add support for async pins in buffer pool Makes Pin() do async reads behind-the-scenes,

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 10: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/6626 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5220: memory maintenance cleanup .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/560/ -- To view, visit

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-10 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4499: Table name missing from exec summary .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6832 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6828 to look at the new patch set (#3). Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants

[Impala-ASF-CR] IMPALA-5294: Kudu INSERT partitioning fails with constants

2017-05-10 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6832 to look at the new patch set (#2). Change subject: IMPALA-4499: Table name missing from exec summary ..

[Impala-ASF-CR] IMPALA-4499: Table name missing from exec summary

2017-05-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4499: Table name missing from exec summary .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-05-10 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/6510/11/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-05-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6406