[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7307 To

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. IMPALA-5489: Improve Sentry authorization for Kudu tables IMPALA-4000 added basic

[Impala-ASF-CR] IMPALA-3496: stress test: print version info

2017-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3496: stress test: print version info .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/931/ -- To

[Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7493/1/bin/clean.sh File

[Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc .. IMPALA-5716: Don't delete cmake_modules/* when enabling distcc If $IMPALA_HOME ends with a /,

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7307 to look at the new patch set (#5). Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. Patch Set 5: Code-Review+2 Needed to update AuditingTest - minor changes -- To view, visit

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1882: Remove ORDER BY restriction from first value()/last value()

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value() .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7502/1//COMMIT_MSG

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7507/2//COMMIT_MSG Commit

[Impala-ASF-CR] CDH-56988: Update the sentry dependencies to reflect the new version of sentry

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: CDH-56988: Update the sentry dependencies to reflect the new version of sentry .. Patch Set 1: (1 comment)

[Impala-ASF-CR] CDH-56990: Fix impala code as sentry-policy-db package is removed in sentry 2.0.0-cdh6.x-SNAPSHOT

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: CDH-56990: Fix impala code as sentry-policy-db package is removed in sentry 2.0.0-cdh6.x-SNAPSHOT .. Patch Set 1: (1 comment)

[Impala-ASF-CR] CDH-56991: Implement new API's in AuthorizationPolicy

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: CDH-56991: Implement new API's in AuthorizationPolicy .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7510/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: (1 comment) there were also some other comments that still need to be

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. IMPALA-4674: Part 3: fix null-aware anti join Part 2 regressed NAAJ by tightening up the spilling invariants

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. Patch Set 4: Rebased -- To view, visit http://gerrit.cloudera.org:8080/7367 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 9: Code-Review+2 rebased -- To view, visit http://gerrit.cloudera.org:8080/7022 To unsubscribe,

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 37: Code-Review+2 Rebase. Thomas, I rebased onto the partial sorter change - might be good to

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. IMPALA-4674: Part 3: fix null-aware anti join Part 2 regressed NAAJ by tightening up the spilling invariants

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#37). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. Patch Set 11: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7102 To unsubscribe,

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-07-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7102 to look at the new patch set (#11). Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. IMPALA-4674:

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#36). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-07-25 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7022 to look at the new patch set (#8). Change subject: IMPALA-4703: reservation denial debug action .. IMPALA-4703:

[Impala-ASF-CR] IMPALA-3496: stress test: print version info

2017-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3496: stress test: print version info .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/931/ -- To view, visit

[Impala-ASF-CR] CDH-56991: Implement new API's in AuthorizationPolicy

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7510 Change subject: CDH-56991: Implement new API's in AuthorizationPolicy .. CDH-56991: Implement new API's in AuthorizationPolicy

[Impala-ASF-CR] CDH-56988: Update the sentry dependencies to reflect the new version of sentry

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7508 Change subject: CDH-56988: Update the sentry dependencies to reflect the new version of sentry .. CDH-56988: Update the sentry

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7507 Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala .. CDH-56987: Update sentry version to

[Impala-ASF-CR] IMPALA-3496: stress test: print version info

2017-07-25 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-3496: stress test: print version info .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7501 To unsubscribe, visit

[Impala-ASF-CR] Populate OffsetIndex and ColumnIndex of a row group and Filter pages

2017-07-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: Populate OffsetIndex and ColumnIndex of a row_group and Filter pages .. Patch Set 2: (4 comments) Thank you for addressing all the comments. :)

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7307 To unsubscribe,

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-07-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/930/ -- To

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: OK. Thanks for the clarification. This kind of implicit rule is always

[Impala-ASF-CR] IMPALA-1882: Remove ORDER BY restriction from first value()/last value()

2017-07-25 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7502 Change subject: IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value() .. IMPALA-1882: Remove ORDER BY restriction

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 3: Updated commit message with Perf. I did run benchmarks on a 16 node and it looked good. -- To

[Impala-ASF-CR] IMPALA-3496: stress test: print version info

2017-07-25 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/7501 Change subject: IMPALA-3496: stress test: print version info .. IMPALA-3496: stress test: print version info Print the version info of

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: It would be great if someone could write the best-practice

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. IMPALA-5417: make I/O buffer queue fixed-size This removes the dynamically-varying queue size behaviour in the

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Matt's understanding matches mine - releasing resources in

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: > Isn't the general direction we are moving towards to not rely on

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 3: Did you run some perf tests to make sure that there is no regression ? -- To view, visit

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Isn't the general direction we are moving towards to not rely on

[Impala-ASF-CR] IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close()

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5715: (potential mitigation) don't destroy MemTracker during Close() .. Patch Set 1: Code-Review+1 Seems like the right thing to do (i.e. control state

[Impala-ASF-CR] IMPALA-5716: Don't delete cmake modules/* when enabling distcc

2017-07-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5716: Don't delete cmake_modules/* when enabling distcc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7493/1/bin/clean.sh File

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

2017-07-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). Change subject: IMPALA-5714: Add linker's version script for OpenSSL library .. IMPALA-5714: Add linker's version script for OpenSSL library Debian based distribution (e.g. Ubuntu)

[native-toolchain-CR] Add linker's version script for OpenSSL library.

2017-07-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add linker's version script for OpenSSL library. .. Patch Set 4: Thanks, the JIRA helped me understand why we're bothering with this. Please update the commit

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 9: (9 comments) http://gerrit.cloudera.org:8080/#/c/7363/9/be/src/statestore/statestore.cc

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded a new patch set (#11). Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web page Read the start date and time of the impalad,