[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 8: Code-Review+1 (1 comment) Conditional on the

[Impala-ASF-CR] IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork

2017-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to avoid expensive fork .. Patch Set 8: (1 comment)

[Impala-ASF-CR] Allow the SASL protocol service name to be configurable

2017-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8230 ) Change subject: Allow the SASL protocol service name to be configurable .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. IMPALA-6049: breakpad tests: skip

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8274 to look at the new patch set (#2). Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

[Impala-ASF-CR] IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet

2017-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8085 ) Change subject: IMPALA-5307: part 1: don't transfer disk I/O buffers out of parquet .. Patch Set 8: Code-Review+1 rebase, carry +1

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 8: (4 comments) I took a look at it and

[Impala-ASF-CR] IMPALA-4704: Disallow client connections until lcoal catalog initialized.

2017-10-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8275 Change subject: IMPALA-4704: Disallow client connections until lcoal catalog initialized. .. IMPALA-4704: Disallow client connections

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 7: (13 comments)

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8274 ) Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. Patch Set 1: Code-Review+1 (3 comments) This looks fine to

[Impala-ASF-CR] IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+

2017-10-13 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8274 Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ .. IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+ Hadoop

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-13 Thread Pranay Singh (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8034 to look at the new patch set (#9). Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-10-13 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 7: (15 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8170 ) Change subject: IMPALA-5789: Add always_false flag in bloom filter .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#6). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-5789: Add always false flag in bloom filter

2017-10-13 Thread Tianyi Wang (Code Review)
Hello Thomas Tauber-Marshall, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8170 to look at the new patch set (#5). Change subject: IMPALA-5789: Add always_false flag in bloom filter

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6535 ) Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: Csaba, are those failing tests

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Code-Review+2 Thanks for fixing this.

[Impala-ASF-CR] IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04

2017-10-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8262 ) Change subject: IMPALA-6045: Make build scripts more friendly to Ubuntu 16.04 .. Patch Set 3: (2 comments) Sorry to get to this a

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8272 ) Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. Patch Set 1: If you would like me to perform a

[Impala-ASF-CR] IMPALA-6049: breakpad tests: skip all tests with local filesystem

2017-10-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8272 Change subject: IMPALA-6049: breakpad tests: skip all tests with local filesystem .. IMPALA-6049: breakpad tests: skip all tests with

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-13 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#7). Change subject: IMPALA-5736: Add impala-shell argument to set default query options