Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5230
Change subject: Avoid std::function when possible.
..
Avoid std::function when possible.
std::function does some tricky stuff under the hood
Jim Apple has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 5:
(31 comments)
http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG
Commit Message:
PS4,
Jim Apple has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5154/2/bin/bootstrap_build.sh
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5232
Change subject: Add Apache license header to files in doc directory
..
Add Apache license header to files in doc directory
This now gives a
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt
File b
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5238
Change subject: Start a docs build system.
..
Start a docs build system.
The docs can be built by running "make" from the docs directory. Th
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5239
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloduera-specific
..
IMPALA-3398: Rework Impala documentation to be non-C
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
See Effective Modern C++, slide 39 of
https://onedrive.live.com/view.aspx?resid=E66E02DC83EFB165!330&ithint=file%
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5242
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
..
IMPALA-4543: Properly escape ignored tests subdirectories.
In
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.
This is a simpler alternati
Jim Apple has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5154/2/bin/bootstrap_build.sh
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5154
to look at the new patch set (#4).
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
...
Jim Apple has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 4: Code-Review+2
(1 comment)
Carry Tim's +2
http://gerrit.cloudera.org:8080/#/c/5
Jim Apple has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2:
> Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/43/
SOmething went haywir
Jim Apple has posted comments on this change.
Change subject: IMPALA-4519: increase timeout in TestFragmentLifecycle
..
Patch Set 2:
> > Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/43/
>
> SOmething wen
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt
File b
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> Am I right to summarise that your main objection is that
> std::function() heap allocates?
It's the added hidd
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> > It's the added hidden run-time complexity generally
>
> Can you be more specific? Abstractions naturally hi
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> > I don't think we should never use it, but I think it is overkill
> for this use case
>
> The alternative i
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 1:
> > I do not find it more readable, but I find it to be readable
> enough; I think the readability delta is a goo
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 2:
> (1 comment)
Yeah, it's counterintuitive.
Given that new information, if I ca
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 2:
> Are any of these overflows legitimate use of signed overflows?
> Assuming no
Jim Apple has uploaded a new patch set (#2).
Change subject: Start a docs build system.
..
Start a docs build system.
The docs can be built by running "make" from the docs directory. This
does not hook into buildall.sh for now,
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5258
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
..
IMPALA-4553: ntpd must be synchronized for kudu to start.
When
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloduera-specific
..
IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific
This fix is a prototype f
Jim Apple has posted comments on this change.
Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu
14.04.
..
Patch Set 5: Code-Review+2
rebase carry
--
To view, visit http://gerrit.cloudera.org:8080/5
Hello Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5258
to look at the new patch set (#2).
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
..
IMPA
Jim Apple has posted comments on this change.
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
..
Patch Set 2: Code-Review+1
Carry Todd's +1
--
To view, visit http://gerrit.cloudera.org:8080/5258
To u
Jim Apple has posted comments on this change.
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5258/1/testdata/cluster/admin
File testdat
Jim Apple has posted comments on this change.
Change subject: IMPALA-4397 addendum: remove stray semicolon
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5261
To unsubscribe, visit http://gerri
Hello Todd Lipcon, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5258
to look at the new patch set (#3).
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
.
Jim Apple has posted comments on this change.
Change subject: Start a docs build system.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile
File docs/Makefile:
> High-level question: would it
Jim Apple has posted comments on this change.
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5258/2/testdata/cluster/admin
File testdat
Jim Apple has posted comments on this change.
Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.
..
Patch Set 3: Code-Review+2
carry Tim's
--
To view, visit http://gerrit.cloudera.org:8080/5258
To unsub
Jim Apple has posted comments on this change.
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloduera-specific
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5239/2//COMMIT_MSG
Commit Mess
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
This fix is a prototype f
Jim Apple has posted comments on this change.
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
Patch Set 2:
(13 comments)
> (12 comments)
>
> Because I'm advocating re-doing the autom
Jim Apple has posted comments on this change.
Change subject: IMPALA-4397 addendum: remove stray semicolon
..
Patch Set 1:
Failed because https://issues.cloudera.org/browse/IMPALA-4557
--
To view, visit http://gerrit.cloudera
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
..
IMPALA-4543: Properly escape ignored tests subdirectories.
In the shell, double-quoted strings are not ve
Jim Apple has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
..
Patch Set 1:
(2 comments)
> (2 comments)
>
> Just wondering why we started hitting that ? Why isn't
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5242
to look at the new patch set (#3).
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
..
IMPA
Jim Apple has posted comments on this change.
Change subject: IMPALA-4543: Properly escape ignored tests subdirectories.
..
Patch Set 3: Code-Review+2
(1 comment)
carry +2
http://gerrit.cloudera.org:8080/#/c/5242/2/tests/run-
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5278
Change subject: Fix undefined cals to __builtin_ctz.
..
Fix undefined cals to __builtin_ctz.
GCC's __builtin_ctz[l[l]] functions return unde
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5004
to look at the new patch set (#3).
Change subject: Fix undefined cals to __builtin_ctz.
..
Fix undefined cals to _
Jim Apple has restored this change.
Change subject: IMPALA-4433: Fix undefined NDV calculations
..
Restored
No longer needed for stats, but might as well eliminate undefined behavior
--
To view, visit http://gerrit.cloudera.o
Jim Apple has abandoned this change.
Change subject: Fix undefined cals to __builtin_ctz.
..
Abandoned
https://gerrit.cloudera.org/#/c/5004/
--
To view, visit http://gerrit.cloudera.org:8080/5278
To unsubscribe, visit http://
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5004
to look at the new patch set (#4).
Change subject: Fix undefined calls to __builtin_ctz.
..
Fix undefined calls to
Jim Apple has posted comments on this change.
Change subject: Fix undefined calls to __builtin_ctz.
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5004/3/be/src/udf_samples/hyperloglog-uda.cc
File be/src/udf_
Jim Apple has posted comments on this change.
Change subject: Start a docs build system.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile
File docs/Makefile:
> I guess my feeling is that ma
Jim Apple has posted comments on this change.
Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h
File
Jim Apple has posted comments on this change.
Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h
File
Jim Apple has posted comments on this change.
Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h
File
Jim Apple has posted comments on this change.
Change subject: Fix undefined calls to __builtin_ctz.
..
Patch Set 5: Code-Review+1
rebase carry tim's +1
--
To view, visit http://gerrit.cloudera.org:8080/5004
To unsubscribe, vi
Jim Apple has posted comments on this change.
Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5281
To unsubscribe, vi
Jim Apple has posted comments on this change.
Change subject: Fix E2E test infrastructure to handle missing exceptions
correctly
..
Patch Set 2:
I've seen this breaking Impala Public Jenkins test runs. Is this ready for
merge
Jim Apple has posted comments on this change.
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
Patch Set 3:
Any additional concerns, here?
--
To view, visit http://gerrit.cloudera.org:8
Jim Apple has posted comments on this change.
Change subject: Add Apache license header to files in doc directory
..
Patch Set 1:
Once this is merged, we can add RAT checks to our pre-merge testing.
--
To view, visit http://g
Jim Apple has posted comments on this change.
Change subject: Start a docs build system.
..
Patch Set 2:
Any additional concerns, here?
--
To view, visit http://gerrit.cloudera.org:8080/5238
To unsubscribe, visit http://gerri
Jim Apple has posted comments on this change.
Change subject: Start a docs build system.
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5238
To unsubscribe, visit http://gerrit.cloudera.org:8080/s
Jim Apple has submitted this change and it was merged.
Change subject: Start a docs build system.
..
Start a docs build system.
The docs can be built by running "make" from the docs directory. This
does not hook into buildall.s
Jim Apple has posted comments on this change.
Change subject: Add Apache license header to files in doc directory
..
Patch Set 2: Code-Review+1
rebase, carry Greg' +1
--
To view, visit http://gerrit.cloudera.org:8080/5232
To
Jim Apple has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 8:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG
Commit Message:
PS4,
Jim Apple has posted comments on this change.
Change subject: Add Apache license header to files in doc directory
..
Patch Set 2:
> Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/4/
This job is just checki
Jim Apple has posted comments on this change.
Change subject: Add Apache license header to files in doc directory
..
Patch Set 2:
(1 comment)
> (1 comment)
>
> Looks good. (Does the +2 initiate any further transfer of files
Jim Apple has posted comments on this change.
Change subject: Avoid std::function when possible.
..
Patch Set 2: Code-Review+2
rebase carry marcel's +2
--
To view, visit http://gerrit.cloudera.org:8080/5230
To unsubscribe, vi
Jim Apple has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 11:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG
Commit Message:
Line
Jim Apple has uploaded a new patch set (#4).
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
This fix is a prototype f
Jim Apple has posted comments on this change.
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5239/3/docs/impala_html.ditava
Jim Apple has uploaded a new patch set (#5).
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific
Removes some of the Cloud
Jim Apple has posted comments on this change.
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
Patch Set 5:
I have substantially reduced the documentation changes after our out-of-band
d
Jim Apple has posted comments on this change.
Change subject: Add Apache license header to files in doc directory
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5232/2//COMMIT_MSG
Commit Message:
PS2, Line 7:
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5401
Change subject: IMPALA-2605: Omit the stress tests
..
IMPALA-2605: Omit the stress tests
Stress tests were sometimes causing the end-to-end
Jim Apple has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
> I think the DDL stress test is still useful, since we don't have
> duplicate coverage else. Maybe
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
IMPALA-2605: Omit the sort and mini stress tests
These stress tests were sometimes causing the end-to-end tests to
Jim Apple has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
Alex, I think you clicked the wrong button. -1 on Code-Review is for humans, -1
on Verified is for
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5412
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
IMPALA-4588: Enable starting the minicluster when offline
IMPAL
Jim Apple has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
> I'm ok with removing these tests if someone can explain to me what
> exactly is happening so we c
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
IMPALA-4588: Enable starting the minicluster when offline
IMPALA-4553 made ntp-wait succeed before kudu wo
Jim Apple has posted comments on this change.
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5412/1/testdata/cluster/admin
File testdat
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5412
to look at the new patch set (#3).
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
IM
Jim Apple has posted comments on this change.
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5412/2/testdata/cluster/admin
File testdat
Jim Apple has posted comments on this change.
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
Patch Set 3: Code-Review+1
Carry Tim's +1
--
To view, visit http://gerrit.cloudera.org:8080/5412
To un
Jim Apple has posted comments on this change.
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
Patch Set 4: Code-Review+2
rebase carry Alex's +2
--
To view, visit http://gerrit.cloudera.org:8080/54
Jim Apple has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
> One option we should consider is replacing this test with a small
> run of our "regular" stress t
Jim Apple has posted comments on this change.
Change subject: Add all build targets to CMake and speed up builds
..
Patch Set 5:
> I'm holding off on merging this until builds stabilise a little
> more, since it's not a high p
Jim Apple has posted comments on this change.
Change subject: IMPALA-4588: Enable starting the minicluster when offline
..
Patch Set 5: Code-Review+2
rebase carry Alex's +2
--
To view, visit http://gerrit.cloudera.org:8080/54
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5433
Change subject: Change git links from GitHub to the official Apache repo.
..
Change git links from GitHub to the official Apache repo.
In th
Jim Apple has posted comments on this change.
Change subject: Change git links from GitHub to the official Apache repo.
..
Patch Set 1:
> My main gripe with the apache git web UI is that it's really hard
> to find a URL to clo
Jim Apple has posted comments on this change.
Change subject: IMPALA-4014: Introduce query-wide execution state.
..
Patch Set 11:
> Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/100/
It's a little trick
Jim Apple has posted comments on this change.
Change subject: Add a build flag for the undefined behavior sanitizer, aka
"ubsan".
..
Patch Set 2:
> If they're relying on twos-complement we could just cast to
> unsigned for th
Jim Apple has posted comments on this change.
Change subject: Change git links from GitHub to the official Apache repo.
..
Patch Set 1:
> I think that sounds good, it seems we should be making it as easy
> as possible for peop
Jim Apple has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 13: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4715/13/be/src/runtime/buff
Jim Apple has posted comments on this change.
Change subject: IMPALA-3398: Rework Impala documentation to be
non-Cloudera-specific
..
Patch Set 6: Code-Review+2
Carry John's +2 after rebase
--
To view, visit http://gerrit.cl
Jim Apple has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 13:
Manually verified: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/113/
--
To vie
Jim Apple has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
> I'm much more in favor of deleting code we don't need instead of
> leaving it and disabling it wi
Jim Apple has posted comments on this change.
Change subject: IMPALA-2605: Omit the sort and mini stress tests
..
Patch Set 2:
> Maybe we should dump out the value of some of these metrics before
> running the tests in tests/r
Jim Apple has posted comments on this change.
Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver
specified by hostname or "127.0.0.1"
..
Patch Set 1:
> Why do this patch cannot be merged?
Gerrit adds the b
Jim Apple has posted comments on this change.
Change subject: Add all build targets to CMake and speed up builds
..
Patch Set 7:
> Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/120/
Sorry, that was me :
Jim Apple has posted comments on this change.
Change subject: IMPALA-4631: don't use floating point operations for time unit
conversions
..
Patch Set 6: Verified+1
http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/121/
-
Jim Apple has posted comments on this change.
Change subject: IMPALA-3200: Implement suballocator for splitting buffers
..
Patch Set 14:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4715/14/be/src/runtime/bufferpool/suballo
601 - 700 of 1031 matches
Mail list logo
