[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMPALA-3748: add query-wide resource acquisition step This adds a Prepare() method to QueryStat

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5739 To unsubscr

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc Fi

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5739 To unsubscribe,

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc Fil

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/6/be/src/runtime/query-state.cc Fil

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/204/ -- To

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5739 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5739 to look at the new patch set (#5). Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMP

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 5: Removed the unnecessary call to Prepare() as discussed. -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 4: Talked offline with Marcel - he pointed out that we shouldn't need to call Prepare() from

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: Addressed the straightforward comments - we can discuss further in person. From my POV thi

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/5739/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5739 to look at the new patch set (#4). Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMP

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/coordinator.cc Fi

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: Code-Review-1 let's discuss in person before going ahead with it as-is. -- To view, vi

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5739/3//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3748: add query-wide resource acquisition step .. Patch Set 3: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/5739/3/be/src/runtime/qu

[Impala-ASF-CR] IMPALA-3748: add query-wide resource acquisition step

2017-01-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3748: add query-wide resource acquisition step .. IMPALA-3748: add query-wide resource acquisition step This adds a PrepareForExecution() method to QuerySta