Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 7:
Thanks for the contribution!
--
To view, visit
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 6: Verified+1
--
To view, visit
Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
IMPALA-6084: Avoid using of global namespace
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 6:
Build started:
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 6: Code-Review+2
--
To view, visit
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 5:
(2 comments)
I had one nit but just fixed it
Tim Armstrong has uploaded a new patch set (#6) to the change originally
created by Kim Jin Chul. ( http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
IMPALA-6084:
Kim Jin Chul has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 4:
(12 comments)
Hello Philip Zeyliger, Tim Armstrong, Bikramjeet Vig,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8489
to look at the new patch set (#5).
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 4: Code-Review+1
(12 comments)
Looks good to me,
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 4:
> I'm ok with using llvm:: in those files, but
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 4:
I'm ok with using llvm:: in those files, but was
Kim Jin Chul has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 4:
(2 comments)
@Tim and Bikram, both of you wants
Hello Philip Zeyliger, Tim Armstrong, Bikramjeet Vig,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8489
to look at the new patch set (#4).
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 3:
@Bikram I think that would be convenient, except
Philip Zeyliger has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 3:
(1 comment)
Bikramjeet Vig has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 3:
does it make sense to import llvm namespace
Tim Armstrong has posted comments on this change. (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
Patch Set 3:
(1 comment)
I started looking through the first
Kim Jin Chul has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/8489 )
Change subject: IMPALA-6084: Avoid using of global namespace for llvm
..
IMPALA-6084: Avoid using of global namespace for llvm
There are
19 matches
Mail list logo