[kudu-CR] random: change Rand64() to use all bits

2016-12-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: random: change Rand64() to use all bits .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5474/3/src/kudu/util/random.h File

[kudu-CR] WIP: KUDU-1775 (part 3): enforce max cell size and max PK size

2016-12-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5475 to look at the new patch set (#2). Change subject: WIP: KUDU-1775 (part 3): enforce max cell size and max PK size

[kudu-CR] random: change Rand64() to use all bits

2016-12-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5474 to look at the new patch set (#4). Change subject: random: change Rand64() to use all bits .. random:

[kudu-CR] Persistent cache support for NVM

2016-12-12 Thread Sarah Jelinek (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2593 to look at the new patch set (#19). Change subject: Persistent cache support for NVM .. Persistent cache support

[kudu-CR] KUDU-1801: catalog manager: change TableInfo lock to a rwlock

2016-12-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5471 to look at the new patch set (#2). Change subject: KUDU-1801: catalog_manager: change TableInfo lock to a rwlock

[kudu-CR] WIP: rpc: Initiate TLS connection upgrade following SASL negotiation

2016-12-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: rpc: Initiate TLS connection upgrade following SASL negotiation .. Patch Set 1: (2 comments) Just a couple of nits, but so far it looks great. Will take

[kudu-CR] Fix build on macOS

2016-12-12 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Fix build on macOS .. Fix build on macOS Change-Id: Idaf9867c064258cf16c5897dfa4e5b99640948a8 Reviewed-on: http://gerrit.cloudera.org:8080/5482

[kudu-CR] Fix build on macOS

2016-12-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix build on macOS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5482 To unsubscribe, visit

[kudu-CR] Fix build on macOS

2016-12-12 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5482 to review the following change. Change subject: Fix build on macOS .. Fix build on macOS Change-Id:

[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters

2016-12-12 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5461 to look at the new patch set (#2). Change subject: [spark] KUDU-1631 push down StringStartsWith filters .. [spark]

[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters

2016-12-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [spark] KUDU-1631 push down StringStartsWith filters .. Patch Set 1: (2 comments)

[kudu-CR] env: do not convert all Flush() calls into fsync() on macOS

2016-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: env: do not convert all Flush() calls into fsync() on macOS .. env: do not convert all Flush() calls into fsync() on macOS On Linux, we don't expect

[kudu-CR] env: do not convert all Flush() calls into fsync() on macOS

2016-12-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: env: do not convert all Flush() calls into fsync() on macOS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5457/1/src/kudu/util/env_posix.cc

[kudu-CR] env: do not convert all Flush() calls into fsync() on macOS

2016-12-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: env: do not convert all Flush() calls into fsync() on macOS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5457 To

[kudu-CR] tests: set never fsync for every test

2016-12-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tests: set never_fsync for every test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5459 To unsubscribe, visit

[kudu-CR] tests: set never fsync for every test

2016-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tests: set never_fsync for every test .. tests: set never_fsync for every test None of our tests rely on unplugging machines, forcefully unmounting a

[kudu-CR] tests: set never fsync for every test

2016-12-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tests: set never_fsync for every test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5459/1/src/kudu/util/atomic-test.cc File

[kudu-CR] env: do not convert all Flush() calls into fsync() on macOS

2016-12-12 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5457 to look at the new patch set (#2). Change subject: env: do not convert all Flush() calls into fsync() on macOS ..

[kudu-CR] KUDU-1805: Properly qualify classes in generated svc headers

2016-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1805: Properly qualify classes in generated svc headers .. KUDU-1805: Properly qualify classes in generated svc headers Change-Id:

[kudu-CR] KUDU-1805: Properly qualify classes in generated svc headers

2016-12-12 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/5478 Change subject: KUDU-1805: Properly qualify classes in generated svc headers .. KUDU-1805: Properly qualify classes in generated svc

[kudu-CR] random: add a Rand64() variant which uses all bits

2016-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: random: add a Rand64() variant which uses all bits .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5474/3/src/kudu/util/random.h

[kudu-CR] KUDU-1801: catalog manager: change TableInfo lock to a rwlock

2016-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1801: catalog_manager: change TableInfo lock to a rwlock .. Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5471/1//COMMIT_MSG

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2016-12-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering .. Patch Set 3: Code-Review+1 (4 comments) a couple of formatting nits, otherwise lgtm

[kudu-CR] Tightening ScanSpec primary bounds when range predicate exists

2016-12-12 Thread Haijie Hong (Code Review)
Haijie Hong has posted comments on this change. Change subject: Tightening ScanSpec primary bounds when range predicate exists .. Patch Set 4: (6 comments) > (7 comments)

[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters

2016-12-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [spark] KUDU-1631 push down StringStartsWith filters .. Patch Set 1: (2 comments)

[kudu-CR] Tightening ScanSpec primary bounds when range predicate exists

2016-12-12 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5360 to look at the new patch set (#4). Change subject: Tightening ScanSpec primary bounds when range predicate exists

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-12 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5425 To unsubscribe, visit

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-12 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. [spark] KUDU-1641 Pushdown SparkSQL In predicates This patch adds support for pushing down "IN

[kudu-CR] Tightening ScanSpec primary bounds when range predicate exists

2016-12-12 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5360 to look at the new patch set (#3). Change subject: Tightening ScanSpec primary bounds when range predicate exists

[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters

2016-12-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [spark] KUDU-1631 push down StringStartsWith filters .. Patch Set 1: > add a method for this in the client API itself Filed a feature request at

[kudu-CR] [spark] KUDU-1641 Pushdown SparkSQL In predicates

2016-12-12 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [spark] KUDU-1641 Pushdown SparkSQL In predicates .. Patch Set 3: See https://issues.apache.org/jira/browse/KUDU-1803 -- To view, visit

[kudu-CR] ts recovery-itest: increase timeout for bootstrap

2016-12-12 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: ts_recovery-itest: increase timeout for bootstrap .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5473 To unsubscribe, visit

[kudu-CR] random: add a Rand64() variant which uses all bits

2016-12-12 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5474 to look at the new patch set (#3). Change subject: random: add a Rand64() variant which uses all bits .. random: