[kudu-CR](gh-pages) Add blog post for 1.3.1

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6685 Change subject: Add blog post for 1.3.1 .. Add blog post for 1.3.1 Change-Id: If8a94c8b75d4ba39fdee151e775a65ed34f5ee79 --- A

[kudu-CR](gh-pages) Add 1.3.1 release and docs

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add 1.3.1 release and docs .. Add 1.3.1 release and docs Change-Id: I0bab6a65d78c72aba325de8113afb99a8ee5eca1 Reviewed-on:

[kudu-CR](gh-pages) Add 1.3.1 release and docs

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add 1.3.1 release and docs .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6684 To unsubscribe, visit

[kudu-CR](gh-pages) Add 1.3.1 release and docs

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6684 Change subject: Add 1.3.1 release and docs .. Add 1.3.1 release and docs Change-Id: I0bab6a65d78c72aba325de8113afb99a8ee5eca1 --- M

[kudu-CR] [rpc-test] fixed TestConnectionKeepalive flakiness

2017-04-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [rpc-test] fixed TestConnectionKeepalive flakiness .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/6683 To unsubscribe,

[kudu-CR] [rpc-test] fixed TestConnectionKeepalive flakiness

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6683 Change subject: [rpc-test] fixed TestConnectionKeepalive flakiness .. [rpc-test] fixed TestConnectionKeepalive flakiness After

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6585 to look at the new patch set (#7). Change subject: log block manager: use extent maps to decide whether to truncate containers

[kudu-CR] block manager: gflag to control repairs at startup

2017-04-18 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6682 to review the following change. Change subject: block manager: gflag to control repairs at startup

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/6630/3//COMMIT_MSG Commit Message: Line 19: immeditaly

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) .. gutil: stop supporting AMD Opteron K8 (take 2) This removes a workaround for a bug in very old (circa

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6680 To unsubscribe, visit

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc

[kudu-CR] log-test: Add additional assert

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: log-test: Add additional assert .. log-test: Add additional assert This just adds an additional check which is nice to have in this test. This was added

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc

[kudu-CR] log-test: Add additional assert

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log-test: Add additional assert .. Patch Set 2: Verified+1 Overriding existing test failure due to KUDU-1736 -- To view, visit

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc

[kudu-CR] docs: Add breakpad documentation to user guide

2017-04-18 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6504 to look at the new patch set (#2). Change subject: docs: Add breakpad documentation to user guide ..

[kudu-CR] docs: Shorten top-level headings in Troubleshooting Guide

2017-04-18 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6681 to review the following change. Change subject: docs: Shorten top-level headings in Troubleshooting Guide .. docs:

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Replace deprecated OpenSSL function ERR_remove_state() .. Replace deprecated OpenSSL function ERR_remove_state() ERR_remove_state() has been deprecated.

[kudu-CR] Fix thirdparty build error in Centos 6.

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix thirdparty build error in Centos 6. .. Fix thirdparty build error in Centos 6. When doing a fresh build in Centos 6, one might get errors like this:

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

2017-04-18 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6680 to review the following change. Change subject: gutil: stop supporting AMD Opteron K8 (take 2) .. gutil: stop

[kudu-CR] log-test: Add additional assert

2017-04-18 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6674 to look at the new patch set (#2). Change subject: log-test: Add additional assert .. log-test: Add additional

[kudu-CR] log-test: Add additional assert

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log-test: Add additional assert .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc File

[kudu-CR] Update link to KDE C++ ABI maintenance guidelines

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Update link to KDE C++ ABI maintenance guidelines .. Update link to KDE C++ ABI maintenance guidelines The old location advertises this new one.

[kudu-CR] Update link to KDE C++ ABI maintenance guidelines

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Update link to KDE C++ ABI maintenance guidelines .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6679 To unsubscribe, visit

[kudu-CR] Update link to KDE C++ ABI maintenance guidelines

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/6679 Change subject: Update link to KDE C++ ABI maintenance guidelines .. Update link to KDE C++ ABI maintenance guidelines The old location

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers .. Patch Set 6: > Yea, I think it's quite reasonable to only do so in a "fs check >

[kudu-CR](branch-1.3.x) [docs] Add admin workflow for recovering from disk failure

2017-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Add admin workflow for recovering from disk failure .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6677/1/docs/administration.adoc File

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1708. Document Kudu command-line tools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc File

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-18 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#4). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1708. Document Kudu command-line tools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc File

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

2017-04-18 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: KUDU-1708. Document Kudu command-line tools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc File

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

2017-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1708. Document Kudu command-line tools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc File

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1708. Document Kudu command-line tools .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc File

[kudu-CR](branch-1.3.x) [docs] Add admin workflow for recovering from disk failure

2017-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: [docs] Add admin workflow for recovering from disk failure .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR](branch-1.3.x) [docs] Add admin workflow for recovering from disk failure

2017-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/6677 Change subject: [docs] Add admin workflow for recovering from disk failure .. [docs] Add admin workflow for recovering from disk failure

[kudu-CR] log-test: Add additional assert

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: log-test: Add additional assert .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc File

[kudu-CR] Revert "gutil: stop supporting AMD Opteron K8"

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Revert "gutil: stop supporting AMD Opteron K8" .. Patch Set 1: Code-Review+2 I presume you'll try to figure out what went wrong and resubmit though, right? -- To

[kudu-CR] Revert "gutil: stop supporting AMD Opteron K8"

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Revert "gutil: stop supporting AMD Opteron K8" .. Revert "gutil: stop supporting AMD Opteron K8" This reverts commit

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6623/8/src/kudu/common/wire_protocol.h

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6623 to look at the new patch set (#9). Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to

[kudu-CR](branch-1.3.x) [docs] Add security guide

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Add security guide .. [docs] Add security guide Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5 Reviewed-on:

[kudu-CR](branch-1.3.x) [docs] Add security guide

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Add security guide .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6647 To unsubscribe, visit

[kudu-CR](branch-1.3.x) Add ksck section to admin guide common workflows

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add ksck section to admin guide common workflows .. Add ksck section to admin guide common workflows I've often wanted this when helping people

[kudu-CR](branch-1.3.x) Add ksck section to admin guide common workflows

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add ksck section to admin guide common workflows .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6646 To unsubscribe,

[kudu-CR](branch-1.3.x) docs: Fix axis lable for hash-range-partitioning

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: docs: Fix axis lable for hash-range-partitioning .. docs: Fix axis lable for hash-range-partitioning Horizontal axis label should show range

[kudu-CR](branch-1.3.x) docs: Fix axis lable for hash-range-partitioning

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: Fix axis lable for hash-range-partitioning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6644 To unsubscribe,

[kudu-CR](branch-1.3.x) docs: Fix "make site"

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: docs: Fix "make site" .. docs: Fix "make site" * "make site" was broken due to changed command-line argments on

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6660

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. KUDU-1933. consensus: Avoid and repair integer overflow in log index We

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6572/3//COMMIT_MSG

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap .. KUDU-1607. Unpin tablet flush after failed bootstrap We have heard reports that, in

[kudu-CR](branch-1.3.x) Bump version to 1.3.2-SNAPSHOT

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Bump version to 1.3.2-SNAPSHOT .. Bump version to 1.3.2-SNAPSHOT Change-Id: Ie4c48aa6ec08a40500d85a1a53ccb48b64d2d4ef Reviewed-on:

[kudu-CR] Revert "gutil: stop supporting AMD Opteron K8"

2017-04-18 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6676 to review the following change. Change subject: Revert "gutil: stop supporting AMD Opteron K8" .. Revert "gutil: stop

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [cmake] fixed 'latest' dir symlink on MacOS X .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6667 To unsubscribe, visit

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

2017-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 4: (5 comments)

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [cmake] fixed 'latest' dir symlink on MacOS X .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6667 To unsubscribe, visit

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6667 to look at the new patch set (#2). Change subject: [cmake] fixed 'latest' dir symlink on MacOS X ..

[kudu-CR] log-test: Add additional assert

2017-04-18 Thread Mike Percy (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6674 to review the following change. Change subject: log-test: Add additional assert .. log-test: Add additional

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [cmake] fixed 'latest' dir symlink on MacOS X .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6667/1//COMMIT_MSG Commit Message: PS1, Line 9:

[kudu-CR](branch-1.3.x) Bump version to 1.3.2-SNAPSHOT

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Bump version to 1.3.2-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6669 To unsubscribe, visit

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. Patch Set 3: Verified+1 delete_table-test failed due to a known flaky that exists on

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .. Abandoned The issue has been fixed in another changelist (in the new approach the socket is closed

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [cmake] fixed 'latest' dir symlink on MacOS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6667 To unsubscribe, visit

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [cmake] fixed 'latest' dir symlink on MacOS X .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6667/1//COMMIT_MSG Commit Message: PS1, Line 9: If

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] close socket on AcceptorPool::Shutdown() .. Patch Set 2: > Looks like Dinesh did the same thing back in > https://gerrit.cloudera.org/#/c/4958. > I

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

2017-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [rpc] close socket on AcceptorPool::Shutdown() .. Patch Set 2: Looks like Dinesh did the same thing back in https://gerrit.cloudera.org/#/c/4958. I wonder why

[kudu-CR] Fix thirdparty build error in Centos 6.

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix thirdparty build error in Centos 6. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6673 To unsubscribe, visit

[kudu-CR] Fix thirdparty build error in Centos 6.

2017-04-18 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new change for review. http://gerrit.cloudera.org:8080/6673 Change subject: Fix thirdparty build error in Centos 6. .. Fix thirdparty build error in Centos 6. When doing a fresh build in Centos 6,

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart .. Abandoned I removed the need to backport this patch. -- To view, visit

[kudu-CR] Slice::ToDebugString() - Add option to not ascii'ize

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Slice::ToDebugString() - Add option to not ascii'ize .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6671/1//COMMIT_MSG Commit Message: Line 7:

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

2017-04-18 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6572 to look at the new patch set (#3). Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] close socket on AcceptorPool::Shutdown() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6665 To unsubscribe, visit

[kudu-CR] Slice::ToDebugString() - Add option to not ascii'ize

2017-04-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6671 Change subject: Slice::ToDebugString() - Add option to not ascii'ize .. Slice::ToDebugString() - Add option to not ascii'ize This

[kudu-CR] gutil: stop supporting AMD Opteron K8

2017-04-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: gutil: stop supporting AMD Opteron K8 .. gutil: stop supporting AMD Opteron K8 This removes a workaround for a bug in very old (circa 2003) Opteron

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. Patch Set 2: (1 comment)

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6623/7/src/kudu/common/wire_protocol.h

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6623 to look at the new patch set (#8). Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6623/7/src/kudu/common/wire_protocol.h File

[kudu-CR](branch-1.3.x) Bump version to 1.3.2-SNAPSHOT

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6669 to review the following change. Change subject: Bump version to 1.3.2-SNAPSHOT .. Bump version to 1.3.2-SNAPSHOT

[kudu-CR] Bump version to 1.3.2-SNAPSHOT

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has abandoned this change. Change subject: Bump version to 1.3.2-SNAPSHOT .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[kudu-CR] Bump version to 1.3.2-SNAPSHOT

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Bump version to 1.3.2-SNAPSHOT .. Patch Set 2: ugh I'm dumb, pushed against master -- To view, visit http://gerrit.cloudera.org:8080/6668 To unsubscribe,

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart .. Patch Set 1: > As I understand, it's not necessary to merge this into

[kudu-CR] Bump version to 1.3.2-SNAPSHOT

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6668 to review the following change. Change subject: Bump version to 1.3.2-SNAPSHOT .. Bump version to 1.3.2-SNAPSHOT

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart .. Patch Set 1: -Code-Review > I was curious about the need for this patch.

[kudu-CR](branch-1.3.x) [docs] Add another workaround for macOS

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Add another workaround for macOS .. [docs] Add another workaround for macOS I encountered an issue that was preventing me from building

[kudu-CR](branch-1.3.x) [docs] Add another workaround for macOS

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Add another workaround for macOS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6641 To unsubscribe, visit

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart .. Patch Set 1: I was curious about the need for this patch. It's all

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

2017-04-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index .. Patch Set 2: (1 comment)

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: env: add RWFile::GetExtentMap for analyzing file extents .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6583 To unsubscribe,

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6667 Change subject: [cmake] fixed 'latest' dir symlink on MacOS X .. [cmake] fixed 'latest' dir symlink on MacOS X If the 'latest' symbolic

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

2017-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6665 Change subject: [rpc] close socket on AcceptorPool::Shutdown() .. [rpc] close socket on AcceptorPool::Shutdown() Close the underlying