[kudu-CR] [python] added KuduPartialRow::SetNoCopy{Binary,String}()

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [python] added KuduPartialRow::SetNoCopy{Binary,String}() .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/5114 To unsubscribe, visit

[kudu-CR] [clock] minor clean-up on the Clock class

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [clock] minor clean-up on the Clock class .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/5303 To unsubscribe, visit

[kudu-CR] KUDU-2027 retry scan RPC if negotiation times out

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2027 retry scan RPC if negotiation times out .. Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/7037/14//COMMIT_MSG Commit Message: PS14,

[kudu-CR] consensus: Get rid of a bunch of cmeta wrappers

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: consensus: Get rid of a bunch of cmeta wrappers .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7323 To unsubscribe, visit

[kudu-CR] kserver: consolidate randomized failure monitors

2017-06-28 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7330 to review the following change. Change subject: kserver: consolidate randomized failure monitors

[kudu-CR] WIP: consensus peers: schedule raft heartbeats through messenger

2017-06-28 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7331 to review the following change. Change subject: WIP: consensus_peers: schedule raft heartbeats through messenger

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 1: (1 comment)

[kudu-CR] raft consensus: failure detector doesn't need external synchronization

2017-06-28 Thread Adar Dembo (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7329 to review the following change. Change subject: raft_consensus: failure detector doesn't need external synchronization

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-28 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#4). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers.

[kudu-CR] time manager: fix unsynchronized access to GetSerialTimestamp()

2017-06-28 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7328 to review the following change. Change subject: time_manager: fix unsynchronized access to GetSerialTimestamp()

[kudu-CR] consensus: Get rid of a bunch of cmeta wrappers

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Get rid of a bunch of cmeta wrappers .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7323 To unsubscribe, visit

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-28 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#3). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers.

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7191 to look at the new patch set (#9). Change subject: Create ConsensusMetadataManager .. Create

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File

[kudu-CR] consensus: Get rid of a bunch of cmeta wrappers

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/7323 Change subject: consensus: Get rid of a bunch of cmeta wrappers .. consensus: Get rid of a bunch of cmeta wrappers We can directly access

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7191 to look at the new patch set (#8). Change subject: Create ConsensusMetadataManager .. Create

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File

[kudu-CR] Rename MiniClusterOptions to InternalMiniClusterOptions

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Rename MiniClusterOptions to InternalMiniClusterOptions .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7287 To unsubscribe,

[kudu-CR] Rename MiniClusterOptions to InternalMiniClusterOptions

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Rename MiniClusterOptions to InternalMiniClusterOptions .. Rename MiniClusterOptions to InternalMiniClusterOptions Change-Id:

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. ConsensusMetadata::Create() should not overwrite an existing file We want to be able

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 6: Code-Review+2 Porting forward +2s from several others before a rebase. -- To

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 6: Verified+1 overriding flaky test -- To view, visit

[kudu-CR] [java] separating Connection

2017-06-28 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7146 to look at the new patch set (#18). Change subject: [java] separating Connection .. [java] separating

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-28 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7250 to look at the new patch set (#4). Change subject: [java] KUDU-2013 re-acquire authn token if expired .. [java]

[kudu-CR] [java] excluded slf4j from async dependency

2017-06-28 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7320 Change subject: [java] excluded slf4j from async dependency .. [java] excluded slf4j from async dependency The slf4j-api dependency

[kudu-CR] [rpc] use C++11 move semantics for selected methods

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [rpc] use C++11 move semantics for selected methods .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/6766 To unsubscribe, visit

[kudu-CR] [java] re-acquire authn token if expired

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [java] re-acquire authn token if expired .. Abandoned This is superseded by https://gerrit.cloudera.org/#/c/7250/ -- To view, visit

[kudu-CR] [util] use emplace() instead of insert()

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [util] use emplace() instead of insert() .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/6807 To unsubscribe, visit

[kudu-CR] KUDU-1927 [master] always send IPKI CA certificate

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: KUDU-1927 [master] always send IPKI CA certificate .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/6356 To unsubscribe, visit

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [mini_{master,tablet_server}] webserver binding change .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/7266 To unsubscribe, visit

[kudu-CR] [raft consensus-itest] CHECK OK --> ASSERT OK where possible

2017-06-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: [raft_consensus-itest] CHECK_OK --> ASSERT_OK where possible .. Abandoned not needed -- To view, visit http://gerrit.cloudera.org:8080/7172 To unsubscribe, visit

[kudu-CR] mini tablet server: support multiple data dirs

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: mini_tablet_server: support multiple data dirs .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/7211/6//COMMIT_MSG Commit Message: Line 7:

[kudu-CR](branch-1.3.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR] log block manager: do not fail block creation if truncate fails

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log block manager: do not fail block creation if truncate fails .. log block manager: do not fail block creation if truncate fails RETURN_NOT_OK here

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Use dynamic bind address for internal + external mini clusters .. Use dynamic bind address for internal + external mini clusters This technique helps

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7274 To

[kudu-CR](branch-1.4.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [mini_{master,tablet_server}] webserver binding change .. Patch Set 2: Instead of RUN_SERIAL we should probably mark them with a RESOURCE_LOCK "bind_wildcard" or

[kudu-CR] [mini {master,tablet server}] webserver binding change

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [mini_{master,tablet_server}] webserver binding change .. Patch Set 2: I think once we merge https://gerrit.cloudera.org/7274 then we just need to mark any tests

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 6: Verified+1 overriding flaky test -- To view, visit

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-28 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1932. Run at least one tablet-level test against all block managers. .. Patch Set 2: (8 comments)

[kudu-CR](branch-1.2.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR](branch-1.2.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 1: > Build Failed > >

[kudu-CR](branch-1.2.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7317

[kudu-CR](branch-1.4.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7319

[kudu-CR](branch-1.3.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7318

[kudu-CR](branch-1.2.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7317

[kudu-CR] [java] separating Connection

2017-06-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 17: Code-Review+1 LGTM, does Todd or JD want to take another look? -- To view, visit

[kudu-CR] [docs] Add an upgrade note about MM threads

2017-06-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Add an upgrade note about MM threads .. [docs] Add an upgrade note about MM threads Some users configure MM threads to high values to work

[kudu-CR] [docs] Add an upgrade note about MM threads

2017-06-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Add an upgrade note about MM threads .. Patch Set 2: Verified+1 Overriding Jenkins since this is a docs change. -- To view, visit

[kudu-CR](branch-1.3.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7318 Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR](branch-1.4.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7319 Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR](branch-1.2.x) KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock

2017-06-28 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7317 Change subject: KUDU-2049 Fix too-strict CHECK in RleIntBlockDecoder::SeekToPositionInBlock .. KUDU-2049 Fix too-strict CHECK in

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-28 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7276 To