[kudu-CR] [java] Update outdated dependencies

2017-08-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 7: I removed the Spark 2.2 upgrade since I found it only supports Java 8. I will handle that separately since it

[kudu-CR] [java] Update outdated dependencies

2017-08-15 Thread Grant Henke (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7647 to look at the new patch set (#7). Change subject: [java] Update outdated dependencies .. [java]

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7685/1/src/kudu/rpc/proxy.h File

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7685/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7599 to look at the new patch set (#3). Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 3: (5 comments)

[kudu-CR] disk failure: add persistent disk states

2017-08-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7270 to look at the new patch set (#13). Change subject: disk failure: add persistent disk states .. disk failure: add

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 1: @Sailesh, I think this may be sufficient to fix the 'rdns=false' issue in

[kudu-CR] rpc: some small cleanup in ConnectionId

2017-08-15 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7686 to review the following change. Change subject: rpc: some small cleanup in ConnectionId .. rpc: some

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-15 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7687 to review the following change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-15 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7685 to review the following change. Change subject: rpc: move ConnectionId to its own file .. rpc: move

[kudu-CR] gutil: remove use of deprecated headers

2017-08-15 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7684 to review the following change. Change subject: gutil: remove use of deprecated headers .. gutil:

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/7602/7/src/kudu/fs/block_manager-test.cc File

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. KUDU-2091: Certificates with intermediate CA's do not work with Kudu Kudu

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 10: (5 comments) Hao, Dan, and I had a long discussion about this patch, and I wanted to reproduce

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-15 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#7). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 6: (34 comments) http://gerrit.cloudera.org:8080/#/c/7602/6//COMMIT_MSG Commit Message: PS6, Line 23:

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 4: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/9318/

[kudu-CR] [iwyu] first pass

2017-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] first pass .. Patch Set 15: > definitely woudl be nice to get rid of some of the more common > pragmas... here's a count from grep | uniq -c | sort -nk1

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/7662/2//COMMIT_MSG

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7662 to look at the new patch set (#4). Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 2: (20 comments)

[kudu-CR] WIP: [iwyu] first pass

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: [iwyu] first pass .. Patch Set 14: definitely woudl be nice to get rid of some of the more common pragmas... here's a count from grep | uniq -c | sort -nk1

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 3: (7 comments)

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 2: (3 comments)

[kudu-CR] [thirdparty]: added include-what-you-use

2017-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [thirdparty]: added include-what-you-use .. [thirdparty]: added include-what-you-use Build the include-what-you-use utility along with the LLVM

[kudu-CR] [build-support] added IWYU filter script

2017-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [build-support] added IWYU filter script .. [build-support] added IWYU filter script Added a script to filter the output from the include-what-you-use

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-15 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#16). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-15 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (1 comment)

[kudu-CR] [java] Update outdated dependencies

2017-08-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 6: Turns out Spark 2.2 dropped java 7 support. I will open a discussion to see how we want to handle that on the

[kudu-CR] [java] Update outdated dependencies

2017-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7647 To unsubscribe, visit

[kudu-CR] [java] Update outdated dependencies

2017-08-15 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7647 to look at the new patch set (#6). Change subject: [java] Update outdated dependencies .. [java] Update outdated

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 2: (4 comments) Thanks again for taking a look. Replies to some questions below

[kudu-CR] KUDU-2091: Certificates with intermediate CA's do not work with Kudu

2017-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2091: Certificates with intermediate CA's do not work with Kudu .. Patch Set 2: (5 comments) Overall looks good to me, just some nits in the commit