[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-16 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#18). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. Patch Set 2: (5 comments) some nits

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 17: (10 comments) I think I'm done reviewing everything outside log_block_manager.cc. Still a lot

[kudu-CR] [docs] Deprecate Java 7 and Spark 1

2017-08-16 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7699 Change subject: [docs] Deprecate Java 7 and Spark 1 .. [docs] Deprecate Java 7 and Spark 1 Starts the release notes for Kudu 1.5.0 and

[kudu-CR] [iwyu] update on the internal and boost mappings

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] update on the internal and boost mappings .. Patch Set 1: (1 comment)

[kudu-CR] [iwyu] update on the internal and boost mappings

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [iwyu] update on the internal and boost mappings .. Patch Set 1: (2 comments)

[kudu-CR] [iwyu] update on the internal and boost mappings

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [iwyu] update on the internal and boost mappings .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7696/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] [iwyu] update on the internal and boost mappings

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7696 Change subject: [iwyu] update on the internal and boost mappings .. [iwyu] update on the internal and boost mappings Updated the

[kudu-CR] [iwyu] first pass

2017-08-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4738 to look at the new patch set (#16). Change subject: [iwyu] first pass .. [iwyu] first pass Updated C++ source

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7692 to look at the new patch set (#2). Change subject: KUDU-2032 (part 2): propagate master hostnames into client ..

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: rpc: move ConnectionId to its own file .. rpc: move ConnectionId to its own file This class was previously implemented inside of outbound_call.{cc,h}

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7685 To unsubscribe, visit

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: gutil: remove use of deprecated headers .. gutil: remove use of deprecated headers We've been on C++11 for a long time now. This commit removes usage of

[kudu-CR] security: only lookup hostname if HOST substitution is required

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7694 to review the following change. Change subject: security: only lookup hostname if _HOST substitution is required ..

[kudu-CR] KUDU-1942. Kerberos fails to log in on hostnames with capital letters

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7693 to review the following change. Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital letters

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 4: (4 comments)

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-16 Thread Michael Ho (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7599 to look at the new patch set (#4). Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7684 To unsubscribe, visit

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7602 To unsubscribe, visit

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#10). Change subject: separate DataDirManager from BlockManagers ..

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 2: Verified+1 some java flake -- To view, visit http://gerrit.cloudera.org:8080/7684 To unsubscribe, visit

[kudu-CR] rpc: some small cleanup in ConnectionId

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId .. Patch Set 2: Code-Review+2 It seems there were unrelated flaky tests in RELEASE and SAN configs, but overall LGTM.

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7602/9/src/kudu/fs/fs_manager.cc File

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: move ConnectionId to its own file .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7685 To unsubscribe, visit

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7602/8/src/kudu/fs/block_manager-stress-test.cc File

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#9). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] KUDU-2032 (part 2): propagate master hostnames into client

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7692 to review the following change. Change subject: KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR] KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-2065, KUDU-2011: Release sidecars on cancellation or timeout .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 16: > (5 comments) > > Hao, Dan, and I had a long discussion about this patch, and I > wanted to

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/7207/16/src/kudu/cfile/cfile-test.cc File

[kudu-CR] KUDU-1943: Add BlockTransaction to Block Manager

2017-08-16 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#17). Change subject: KUDU-1943: Add BlockTransaction to Block Manager .. KUDU-1943:

[kudu-CR] rpc: move ConnectionId to its own file

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7685 to look at the new patch set (#2). Change subject: rpc: move ConnectionId to its own file

[kudu-CR] KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7687 to look at the new patch set (#2). Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

[kudu-CR] rpc: some small cleanup in ConnectionId

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7686 to look at the new patch set (#2). Change subject: rpc: some small cleanup in ConnectionId .. rpc: some small

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7684 to look at the new patch set (#2). Change subject: gutil: remove use of deprecated headers .. gutil: remove use of

[kudu-CR] rpc: some small cleanup in ConnectionId

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7686/1/src/kudu/rpc/proxy.cc File src/kudu/rpc/proxy.cc:

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7684/1/src/kudu/gutil/hash/hash.h File

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7684/1/src/kudu/gutil/hash/hash.h File

[kudu-CR] KUDU-2098. Drop Spark 1 Support

2017-08-16 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7690 Change subject: KUDU-2098. Drop Spark 1 Support .. KUDU-2098. Drop Spark 1 Support Spark 2 has been available for over a year and the

[kudu-CR] [java] Update outdated dependencies

2017-08-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7647 To unsubscribe, visit

[kudu-CR] [java] Update outdated dependencies

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java] Update outdated dependencies .. Patch Set 7: Code-Review+2 Maybe JD or Dan want to take a look too? -- To view, visit http://gerrit.cloudera.org:8080/7647

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/7602/8/src/kudu/fs/block_manager-stress-test.cc File

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: separate DataDirManager from BlockManagers .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/7602/7/src/kudu/fs/block_manager-test.cc File

[kudu-CR] separate DataDirManager from BlockManagers

2017-08-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7602 to look at the new patch set (#8). Change subject: separate DataDirManager from BlockManagers .. separate

[kudu-CR] handle disk failures during tablet copies

2017-08-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: handle disk failures during tablet copies .. Patch Set 1: (3 comments) I imagine Mike will do a more thorough review, but overall looks good to me.

[kudu-CR] rpc: some small cleanup in ConnectionId

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: some small cleanup in ConnectionId .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7686/1/src/kudu/rpc/proxy.cc File

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7684/1/src/kudu/gutil/hash/hash.h File

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 1: looks good to me, but clang doens't seem to agree :) -- To view, visit