[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8488 ) Change subject: [hybrid_clock-test] adapt the test for OS X .. Patch Set 2: Verified+1 unrelated flakes in: *

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8488 ) Change subject: [hybrid_clock-test] adapt the test for OS X .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] [tests] fix flake in RaftConsensusNonVoterITest

2017-11-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8477 ) Change subject: [tests] fix flake in RaftConsensusNonVoterITest .. Patch Set 1: Code-Review+2 (2 comments)

[kudu-CR] mini hms: bump start timeout to 60sec

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8485 ) Change subject: mini_hms: bump start timeout to 60sec .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8488 to look at the new patch set (#2). Change subject: [hybrid_clock-test] adapt the test for OS X ..

[kudu-CR] [tls socket] workaround for TLS short read

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8328 ) Change subject: [tls_socket] workaround for TLS short read .. Abandoned obsoleted by 18e024cf8bcaea192efb63780802cc4c799bbb9c -- To view, visit

[kudu-CR] [hybrid clock-test] adapt the test for OS X

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8488 Change subject: [hybrid_clock-test] adapt the test for OS X .. [hybrid_clock-test] adapt the test for OS X Fixed linkage breakage on OS

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: disk failure: make various delta paths more robust to errors .. Patch Set 3: (7 comments)

[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken

2017-11-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 ) Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken

2017-11-06 Thread Hao Hao (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8452 to look at the new patch set (#2). Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken

[kudu-CR] Add 'flex' to preflight.py script

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8483 ) Change subject: Add 'flex' to preflight.py script .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8483 To

[kudu-CR] Add 'flex' to preflight.py script

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: Add 'flex' to preflight.py script .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8483 To unsubscribe, visit

[kudu-CR] Add 'flex' to preflight.py script

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8483 ) Change subject: Add 'flex' to preflight.py script .. Add 'flex' to preflight.py script flex is required to build thrift, so it's

[kudu-CR] mini hms: bump start timeout to 60sec

2017-11-06 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8485 to review the following change. Change subject: mini_hms: bump start timeout to 60sec .. mini_hms: bump start timeout

[kudu-CR] Add 'flex' to preflight.py script

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8483 ) Change subject: Add 'flex' to preflight.py script .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8483

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2202 avoid block ID reuse for missing dirs

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8465 ) Change subject: KUDU-2202 avoid block ID reuse for missing dirs .. Patch Set 8: (1 comment)

[kudu-CR] [docs] Add note about lack of versioning column

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8482 ) Change subject: [docs] Add note about lack of versioning column .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Add 'flex' to preflight.py script

2017-11-06 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8483 to review the following change. Change subject: Add 'flex' to preflight.py script .. Add 'flex' to preflight.py

[kudu-CR] installation.adoc: add JDK and flex dependencies

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 ) Change subject: installation.adoc: add JDK and flex dependencies .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] cmake: use MAKE C IDENTIFIER to generate valid target names

2017-11-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8481 ) Change subject: cmake: use MAKE_C_IDENTIFIER to generate valid target names .. cmake: use MAKE_C_IDENTIFIER to generate valid

[kudu-CR] cmake: use MAKE C IDENTIFIER to generate valid target names

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8481 ) Change subject: cmake: use MAKE_C_IDENTIFIER to generate valid target names .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] cmake: use MAKE C IDENTIFIER to generate valid target names

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: cmake: use MAKE_C_IDENTIFIER to generate valid target names .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8481 To

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: disk failure: make various delta paths more robust to errors .. Patch Set 3: Verified+1 The build failures seem to be

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: disk failure: make various delta paths more robust to errors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8441 To

[kudu-CR] installation.adoc: add JDK and flex dependencies

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 ) Change subject: installation.adoc: add JDK and flex dependencies .. Patch Set 2: Verified+1 flake -- To view, visit

[kudu-CR] installation.adoc: add JDK and flex dependencies

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: installation.adoc: add JDK and flex dependencies .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8463 To unsubscribe,

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: disk failure: make various delta paths more robust to errors .. Patch Set 2: Did some cleanup here to fail more

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#3). Change subject: disk failure: make various delta paths more robust to errors

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8441 ) Change subject: disk failure: make various delta paths more robust to errors .. Patch Set 2: (10 comments)

[kudu-CR] disk failure: make various delta paths more robust to errors

2017-11-06 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8441 to look at the new patch set (#2). Change subject: disk failure: make various delta paths more robust to errors

[kudu-CR] cmake: use MAKE C IDENTIFIER to generate valid target names

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8481 ) Change subject: cmake: use MAKE_C_IDENTIFIER to generate valid target names .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [security] test and fixes for TLS socket EINTR issues

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. [security] test and fixes for TLS socket EINTR issues

[kudu-CR] [security] test and fixes for TLS socket EINTR issues

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X

2017-11-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8473 ) Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X .. [stopwatch] update Stopwatch::GetTimes() on OS X Updated

[kudu-CR] KUDU-1411: Implement HT timestamp propagation in KuduScanToken

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8452 ) Change subject: KUDU-1411: Implement HT timestamp propagation in KuduScanToken .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1809: Add batch size configuration for ScanToken API

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8435 ) Change subject: KUDU-1809: Add batch size configuration for ScanToken API .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1809: Add batch size configuration for ScanToken API

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8435 ) Change subject: KUDU-1809: Add batch size configuration for ScanToken API .. KUDU-1809: Add batch size configuration for

[kudu-CR] KUDU-1809: Add batch size configuration for ScanToken API

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: KUDU-1809: Add batch size configuration for ScanToken API .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8435 To

[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8473 ) Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [security] test and fixes for TLS socket EINTR issues

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8462 ) Change subject: [security] test and fixes for TLS socket EINTR issues .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR] installation.adoc: add JDK and flex dependencies

2017-11-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8463 ) Change subject: installation.adoc: add JDK and flex dependencies .. Patch Set 1: (2 comments)

[kudu-CR] installation.adoc: add JDK and flex dependencies

2017-11-06 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8463 to look at the new patch set (#2). Change subject: installation.adoc: add JDK and flex dependencies