[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9180 ) Change subject: KUDU-2279 (part 5): don't include entity attributes in log .. Patch Set 3: Code-Review+2 Carrying +2 -- To view, visit

[kudu-CR] KUDU-2279 (part 3): metrics: don't emit untouched metrics to log

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9177 ) Change subject: KUDU-2279 (part 3): metrics: don't emit untouched metrics to log .. KUDU-2279 (part 3): metrics: don't emit

[kudu-CR] KUDU-2279 (part 4): enable metrics log by default

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9178 ) Change subject: KUDU-2279 (part 4): enable metrics log by default .. KUDU-2279 (part 4): enable metrics log by default

[kudu-CR] KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9176 ) Change subject: KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log .. KUDU-2279 (part 2): metrics: only emit

[kudu-CR] KUDU-2279 (part 4): enable metrics log by default

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9178 ) Change subject: KUDU-2279 (part 4): enable metrics log by default .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit

[kudu-CR] KUDU-2279 (part 3): metrics: don't emit untouched metrics to log

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9177 ) Change subject: KUDU-2279 (part 3): metrics: don't emit untouched metrics to log .. Patch Set 3: Code-Review+2 carrying +2 -- To view,

[kudu-CR] KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9176 ) Change subject: KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log .. Patch Set 3: Yea, though we do dump all of the

[kudu-CR] KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log

2018-02-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9176 ) Change subject: KUDU-2279 (part 2): metrics: only emit changed metrics in metrics log .. Patch Set 3: Code-Review+2 Nice feature. One

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 10: Code-Review+1 (2 comments) This LGTM

[kudu-CR] WIP: Create a rolling-failure endurance test

2018-02-05 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9222 to look at the new patch set (#3). Change subject: WIP: Create a rolling-failure endurance test ..

[kudu-CR] WIP: Create a rolling-failure endurance test

2018-02-05 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9222 to look at the new patch set (#2). Change subject: WIP: Create a rolling-failure endurance test ..

[kudu-CR] WIP: Create a rolling-failure endurance test

2018-02-05 Thread Mike Percy (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9222 to review the following change. Change subject: WIP: Create a rolling-failure endurance test .. WIP: Create a

[kudu-CR] build-support: fix reporting of build configuration

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9182 ) Change subject: build-support: fix reporting of build configuration .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8692 to look at the new patch set (#10). Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9216 ) Change subject: tablet: don't store row count in delta tracker .. Patch Set 5: (7 comments)

[kudu-CR] Improved logging of DMS flushes

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9204 ) Change subject: Improved logging of DMS flushes .. Improved logging of DMS flushes >From compaction-test.cc's TestRowSetInput,

[kudu-CR] Improved logging of DMS flushes

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9204 ) Change subject: Improved logging of DMS flushes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9204 To

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-05 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8692 to look at the new patch set (#9). Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 7: Todd had some offline feedback to give the

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-05 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8692 to look at the new patch set (#8). Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9216 to look at the new patch set (#5). Change subject: tablet: don't store row count in delta tracker

[kudu-CR] Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

2018-02-05 Thread Mahdi Askari (Code Review)
Mahdi Askari has posted comments on this change. ( http://gerrit.cloudera.org:8080/8960 ) Change subject: Adding a subsection to NTP troubleshooting section to cover frequent cases of NTP crashes when the Kudu cluster is deployed on Microsoft Azure

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9216 ) Change subject: tablet: don't store row count in delta tracker .. Patch Set 4: (4 comments)

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9216 to look at the new patch set (#4). Change subject: tablet: don't store row count in delta tracker

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9216 to look at the new patch set (#3). Change subject: tablet: don't store row count in delta tracker

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9216 ) Change subject: tablet: don't store row count in delta tracker .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9199 ) Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns .. KUDU-2281: Add Primary Key Support For INT128 Columns

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 ) Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns .. Patch Set 6: Added back Dan's +2 after a negligible lint fix.

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 ) Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] Don't rely on pending config OpId index for peer promotion

2018-02-05 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9161 ) Change subject: Don't rely on pending config OpId index for peer promotion .. Don't rely on pending config OpId index for peer

[kudu-CR] Don't rely on pending config OpId index for peer promotion

2018-02-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9161 ) Change subject: Don't rely on pending config OpId index for peer promotion .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9216 to look at the new patch set (#2). Change subject: tablet: don't store row count in delta tracker .. tablet: don't

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-05 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9216 Change subject: tablet: don't store row count in delta tracker .. tablet: don't store row count in delta tracker DeltaTracker's

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9199 to look at the new patch set (#6). Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 ) Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 ) Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-721: [Spark] Add DECIMAL type support

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9213 Change subject: KUDU-721: [Spark] Add DECIMAL type support .. KUDU-721: [Spark] Add DECIMAL type support Adds DECIMAL support to the Kudu

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9199 to look at the new patch set (#4). Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns

[kudu-CR] [docs] Added recommendation to compress PK for backfill inserts

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9185 ) Change subject: [docs] Added recommendation to compress PK for backfill inserts .. [docs] Added recommendation to compress PK for

[kudu-CR] [docs] Added recommendation to compress PK for backfill inserts

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has removed a vote on this change. Change subject: [docs] Added recommendation to compress PK for backfill inserts .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9185

[kudu-CR] [docs] Added recommendation to compress PK for backfill inserts

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9185 ) Change subject: [docs] Added recommendation to compress PK for backfill inserts .. Patch Set 4: Verified+1 Code-Review+2 -- To view,

[kudu-CR] [tests] Add more test coverage for INT128 columns

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9193 ) Change subject: [tests] Add more test coverage for INT128 columns .. [tests] Add more test coverage for INT128 columns Improves

[kudu-CR] [docs] Add scaling guide

2018-02-05 Thread Will Berkeley (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8842 to look at the new patch set (#3). Change subject: [docs] Add scaling guide

[kudu-CR] [docs] Add scaling guide

2018-02-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8842 ) Change subject: [docs] Add scaling guide .. Patch Set 2: New rendering at

[kudu-CR] [docs] Add scaling guide

2018-02-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8842 ) Change subject: [docs] Add scaling guide .. Patch Set 2: (2 comments)

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2018-02-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 6: (1 comment)

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2018-02-05 Thread Will Berkeley (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8402 to look at the new patch set (#7). Change subject: [docs] Document how to recover from a majority failed tablet

[kudu-CR] [tests] Add more test coverage for INT128 columns

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9193 ) Change subject: [tests] Add more test coverage for INT128 columns .. Patch Set 9: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2281: Add Primary Key Support For INT128 Columns

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9199 ) Change subject: KUDU-2281: Add Primary Key Support For INT128 Columns .. Patch Set 3: (4 comments)

[kudu-CR] [tests] Add more test coverage for INT128 columns

2018-02-05 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9193 ) Change subject: [tests] Add more test coverage for INT128 columns .. Patch Set 9: (2 comments)

[kudu-CR] [tests] Add more test coverage for INT128 columns

2018-02-05 Thread Grant Henke (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9193 to look at the new patch set (#9). Change subject: [tests] Add more test coverage for INT128 columns

[kudu-CR] [tests] Add more test coverage for INT128 columns

2018-02-05 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9193 ) Change subject: [tests] Add more test coverage for INT128 columns .. Patch Set 8: (2 comments) LGTM, but seems like it may be a good

[kudu-CR] Improved logging of DMS flushes

2018-02-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9204 ) Change subject: Improved logging of DMS flushes .. Patch Set 1: (3 comments)

[kudu-CR] Improved logging of DMS flushes

2018-02-05 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9204 to look at the new patch set (#2). Change subject: Improved logging of DMS flushes .. Improved logging