Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 )
Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/8804/10/src/kudu/tserver/tablet_server-test.cc@1953 PS10, Line 1953: // Make sure that there is no snapshot timestamp sent back. : ASSERT_TRUE(!resp.has_snap_timestamp()); > I'm still unsure why we wouldn't the response to include the timestamp. I a I see, so looks like you are proposing to make this read mode fault-tolerant as well. Which means we need to make it an ordered scan and ensure the client sent out the last primary key to retry on. I do not see any reasons to not make this mode fault tolerant, but I do not see the reasons why we have to return the chosen snapshot timestamp for the scan to retry on another server in this case. I think the next tsever that the scan is retried on can chose the timestamp freely based on the conditions, right? Moreover, would you mind I do another patch if we do want RYW to be fault tolerant, to make it more clear? -- To view, visit http://gerrit.cloudera.org:8080/8804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84ddb981a1a0f199d4e66f5d5097318f8c785a48 Gerrit-Change-Number: 8804 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 06 Feb 2018 01:21:14 +0000 Gerrit-HasComments: Yes
