[kudu-CR] Add previous / current thread to collision warner

2018-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9237 ) Change subject: Add previous / current thread to collision warner .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] Add previous / current thread to collision warner

2018-02-06 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9237 to review the following change. Change subject: Add previous / current thread to collision warner .. Add previous /

[kudu-CR] Fix crash when log dir is not specified

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9233 ) Change subject: Fix crash when log_dir is not specified .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Fix crash when log dir is not specified

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9233 ) Change subject: Fix crash when log_dir is not specified .. Fix crash when log_dir is not specified This fixes the tpch1 benchmark

[kudu-CR] [docs] MacPorts specific build instructions

2018-02-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9236 Change subject: [docs] MacPorts specific build instructions .. [docs] MacPorts specific build instructions Added instructions to build

[kudu-CR] docs: improvements to transaction semantics

2018-02-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9235 ) Change subject: docs: improvements to transaction semantics .. Patch Set 1: Code-Review+1 Which version of Kudu does this apply? -- To

[kudu-CR] docs: improvements to transaction semantics

2018-02-06 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9235 Change subject: docs: improvements to transaction semantics .. docs: improvements to transaction semantics Change-Id:

[kudu-CR] docs: Update release management documentation

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 3: Updated render:

[kudu-CR] docs: Update release management documentation

2018-02-06 Thread Mike Percy (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8744 to look at the new patch set (#3). Change subject: docs: Update release management documentation ..

[kudu-CR] docs: Update release management documentation

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 2: (1 comment)

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 ) Change subject: Update instructions for publishing changes to the live site .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8059 ) Change subject: Update instructions for publishing changes to the live site .. Update instructions for publishing changes to the

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has removed a vote on this change. Change subject: Update instructions for publishing changes to the live site .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8059 To

[kudu-CR] docs: improvements to NTP troubleshooting

2018-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9234 ) Change subject: docs: improvements to NTP troubleshooting .. Patch Set 1: This will probably conflict with Mahdi's in-flight change.

[kudu-CR] docs: improvements to NTP troubleshooting

2018-02-06 Thread Todd Lipcon (Code Review)
Hello Alex Rodoni, Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9234 to review the following change. Change subject: docs: improvements to NTP troubleshooting ..

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 ) Change subject: Update instructions for publishing changes to the live site .. Patch Set 2: Code-Review+2 OK SGTM -- To view, visit

[kudu-CR] Add log parser script

2018-02-06 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8229 to look at the new patch set (#3). Change subject: Add log parser script .. Add

[kudu-CR] docs: Update release management documentation

2018-02-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 2: (1 comment)

[kudu-CR] Add log parser script

2018-02-06 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8229 to look at the new patch set (#2). Change subject: Add log parser script .. Add log parser

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 ) Change subject: Update instructions for publishing changes to the live site .. Patch Set 2: > what do you think about moving the entire

[kudu-CR] docs: Update release management documentation

2018-02-06 Thread Mike Percy (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8744 to look at the new patch set (#2). Change subject: docs: Update release management documentation ..

[kudu-CR] docs: Update release management documentation

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8744 ) Change subject: docs: Update release management documentation .. Patch Set 2: Rendered version:

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 ) Change subject: Update instructions for publishing changes to the live site .. Patch Set 2: Text looks good to me, but what do you think

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8059 ) Change subject: Update instructions for publishing changes to the live site .. Patch Set 2: (1 comment)

[kudu-CR] Update instructions for publishing changes to the live site

2018-02-06 Thread Mike Percy (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8059 to look at the new patch set (#2). Change subject: Update instructions for publishing changes to the live site

[kudu-CR] Fix crash when log dir is not specified

2018-02-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/9233 ) Change subject: Fix crash when log_dir is not specified .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] Fix crash when log dir is not specified

2018-02-06 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9233 to review the following change. Change subject: Fix crash when log_dir is not specified .. Fix crash when

[kudu-CR] KUDU-1704: add READ YOUR WRITES scan mode

2018-02-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8804 ) Change subject: KUDU-1704: add READ_YOUR_WRITES scan mode .. Patch Set 10: (1 comment)

[kudu-CR] [docs] Add scaling guide

2018-02-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8842 ) Change subject: [docs] Add scaling guide .. Patch Set 3: (7 comments)

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2018-02-06 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 7: (5 comments)

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

2018-02-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 5: (1 comment)

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9216 ) Change subject: tablet: don't store row count in delta tracker .. Patch Set 5: (7 comments)

[kudu-CR] tablet: don't store row count in delta tracker

2018-02-06 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9216 to look at the new patch set (#6). Change subject: tablet: don't store row count in delta tracker

[kudu-CR] Move configuration keys into its own class and make public

2018-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8920 ) Change subject: Move configuration keys into its own class and make public .. Patch Set 2: Hey Clemens, sorry for the delay on this one.

[kudu-CR] KUDU-2279 (part 3): metrics: don't emit untouched metrics to log

2018-02-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9177 ) Change subject: KUDU-2279 (part 3): metrics: don't emit untouched metrics to log .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11

2018-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9159 ) Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11

2018-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9159 ) Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11 .. [thirdparty] fix sized-deallocation issue on OS X

[kudu-CR] build-support: fix reporting of build configuration

2018-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9182 ) Change subject: build-support: fix reporting of build configuration .. build-support: fix reporting of build configuration Our

[kudu-CR] KUDU-2279 (part 5): don't include entity attributes in log

2018-02-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9180 ) Change subject: KUDU-2279 (part 5): don't include entity attributes in log .. KUDU-2279 (part 5): don't include entity attributes