[kudu-CR] schema: add is deleted virtual column

2018-08-01 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#11). Change subject: schema: add is_deleted virtual column

[kudu-CR] schema: add is deleted virtual column

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 10: (2 comments) > Nice, looks like not too much boilerplate! Check

[kudu-CR] Add error handling to Backup and Restore

2018-08-01 Thread Tony Foerster (Code Review)
Tony Foerster has abandoned this change. ( http://gerrit.cloudera.org:8080/10941 ) Change subject: Add error handling to Backup and Restore .. Abandoned I was considering this a sort of incremental change, but looking at it I

[kudu-CR] KUDU-2095 - Add scanner `keepAlive` RPC call to Java API

2018-08-01 Thread Tony Foerster (Code Review)
Tony Foerster has abandoned this change. ( http://gerrit.cloudera.org:8080/7749 ) Change subject: KUDU-2095 - Add scanner `keepAlive` RPC call to Java API .. Abandoned Keepalive shouldn't rely on getting the same replica from

[kudu-CR] schema: add is deleted virtual column

2018-08-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 ) Change subject: schema: add is_deleted virtual column .. Patch Set 10: (2 comments) Nice, looks like not too much boilerplate!

[kudu-CR] schema: add is deleted virtual column

2018-08-01 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Dan Burkert, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10968 to look at the new patch set (#10). Change subject: schema: add is_deleted virtual column

[kudu-CR] memrowset: support iteration with is deleted virtual column

2018-08-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10990 to look at the new patch set (#8). Change subject: memrowset: support iteration with is_deleted virtual column

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components .. Patch Set 5: > > I took a quick look: my

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components .. Patch Set 5: > I took a quick look: my

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components .. Patch Set 5: (5 comments) still reviewing,

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components .. Patch Set 4: (7 comments) I took a quick

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Anupama Gupta (Code Review)
Anupama Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10983 ) Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components .. Patch Set 4: (22 comments) Please review

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10983 to look at the new patch set (#5). Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#13). Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] [tools] run rebalancer during 'election storm'

2018-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11107 Change subject: [tools] run rebalancer during 'election storm' .. [tools] run rebalancer during 'election storm' Added an integration

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#12). Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] Kudu-1291 Efficiently support predicates on non-prefix key components

2018-08-01 Thread Anupama Gupta (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11067 to look at the new patch set (#11). Change subject: Kudu-1291 Efficiently support predicates on non-prefix key components

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10656 ) Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements .. Patch Set 16: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. KUDU-2524: temporarily disable scalafmt in gradle

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Shriya Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10656 ) Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements .. Patch Set 16: (2 comments)

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Hello Thomas Marshall, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#16). Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements

[kudu-CR] hms-tool: lookup master addresses config from master

2018-08-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11083 ) Change subject: hms-tool: lookup master addresses config from master .. Patch Set 8: Code-Review+2 Carrying over Hao's +2. -- To

[kudu-CR] hms precheck tool

2018-08-01 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11040 ) Change subject: hms precheck tool .. hms precheck tool This commit adds a 'kudu hms precheck' tool that is meant to be used

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. Patch Set 2: Sorry for rebasing, I thought there was a

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Hello Thomas Marshall, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#15). Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [tools] --report only option for 'kudu cluster rebalance'

2018-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11097 ) Change subject: [tools] --report_only option for 'kudu cluster rebalance' .. [tools] --report_only option for 'kudu cluster

[kudu-CR] [tools] --report only option for 'kudu cluster rebalance'

2018-08-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11097 ) Change subject: [tools] --report_only option for 'kudu cluster rebalance' .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10656 ) Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements .. Patch Set 14: (2 comments)

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Tony Foerster (Code Review)
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] hms precheck tool

2018-08-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11040 ) Change subject: hms precheck tool .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11040 To unsubscribe,

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. Patch Set 1: I verified locally that this causes scalafmt

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11101 ) Change subject: KUDU-2524: temporarily disable scalafmt in gradle build .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] hms tools: do not require HMS configuration flags

2018-08-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 14: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2524: temporarily disable scalafmt in gradle build

2018-08-01 Thread Adar Dembo (Code Review)
Hello Tony Foerster, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11101 to review the following change. Change subject: KUDU-2524: temporarily disable scalafmt in gradle build

[kudu-CR] hms tools: do not require HMS configuration flags

2018-08-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 14: (1 comment)

[kudu-CR] hms tools: do not require HMS configuration flags

2018-08-01 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11036 to look at the new patch set (#14). Change subject: hms tools: do not require HMS configuration flags

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Hello Thomas Marshall, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#14). Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements

[kudu-CR] hms tools: do not require HMS configuration flags

2018-08-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11036 ) Change subject: hms tools: do not require HMS configuration flags .. Patch Set 13: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Shriya Gupta has posted comments on this change. ( http://gerrit.cloudera.org:8080/10656 ) Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements .. Patch Set 13: (7 comments) > (7 comments) > > I

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Hello Thomas Marshall, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#13). Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements

[kudu-CR] [tools] --report only option for 'kudu cluster rebalance'

2018-08-01 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Fengling Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11097 to look at the new patch set (#3). Change subject: [tools] --report_only option for 'kudu cluster rebalance'

[kudu-CR] [tools] --report only option for 'kudu cluster rebalance'

2018-08-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11097 ) Change subject: [tools] --report_only option for 'kudu cluster rebalance' .. Patch Set 2: (1 comment)

[kudu-CR] [tools] --report only option for 'kudu cluster rebalance'

2018-08-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11097 ) Change subject: [tools] --report_only option for 'kudu cluster rebalance' .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10656 ) Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements .. Patch Set 12: (7 comments) I filed KUDU-2523 for

[kudu-CR] KUDU-2459: add placeholder names to some CREATE TABLE statements

2018-08-01 Thread Shriya Gupta (Code Review)
Hello Thomas Marshall, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10656 to look at the new patch set (#12). Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements

[kudu-CR] Implement BloomFilter Predicate in server side.

2018-08-01 Thread ZhangYao (Code Review)
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11100 Change subject: Implement BloomFilter Predicate in server side. .. Implement BloomFilter Predicate in server side. Change-Id: