[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 4: Code-Review+1 (9 comments) Looks good.

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-15 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13021 ) Change subject: log_block_manager: reenable dead container deletion at runtime .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: WIP [docs] updated master-related scenarios w.r.t. CM .. Patch Set 1: Verified+1 unrelated test flake -- To view,

[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: WIP [docs] updated master-related scenarios w.r.t. CM .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13022 To

[kudu-CR] remove outdated information from consensus.txt

2019-04-15 Thread Jia Hongchao (Code Review)
Jia Hongchao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13023 Change subject: remove outdated information from consensus.txt .. remove outdated information from consensus.txt It says "For the

[kudu-CR] add document for KUDU-2080

2019-04-15 Thread Jia Hongchao (Code Review)
Jia Hongchao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12774 ) Change subject: add document for KUDU-2080 .. Patch Set 2: Sorry for the delay, it is my first time to use Gerrit.I thought there is

[kudu-CR] add document for KUDU-2080

2019-04-15 Thread Jia Hongchao (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12774 to look at the new patch set (#2). Change subject: add document for KUDU-2080

[kudu-CR] WIP [docs] updated master-related scenarios w.r.t. CM

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13022 Change subject: WIP [docs] updated master-related scenarios w.r.t. CM .. WIP [docs] updated master-related scenarios w.r.t. CM WIP: Do

[kudu-CR] log block manager: reenable dead container deletion at runtime

2019-04-15 Thread Adar Dembo (Code Review)
Hello Andrew Wong, helifu, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13021 to review the following change. Change subject: log_block_manager: reenable dead container deletion at runtime

[kudu-CR] add document for KUDU-2080

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12774 ) Change subject: add document for KUDU-2080 .. Patch Set 1: Jia, are you planning to address the feedback? -- To view, visit

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Removed reviewer Kudu Jenkins with the

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13011 ) Change subject: generic_iterators: MergeIterator whole block copy optimization .. Patch Set 4: Verified+1 Overriding Jenkins, unrelated

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization .. Removed Verified+1 by Adar Dembo -- To view, visit

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13009 ) Change subject: SelectionVector: pad extra bits with zeroes in constructor .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13009 ) Change subject: SelectionVector: pad extra bits with zeroes in constructor .. Patch Set 4: Verified+1 Overriding Jenkins, known flaky

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 10: > Patch Set 9: > > Now that the design doc is

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-04-15 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Greg Solovyev, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12119 to look at the new patch set (#10). Change subject: [blog] a blogpost about location awareness in Kudu

[kudu-CR] KUDU-2466: implement three-heap merge algorithm

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12947 ) Change subject: KUDU-2466: implement three-heap merge algorithm .. KUDU-2466: implement three-heap merge algorithm This patch

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 4: Code-Review+1 Would be good to get another set

[kudu-CR] KUDU-2466: implement three-heap merge algorithm

2019-04-15 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12947 to look at the new patch set (#10). Change subject: KUDU-2466: implement three-heap merge algorithm

[kudu-CR] bitmap: add copy operation

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13007 to look at the new patch set (#3). Change subject: bitmap: add copy operation .. bitmap:

[kudu-CR] generic iterators: refactor MergeIterator for whole-block-copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13010 to look at the new patch set (#4). Change subject: generic_iterators: refactor MergeIterator for whole-block-copy optimization

[kudu-CR] generic iterators: MergeIterator whole block copy optimization

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13011 to look at the new patch set (#4). Change subject: generic_iterators: MergeIterator whole block copy optimization

[kudu-CR] rowblock: add copying functionality

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13008 to look at the new patch set (#4). Change subject: rowblock: add copying functionality .. rowblock: add

[kudu-CR] SelectionVector: pad extra bits with zeroes in constructor

2019-04-15 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13009 to look at the new patch set (#4). Change subject: SelectionVector: pad extra bits with zeroes in constructor

[kudu-CR] generic iterators: pass rowset bounds into grouping iterators

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12946 ) Change subject: generic_iterators: pass rowset bounds into grouping iterators .. generic_iterators: pass rowset bounds into

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 4: Verified+1 -- To view, visit

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [backup] Add initial incremental backup/restore support .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12879 To

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 2: (1 comment)

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12879 to look at the new patch set (#4). Change subject: [backup] Add initial incremental backup/restore support

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 3: (2 comments)

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 2: (2 comments)

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 3: (2 comments)

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12879 ) Change subject: [backup] Add initial incremental backup/restore support .. Patch Set 3: (11 comments)

[kudu-CR] [jenkins] fix collection of Java dist-test logs

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 ) Change subject: [jenkins] fix collection of Java dist-test logs .. Patch Set 1: (1 comment)

[kudu-CR] [jenkins] fix collection of Java dist-test logs

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13014 ) Change subject: [jenkins] fix collection of Java dist-test logs .. Patch Set 1: (1 comment)

[kudu-CR] [backup] Add initial incremental backup/restore support

2019-04-15 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12879 to look at the new patch set (#3). Change subject: [backup] Add initial incremental backup/restore support

[kudu-CR](gh-pages) [blog] a blogpost about location awareness in Kudu

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12119 ) Change subject: [blog] a blogpost about location awareness in Kudu .. Patch Set 9: Now that the design doc is merged the link can be

[kudu-CR] [docs] updated docs w.r.t. collocation practices

2019-04-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12997 ) Change subject: [docs] updated docs w.r.t. collocation practices .. Patch Set 4: (1 comment)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (1 comment)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (3 comments) I took a quick look, will take