[kudu-CR] Add seek before mode for CBTree to accelerate CheckRowDeleted in dms.

2019-06-04 Thread ZhangYao (Code Review)
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13516 Change subject: Add seek before mode for CBTree to accelerate CheckRowDeleted in dms. .. Add seek before mode for CBTree to accelerate

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 11: (8 comments) Some nits and a testing suggestion, overall

[kudu-CR] sentry: add trace points

2019-06-04 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13493 ) Change subject: sentry: add trace points .. sentry: add trace points Adds TRACE statements at various points in Sentry

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13510 ) Change subject: hms: allow for tooling to run without Kudu plugin .. Patch Set 2: (5 comments)

[kudu-CR] sentry: add trace points

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13493 ) Change subject: sentry: add trace points .. Patch Set 3: Verified+1 Failures are unrelated to this patch. -- To view, visit

[kudu-CR] sentry: add trace points

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: sentry: add trace points .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13493 To unsubscribe, visit

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Patch Set 16: (4 comments) Almost there, just a few more comments.

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: it seems it's necessary to fix IWYU

[kudu-CR] sentry: add trace points

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13493 ) Change subject: sentry: add trace points .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13493 To

[kudu-CR] sentry: add trace points

2019-06-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13493 ) Change subject: sentry: add trace points .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13493 To

[kudu-CR] thirdparty: fix memkind build race

2019-06-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13513 ) Change subject: thirdparty: fix memkind build race .. thirdparty: fix memkind build race On rare occasions, the libmemkind.a

[kudu-CR] thirdparty: fix memkind build race

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13513 ) Change subject: thirdparty: fix memkind build race .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: fix memkind build race

2019-06-04 Thread Adar Dembo (Code Review)
Hello ye yuqiang, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13513 to review the following change. Change subject: thirdparty: fix memkind build race .. thirdparty: fix memkind build

[kudu-CR] KUDU-2813: Set Spark job descriptions for backup and restore jobs

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13512 Change subject: KUDU-2813: Set Spark job descriptions for backup and restore jobs .. KUDU-2813: Set Spark job descriptions for backup

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13510 ) Change subject: hms: allow for tooling to run without Kudu plugin .. Patch Set 2: (1 comment)

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13510 ) Change subject: hms: allow for tooling to run without Kudu plugin .. Patch Set 2: (1 comment)

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13510 ) Change subject: hms: allow for tooling to run without Kudu plugin .. Patch Set 2: Verified+1 TSAN:

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: hms: allow for tooling to run without Kudu plugin .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13510 To

[kudu-CR] WIP KUDU-2785: Add splitSizeBytes to the backup job

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13511 Change subject: WIP KUDU-2785: Add splitSizeBytes to the backup job .. WIP KUDU-2785: Add splitSizeBytes to the backup job This patch

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13510 to look at the new patch set (#2). Change subject: hms: allow for tooling to run without Kudu plugin

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: (1 comment)

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: (1 comment)

[kudu-CR] sentry: add trace points

2019-06-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13493 ) Change subject: sentry: add trace points .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13493/1//COMMIT_MSG Commit

[kudu-CR] sentry: add trace points

2019-06-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13493 to look at the new patch set (#3). Change subject: sentry: add trace points .. sentry: add

[kudu-CR] sentry: add trace points

2019-06-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13493 to look at the new patch set (#2). Change subject: sentry: add trace points .. sentry: add

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: (1 comment)

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-04 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Grant Henke, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13510 to review the following change. Change subject: hms: allow for tooling to run without Kudu plugin

[kudu-CR] KUDU-2830: [java] Improve RPC traces on RPC timeout

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13509 ) Change subject: KUDU-2830: [java] Improve RPC traces on RPC timeout .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2830: [java] Improve RPC traces on RPC timeout

2019-06-04 Thread Grant Henke (Code Review)
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13509 to look at the new patch set (#2). Change subject: KUDU-2830: [java] Improve RPC traces on RPC timeout

[kudu-CR] KUDU-2830: [java] Improve RPC traces on RPC timeout

2019-06-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13509 ) Change subject: KUDU-2830: [java] Improve RPC traces on RPC timeout .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2830: [java] Improve RPC traces on RPC timeout

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13509 Change subject: KUDU-2830: [java] Improve RPC traces on RPC timeout .. KUDU-2830: [java] Improve RPC traces on RPC timeout Currently

[kudu-CR] KUDU-2398: Kudu kubernetes statefulset manifest

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13407 ) Change subject: KUDU-2398: Kudu kubernetes statefulset manifest .. KUDU-2398: Kudu kubernetes statefulset manifest it builds

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Yao Xu (Code Review)
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 ) Change subject: KUDU-2514 Part 1: Support extra config for table. .. Patch Set 16: (15 comments) Thanks for the comments. I made some

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#16). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#15). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#14). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#13). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] [rebalance] remove unused function declaration and fix typo error in comment.

2019-06-04 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13505 ) Change subject: [rebalance] remove unused function declaration and fix typo error in comment. .. [rebalance] remove unused

[kudu-CR] KUDU-2514 Part 1: Support extra config for table.

2019-06-04 Thread Yao Xu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12468 to look at the new patch set (#12). Change subject: KUDU-2514 Part 1: Support extra config for table.

[kudu-CR] [rebalance] remove unused function declaration and fix typo error in comment.

2019-06-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13505 ) Change subject: [rebalance] remove unused function declaration and fix typo error in comment. .. Patch Set 1: Code-Review+2 -- To

[kudu-CR] [rebalance] remove unused function declaration and fix typo error in comment.

2019-06-04 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13505 Change subject: [rebalance] remove unused function declaration and fix typo error in comment. .. [rebalance] remove unused function

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 11: Code-Review+2 -- To view, visit

[kudu-CR] [tablet] Support accurate count of rows

2019-06-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13456 to look at the new patch set (#11). Change subject: [tablet] Support accurate count of rows ..