[kudu-CR] KUDU-2612 C++ client transaction API

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/16710 ) Change subject: KUDU-2612 C++ client transaction API .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 b

[kudu-CR] KUDU-2612 C++ client transaction API

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 ) Change subject: KUDU-2612 C++ client transaction API .. Patch Set 7: Verified+1 Unrelated test failure in TSAN build due to https://

[kudu-CR] [tablet copy client-test] fix scenario on DownloadBlocks() error reporting

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16709 ) Change subject: [tablet_copy_client-test] fix scenario on DownloadBlocks() error reporting .. Patch Set 4: Code-Review+2 Thank you fo

[kudu-CR] [tablet copy client-test] fix scenario on DownloadBlocks() error reporting

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16709 ) Change subject: [tablet_copy_client-test] fix scenario on DownloadBlocks() error reporting .. [tablet_copy_client-test] fix sc

[kudu-CR] KUDU-2612 C++ client transaction API

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 ) Change subject: KUDU-2612 C++ client transaction API .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/16710/6/src/kud

[kudu-CR] KUDU-2612 C++ client transaction API

2020-11-16 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16710 to look at the new patch set (#7). Change subject: KUDU-2612 C++ client transaction API ...

[kudu-CR] Revert "KUDU-3210 Add lock before verifying signature"

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#3) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/16731 ) Change subject: Revert "KUDU-3210 Add lock before verifying signature" .. Revert "KUDU-321

[kudu-CR] Revert "KUDU-3210 Add lock before verifying signature"

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16731 ) Change subject: Revert "KUDU-3210 Add lock before verifying signature" .. Revert "KUDU-3210 Add lock before verifying signature"

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16730 ) Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .. KUDU-3210 Add thread ID callback to OpenSSL init It seems th

[kudu-CR] [tablet copy client-test] fix scenario on DownloadBlocks() error reporting

2020-11-16 Thread wangning (Code Review)
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/16709 ) Change subject: [tablet_copy_client-test] fix scenario on DownloadBlocks() error reporting .. Patch Set 4: (3 comments) Thank you for hel

[kudu-CR] [tablet copy client-test] fix scenario on DownloadBlocks() error reporting

2020-11-16 Thread wangning (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16709 to look at the new patch set (#4). Change subject: [tablet_copy_client-test] fix scenario on DownloadBlocks() error reporting ..

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16730 ) Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1673

[kudu-CR] Revert "KUDU-3210 Add lock before verifying signature"

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16731 ) Change subject: Revert "KUDU-3210 Add lock before verifying signature" .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16730 ) Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .. Patch Set 2: Code-Review+2 (1 comment) Cool, thank you for fixing

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16730 ) Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16730 ) Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16730/

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16730 ) Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16730/

[kudu-CR] Revert "KUDU-3210 Add lock before verifying signature"

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16731 ) Change subject: Revert "KUDU-3210 Add lock before verifying signature" .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16730 to look at the new patch set (#2). Change subject: KUDU-3210 Add thread ID callback to OpenSSL init ...

[kudu-CR] Revert "KUDU-3210 Add lock before verifying signature"

2020-11-16 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16731 to look at the new patch set (#2). Change subject: Revert "KUDU-3210 Add lock before verifying signature" .

[kudu-CR] WIP KUDU-2612 C++ client transaction API

2020-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 ) Change subject: WIP KUDU-2612 C++ client transaction API .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16710/6/src/ku

[kudu-CR] WIP KUDU-2612 C++ client transaction API

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 ) Change subject: WIP KUDU-2612 C++ client transaction API .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16710/6/src/

[kudu-CR] [test] fix tablet copy client-test not work for multi-thread DownloadBlocks status collect

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16709 ) Change subject: [test] fix tablet_copy_client-test not work for multi-thread DownloadBlocks status collect .. Patch Set 3: Code-Review

[kudu-CR] KUDU-3210 Add thread ID callback to OpenSSL init

2020-11-16 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16730 to review the following change. Change subject: KUDU-3210 Add thread ID callback to OpenSSL init .

[kudu-CR] Revert "KUDU-3210 Add lock before verifying signature"

2020-11-16 Thread Attila Bukor (Code Review)
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/16731 to review the following change. Change subject: Revert "KUDU-3210 Add lock before verifying signature" ...

[kudu-CR] WIP KUDU-2612 keep-alive tracking for transactions

2020-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16729 ) Change subject: WIP KUDU-2612 keep-alive tracking for transactions .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/167

[kudu-CR] WIP KUDU-2612 C++ client transaction API

2020-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 ) Change subject: WIP KUDU-2612 C++ client transaction API .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c

[kudu-CR] [dist test] Ship security libraries to dist test

2020-11-16 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16716 ) Change subject: [dist_test] Ship security libraries to dist_test .. [dist_test] Ship security libraries to dist_test This patch

[kudu-CR] [dist test] Ship security libraries to dist test

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16716 ) Change subject: [dist_test] Ship security libraries to dist_test .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloude

[kudu-CR] [dist test] Ship security libraries to dist test

2020-11-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16716 ) Change subject: [dist_test] Ship security libraries to dist_test .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] WIP KUDU-2612 keep-alive tracking for transactions

2020-11-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16729 Change subject: WIP KUDU-2612 keep-alive tracking for transactions .. WIP KUDU-2612 keep-alive tracking for transactions This patch int

[kudu-CR] [KUDU-3214] Parallelize DownloadWAL in tablet copy operations

2020-11-16 Thread wangning (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16726 to look at the new patch set (#2). Change subject: [KUDU-3214] Parallelize DownloadWAL in tablet copy operations ..

[kudu-CR] [KUDU-3214] Parallelize DownloadWAL in tablet copy operations

2020-11-16 Thread wangning (Code Review)
wangning has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16726 Change subject: [KUDU-3214] Parallelize DownloadWAL in tablet copy operations .. [KUDU-3214] Parallelize DownloadWAL in tablet copy operation