[kudu-CR] [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact

2022-11-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has restored this change. ( http://gerrit.cloudera.org:8080/18503 ) Change subject: [KUDU-3367][compaction] Fix delta file with full of delete op can not be schedule to compact .. Restored -- To view, visit http://

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 ) Change subject: [metrics] Expose Prometheus Metrics in Kudu .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/19133/11/

[kudu-CR] KUDU-3326 [master] add improvement on interpreting the 'reserve seconds' field for DeleteRPC

2022-11-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19047 ) Change subject: KUDU-3326 [master] add improvement on interpreting the 'reserve_seconds' field for DeleteRPC .. Patch Set 14: Code-Revi

[kudu-CR] [Client] Add request id to trace the whole query process

2022-11-08 Thread Wang Xixu (Code Review)
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/18846 ) Change subject: [Client] Add request id to trace the whole query process .. Patch Set 19: (7 comments) > Patch Set 19: > > (1 comment) h

[kudu-CR] [Client] Add request id to trace the whole query process

2022-11-08 Thread Wang Xixu (Code Review)
Hello Mahesh Reddy, Tidy Bot, Jian Zhang, Yuqi Du, Yingchun Lai, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18846 to look at the new patch set (#20). Change subject: [Client] Add request id to trace the who

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 ) Change subject: [metrics] Expose Prometheus Metrics in Kudu .. Patch Set 11: > Patch Set 10: > > > Uploaded patch set 10. > > There are

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new patch set (#11) to the change originally created by Khazar Mammadli. ( http://gerrit.cloudera.org:8080/19133 ) Change subject: [metrics] Expose Prometheus Metrics in Kudu .. [metrics] Expose Prome

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 ) Change subject: [metrics] Expose Prometheus Metrics in Kudu .. Patch Set 10: > Uploaded patch set 10. There are build failures in PS1

[kudu-CR] jwt: add test for fetching JWKS via URL

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18468 ) Change subject: jwt: add test for fetching JWKS via URL .. Patch Set 2: > Uploaded patch set 8. Many JWT tests failed, and LINT and I

[kudu-CR] util: pull jwt code from Impala

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 ) Change subject: util: pull jwt code from Impala .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/18467/10/src/kudu/u

[kudu-CR] util: pull jwt code from Impala

2022-11-08 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 ) Change subject: util: pull jwt code from Impala .. Patch Set 10: (2 comments) Overall looks good to me. Only two minor comments. http:

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Attila Bukor (Code Review)
Attila Bukor has uploaded a new patch set (#10) to the change originally created by Khazar Mammadli. ( http://gerrit.cloudera.org:8080/19133 ) Change subject: [metrics] Expose Prometheus Metrics in Kudu .. [metrics] Expose Prome

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19187 ) Change subject: [python] Make clang_tidy work with python 3.6.9 .. [python] Make clang_tidy work with python 3.6.9 On my syste

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 ) Change subject: [python] Make clang_tidy work with python 3.6.9 .. Patch Set 5: Verified+1 unrelated test failure in TabletCopyClient

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [python] Make clang_tidy work with python 3.6.9 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/19187 To unsubscribe,

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 ) Change subject: [python] Make clang_tidy work with python 3.6.9 .. Patch Set 5: Code-Review+2 > Patch Set 5: > > > There are still some

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 ) Change subject: [python] Make clang_tidy work with python 3.6.9 .. Patch Set 5: > There are still some extra characters in the commit

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 ) Change subject: [python] Make clang_tidy work with python 3.6.9 .. Patch Set 5: Code-Review-2 There are still some extra characters in

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19187 ) Change subject: [python] Make clang_tidy work with python 3.6.9 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] [python] Make clang tidy work with python 3.6.9

2022-11-08 Thread Code Review
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19187 to look at the new patch set (#5). Change subject: [python] Make clang_tidy work with python 3.6.9

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Khazar Mammadli (Code Review)
Khazar Mammadli has posted comments on this change. ( http://gerrit.cloudera.org:8080/19133 ) Change subject: [metrics] Expose Prometheus Metrics in Kudu .. Patch Set 9: (14 comments) http://gerrit.cloudera.org:8080/#/c/19133

[kudu-CR] [metrics] Expose Prometheus Metrics in Kudu

2022-11-08 Thread Khazar Mammadli (Code Review)
Hello Tidy Bot, Zoltan Chovan, Alexey Serbin, Yingchun Lai, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19133 to look at the new patch set (#8). Change subject: [metrics] Expose Prometheus Metrics in Kudu

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-08 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 23: (5 comments) http://gerrit.clo

[kudu-CR] jwt: add test for fetching JWKS via URL

2022-11-08 Thread Zoltan Chovan (Code Review)
Zoltan Chovan has uploaded a new patch set (#8) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18468 ) Change subject: jwt: add test for fetching JWKS via URL .. jwt: add test for fetching JWK

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-08 Thread KeDeng (Code Review)
KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 23: Code-Review+1 It's looks fine to me.

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 23: Code-Review+1 -- To view, vis

[kudu-CR] [master] KUDU-3390 support auto rebalance tablet leaders across TServers

2022-11-08 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18454 ) Change subject: [master] KUDU-3390 support auto rebalance tablet leaders across TServers .. Patch Set 35: (12 comments) http://gerrit

[kudu-CR] util: pull jwt code from Impala

2022-11-08 Thread Zoltan Chovan (Code Review)
Zoltan Chovan has uploaded a new patch set (#10) to the change originally created by Andrew Wong. ( http://gerrit.cloudera.org:8080/18467 ) Change subject: util: pull jwt code from Impala .. util: pull jwt code from Impala Chan

[kudu-CR] util: pull jwt code from Impala

2022-11-08 Thread Zoltan Chovan (Code Review)
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18467 ) Change subject: util: pull jwt code from Impala .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18467/2/src/kudu/uti

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-08 Thread Yuqi Du (Code Review)
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18877 ) Change subject: [client] Fix a kudu c++ client bug when using replica_selection policy .. Patch Set 23: (9 comments) Glad to receive your

[kudu-CR] [client] Fix a kudu c++ client bug when using replica selection policy

2022-11-08 Thread Yuqi Du (Code Review)
Hello Mahesh Reddy, Tidy Bot, Alexey Serbin, Yingchun Lai, Yifan Zhang, Kudu Jenkins, KeDeng, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18877 to look at the new patch set (#22). Change subject: [client] Fix a kudu c++ client bug when using replica_sel