[kudu-CR] build: Move fake XML file generation to run-test.sh

2018-01-16 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. ( http://gerrit.cloudera.org:8080/8984 ) Change subject: build: Move fake XML file generation to run-test.sh .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2018-01-09 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#14). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-14 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#12). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-13 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#11). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-13 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. ( http://gerrit.cloudera.org:8080/8757 ) Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files .. Patch Set 10: (9 comments)

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-13 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#10). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-13 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#9). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-13 Thread Edward Fancher (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#8). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-06 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#7). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-06 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#6). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-06 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#5). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-06 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#4). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-06 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#3). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-05 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8757 to look at the new patch set (#2). Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

[kudu-CR] KUDU-2216. Post process gtest generated xml to include the output from the *.txt files

2017-12-04 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8757 Change subject: KUDU-2216. Post process gtest generated xml to include the output from the *.txt files .. KUDU-2216. Post process

[kudu-CR] KUDU-2033 (part 2). Add test for Java client failover support.

2017-08-22 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 2). Add test for Java client failover support. .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2033 (part 2). Add test for Java client failover support.

2017-08-22 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7722 to look at the new patch set (#2). Change subject: KUDU-2033 (part 2). Add test for Java client failover support.

[kudu-CR] KUDU-2033 (part 2). Add test for Java client failover support.

2017-08-18 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/7722 Change subject: KUDU-2033 (part 2). Add test for Java client failover support. .. KUDU-2033 (part 2). Add test for Java client failover

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-15 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-08-08 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#8). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-31 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 6: (9 comments)

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-31 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#7). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-31 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#6). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-26 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 5: (22 comments)

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-26 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#5). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-21 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-21 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover .. Patch Set 4: (6 comments)

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-21 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#4). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

2017-07-21 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7456 to look at the new patch set (#3). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover

[kudu-CR] KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover.

2017-07-18 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new patch set (#2). Change subject: KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover. .. KUDU-2033 (part 1). Add write and stop/start in a loop to TestLeaderFailover.

[kudu-CR] KUDU-2033. Add a 'torture' scenario to verify Java client's behavior during fail-over

2017-07-18 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/7456 Change subject: KUDU-2033. Add a 'torture' scenario to verify Java client's behavior during fail-over .. KUDU-2033. Add a 'torture'

[kudu-CR] [net util] fix reporting getaddrinfo() error

2017-07-06 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: [net_util] fix reporting getaddrinfo() error .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7368 To unsubscribe, visit

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers

2017-06-29 Thread Edward Fancher (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#8). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers

2017-06-29 Thread Edward Fancher (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#7). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers

2017-06-29 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-1932. Run at least one tablet-level test against all block managers .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/7252/5//COMMIT_MSG

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-29 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-1932. Run at least one tablet-level test against all block managers. .. Patch Set 5: (10 comments)

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers

2017-06-29 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#6). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-28 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#4). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers.

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-28 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#3). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers.

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-21 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7252 to look at the new patch set (#2). Change subject: KUDU-1932. Run at least one tablet-level test against all block managers.

[kudu-CR] KUDU-1932. Run at least one tablet-level test against all block managers.

2017-06-21 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/7252 Change subject: KUDU-1932. Run at least one tablet-level test against all block managers. .. KUDU-1932. Run at least one tablet-level

[kudu-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/7141/10//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/7141/8//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#11). Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev()

[kudu-CR] KUDU-2004: Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-2004: Undefined behavior in TlsSocket::Writev() .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/7141/9/src/kudu/util/net/socket.h File

[kudu-CR] KUDU-2004: Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#10). Change subject: KUDU-2004: Undefined behavior in TlsSocket::Writev() ..

[kudu-CR] KUDU-2004: Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#9). Change subject: KUDU-2004: Undefined behavior in TlsSocket::Writev() ..

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/7141/4/src/kudu/security/tls_socket.cc File

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#8). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#7). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/7141/5/src/kudu/security/tls_socket.cc File

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#6). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7141/4/src/kudu/security/tls_socket.h File

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-12 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#5). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-09 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#3). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-09 Thread Edward Fancher (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7141 to look at the new patch set (#2). Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior

[kudu-CR] Undefined behavior in TlsSocket::Writev()

2017-06-09 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/7141 Change subject: Undefined behavior in TlsSocket::Writev() .. Undefined behavior in TlsSocket::Writev() TlsSocket::Writev() was

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-25 Thread Edward Fancher (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6976 to look at the new patch set (#4). Change subject: Fix flaky test TestRestartWithOrphanedReplicates ..

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 2: (3 comments)

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6976/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] Fix flaky test TestRestartWithOrphanedReplicates

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new patch set (#2). Change subject: Fix flaky test TestRestartWithOrphanedReplicates .. Fix flaky test TestRestartWithOrphanedReplicates Looks like the test was setting a fault injection flag

[kudu-CR] Fix flaky test

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has restored this change. Change subject: Fix flaky test .. Restored -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType:

[kudu-CR] Fix flaky test

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has abandoned this change. Change subject: Fix flaky test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType:

[kudu-CR] Fix flaky test

2017-05-24 Thread Edward Fancher (Code Review)
Edward Fancher has uploaded a new change for review. http://gerrit.cloudera.org:8080/6976 Change subject: Fix flaky test .. Fix flaky test Looks like the test was setting a fault injection flag before the setup which was