[kudu-CR] [tools] Add table scan tool

2019-01-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/12167

[kudu-CR] [tools] Add table scan tool

2019-01-29 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. [tools] Add table scan tool This commit adds a basic tool to scan rows from a

[kudu-CR] [tools] Add table scan tool

2019-01-29 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#20). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-29 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#19). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-29 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#18). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 17: (1 comment)

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#17). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 16: Yes, and I saw some reduplicate code in tool_action_perf.cc, I will do

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#16). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 15: (2 comments) One small thing and it's good to go! Thanks. This is a

[kudu-CR] [tools] Add table scan tool

2019-01-26 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#14). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-26 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#13). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-26 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#12). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-26 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 11: (20 comments)

[kudu-CR] [tools] Add table scan tool

2019-01-26 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#11). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-25 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 10: (2 comments)

[kudu-CR] [tools] Add table scan tool

2019-01-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 10: (25 comments) Thanks for changing the query language! I think it's

[kudu-CR] [tools] Add table scan tool

2019-01-19 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#10). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-19 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#9). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-19 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#8). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-19 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#7). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-19 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#6). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-19 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#5). Change subject: [tools] Add table scan tool ..

[kudu-CR] [tools] Add table scan tool

2019-01-12 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 4: > (5 comments) > > I left a few high-level comments, but at the top

[kudu-CR] [tools] Add table scan tool

2019-01-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 4: (1 comment)

[kudu-CR] [tools] Add table scan tool

2019-01-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 ) Change subject: [tools] Add table scan tool .. Patch Set 4: (5 comments) I left a few high-level comments, but at the top level:

[kudu-CR] [tools] Add table scan tool

2019-01-07 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#4). Change subject: [tools] Add table scan tool .. [tools] Add table

[kudu-CR] [tools] Add table scan tool

2019-01-07 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#3). Change subject: [tools] Add table scan tool .. [tools] Add table

[kudu-CR] [tools] Add table scan tool

2019-01-05 Thread Yingchun Lai (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12167 to look at the new patch set (#2). Change subject: [tools] Add table scan tool .. [tools] Add table scan tool

[kudu-CR] [tools] Add table scan tool

2019-01-05 Thread Yingchun Lai (Code Review)
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12167 Change subject: [tools] Add table scan tool .. [tools] Add table scan tool This adds a basic tool to scan rows from a table, several