[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 2: Verified+1 The flake is KUDU-2564. -- To view, visit

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: Enable tcmalloc heap sampling by default .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/12933 To unsubscribe, visit

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Enable tcmalloc heap sampling by default This enables tcmalloc

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 1: (1 comment) > I vaguely remember this coming up before. Did

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 1: (1 comment) I vaguely remember this coming up before. Did we

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Mitch Barnett, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12933 to look at the new patch set (#2). Change subject: Enable tcmalloc heap sampling by default

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12933 ) Change subject: Enable tcmalloc heap sampling by default .. Patch Set 1: Code-Review+1 sgtm. We've had this on on a test cluster for

[kudu-CR] Enable tcmalloc heap sampling by default

2019-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12933 Change subject: Enable tcmalloc heap sampling by default .. Enable tcmalloc heap sampling by default This enables tcmalloc heap