[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. KUDU-2364 Add extra check in ksck for tserver ID ksck did

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 14: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#14). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 13: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 13: > Patch Set 12: Code-Review+2 > > Thanks for

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 12: Code-Review+2 Thanks for accepting the scope creep

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 12: (1 comment) I changed the tests to check for

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#12). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 11: Code-Review+1 (1 comment) Will probably wants to

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 11: (8 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#11). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 10: (8 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 10: (16 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#10). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 9: (16 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#9). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 8: (1 comment)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-28 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#8). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 7: (8 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 7: (3 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 7: (10 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-26 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#6). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-26 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#5). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-26 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#4). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-26 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 3: > Patch Set 2: > > (3 comments) > > This also needs a

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-26 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#3). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 2: (3 comments) This also needs a test, maybe using the

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-24 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 2: > Patch Set 2: > > (1 comment) Actually I thought

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-23 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9787 to look at the new patch set (#2). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-23 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9787 to review the following change. Change subject: KUDU-2364 Add extra check in ksck for tserver ID