[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-29 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. KUDU-2411: Add OS/Arch detection to binary extract OS/Arch

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 7: Code-Review+2 Looks good - thanks Brian! -- To

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-28 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12141 to look at the new patch set (#6). Change subject: KUDU-2411: Add OS/Arch detection to binary extract

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-28 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 5: (3 comments) Updated with the specified changes.

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 5: (3 comments) Looking good, I just have some minor

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 5: > Patch Set 5: > > One new failure: > > >

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-24 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 5: One new failure:

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 4: > Patch Set 4: > > Jenkins appears to fail on

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-24 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 4: Jenkins appears to fail on unrelated Python code:

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-24 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12141 to look at the new patch set (#4). Change subject: KUDU-2411: Add OS/Arch detection to binary extract

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-04 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-04 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12141 to look at the new patch set (#3). Change subject: KUDU-2411: Add OS/Arch detection to binary extract

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-03 Thread Brian McDevitt (Code Review)
Hello Mike Percy, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12141 to look at the new patch set (#2). Change subject: KUDU-2411: Add OS/Arch detection to binary extract

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: > I will cleanup these items and rebase onto Mike's

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-03 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: (1 comment) I will cleanup these items and

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-03 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: (3 comments) I think you will need to rebase onto

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: > I was thinking we could create new classloader for

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-02 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: It is not fully tested yet. We still need to add

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2019-01-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: Code-Review+1 (1 comment) Looks good. Is it tested

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

2018-12-31 Thread Brian McDevitt (Code Review)
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12141 Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. KUDU-2411: Add OS/Arch detection to binary extract OS/Arch