[kudu-CR] open FS layout in presence of disk failure

2017-08-24 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: open FS layout in presence of disk failure .. open FS layout in presence of disk failure Currently, if a Kudu server starts up with a failed disk, the

[kudu-CR] open FS layout in presence of disk failure

2017-08-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-24 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: I retriggered the build -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Failure seems to be a bunch of clock sync errors in DEBUG mode. -- To view, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/block_manager_util.cc File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#6). Change subject: open FS layout in presence of disk failure

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/log_block_manager-test.cc File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7784/5/src/kudu/fs/block_manager_util.cc File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (16 comments) http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Message: PS3, Line 20:

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#5). Change subject: open FS layout in presence of disk failure

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: Code-Review+1 Don't have anything to add to David/Mike's comments. -- To view, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/3/src/kudu/fs/fs_manager-test.cc File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (5 comments) A quick first pass http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (3 comments) couple other minor nits, overall lgtm

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.cc File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#4). Change subject: open FS layout in presence of disk failure .. open FS layout in

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (12 comments) http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Message: PS3, Line 15:

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (6 comments) I'm still looking through this patch but so far I only have nits

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Message: PS3, Line 15: all

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 3: Just rebased. -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 1: (1 comment) Ah, it seems the issue was with some error-handling wiring that I changed. Should be good

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7784 to look at the new patch set (#2). Change subject: open FS layout in presence of disk failure .. open FS layout in

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 1: looking into the jenkins failure. -- To view, visit http://gerrit.cloudera.org:8080/7784 To

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/1/src/kudu/fs/data_dirs.cc File