[kudu-CR] rowset metadata: cache min/max encoded keys

2018-04-03 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#9). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-04-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 8: (2 comments) > Patch Set 8: > > (5 comments)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-04-03 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#8). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-04-03 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 8: (5 comments)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-04-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 7: (5 comments)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 7: (1 comment)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-30 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#7). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 6: (1 comment)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 5: Rebased. Failures were flakes that Alexey fixed in

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#5). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 3: Added some units and fixed a typo. -- To view, visit

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#4). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#3). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-28 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 3: (1 comment)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 2: I think we could pretty easily benchmark this by loading a

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 2: (1 comment)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-02-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 2: before we spent too much time with this path I think

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-02-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#2). Change subject: rowset_metadata: cache min/max encoded keys .. rowset_metadata:

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-02-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9372 Change subject: rowset_metadata: cache min/max encoded keys .. rowset_metadata: cache min/max encoded keys This patch adds a new flag