[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4586 to look at the new patch set (#4). Change subject: [docs] Python updates for development page .. [docs] Python

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

2016-11-10 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1638 - [python] Add Alter Table Support .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4823/7/python/kudu/schema.pyx File

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5031/1/src/kudu/common/common.proto File

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4586 to look at the new patch set (#6). Change subject: [docs] Python updates for development page .. [docs] Python

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 6: Code-Review+2 (1 comment) Feel free to address the nit, +2 yourself and push

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4586 to look at the new patch set (#5). Change subject: [docs] Python updates for development page .. [docs] Python

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has submitted this change and it was merged. Change subject: [docs] Python updates for development page .. [docs] Python updates for development page Updates to the Developing Applications with Kudu page for

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread Jordan Birdsell (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4586 to look at the new patch set (#7). Change subject: [docs] Python updates for development page

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup .. Patch Set 3: (2 comments)

[kudu-CR] macOS: fix shared ptr.h ifdef

2016-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: macOS: fix shared_ptr.h ifdef .. Patch Set 1: Looks good, but on Slack you said Kudu largely builds on macOS even without this fix (only the build in

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4586 To unsubscribe, visit

[kudu-CR] WIP: [c++client] fix for KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5038 Change subject: WIP: [c++client] fix for KUDU-1743 .. WIP: [c++client] fix for KUDU-1743 Cannot provide reproducible test case scenario

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5048 Change subject: [c++client] fixed KUDU-1743 .. [c++client] fixed KUDU-1743 KUDU-1743: GetPendingErrors() not returning all errors after

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++client] fixed KUDU-1743 .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/5048/1/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc:

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1638 - [python] Add Alter Table Support .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4823 To unsubscribe, visit

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5048 to look at the new patch set (#4). Change subject: [c++client] fixed KUDU-1743 .. [c++client] fixed KUDU-1743

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++client] fixed KUDU-1743 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5048/3/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc:

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++client] fixed KUDU-1743 .. Patch Set 1: (15 comments) http://gerrit.cloudera.org:8080/#/c/5048/1/src/kudu/client/batcher.cc File

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5048 to look at the new patch set (#2). Change subject: [c++client] fixed KUDU-1743 .. [c++client] fixed KUDU-1743

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [c++client] fixed KUDU-1743 .. [c++client] fixed KUDU-1743 KUDU-1743: GetPendingErrors() not returning all errors after Flush() A race has been

[kudu-CR] Reject CREATE TABLE ops with even replication factor

2016-11-10 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor .. Patch Set 5: Code-Review+1 (1 comment) LGTM, one nit.

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5048 to look at the new patch set (#3). Change subject: [c++client] fixed KUDU-1743 .. [c++client] fixed KUDU-1743

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

2016-11-10 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4823 to look at the new patch set (#8). Change subject: KUDU-1638 - [python] Add Alter Table Support .. KUDU-1638 -

[kudu-CR] WIP: [c++client] fix for KUDU-1743

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: WIP: [c++client] fix for KUDU-1743 .. Abandoned Moved into http://gerrit.cloudera.org:8080/5048 -- To view, visit http://gerrit.cloudera.org:8080/5038 To unsubscribe,

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++client] fixed KUDU-1743 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5048 To unsubscribe, visit

[kudu-CR] [c++client] fixed KUDU-1743

2016-11-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++client] fixed KUDU-1743 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5048/3/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc:

[kudu-CR] scoped cleanup: Use std::function instead of template

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: scoped_cleanup: Use std::function instead of template .. Patch Set 1: I don't think this is a good idea, because it defeats inlining -- To view, visit

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-180. Fix handling of defaults when creating tables .. KUDU-180. Fix handling of defaults when creating tables This fixes an issue that was

[kudu-CR] sasl: don't use the 'client mech list' SASL option

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: sasl: don't use the 'client_mech_list' SASL option .. sasl: don't use the 'client_mech_list' SASL option This option allows the client to specify which

[kudu-CR] TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup

2016-11-10 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5044 to review the following change. Change subject: TSTabletManager: Replace TransitionInProgressDeleter with ScopedCleanup

[kudu-CR] scoped cleanup: Use std::function instead of template

2016-11-10 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5043 to review the following change. Change subject: scoped_cleanup: Use std::function instead of template ..

[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession

2016-11-10 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5041 to review the following change. Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession ..

[kudu-CR] tablet copy: Rename tablet copy session source files

2016-11-10 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5042 to review the following change. Change subject: tablet copy: Rename tablet copy session source files .. tablet copy:

[kudu-CR] tablet copy: Make the StartTabletCopy() RPC async

2016-11-10 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5045 to review the following change. Change subject: tablet copy: Make the StartTabletCopy() RPC async .. tablet copy:

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 1: (4 comments)

[kudu-CR] python: check status result when setting row contents

2016-11-10 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5018 to look at the new patch set (#2). Change subject: python: check status result when setting row contents ..

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5031 To unsubscribe,

[kudu-CR] tablet copy: Make the StartTabletCopy() RPC async

2016-11-10 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new patch set (#2). Change subject: tablet copy: Make the StartTabletCopy() RPC async .. tablet copy: Make the StartTabletCopy() RPC async This patch changes tablet copy to execute on the open_tablet

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5031 to look at the new patch set (#2). Change subject: KUDU-180. Fix handling of defaults when creating tables ..

[kudu-CR] sasl: don't use the 'client mech list' SASL option

2016-11-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: sasl: don't use the 'client_mech_list' SASL option .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5039 To unsubscribe, visit

[kudu-CR] sasl: disable error messages assertions on el6

2016-11-10 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5046 to review the following change. Change subject: sasl: disable error messages assertions on el6 .. sasl: disable error

[kudu-CR] sasl: disable error messages assertions on el6

2016-11-10 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: sasl: disable error messages assertions on el6 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5046 To unsubscribe, visit

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

2016-11-10 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1638 - [python] Add Alter Table Support .. Patch Set 7: Oops. Sorry, not by my computer right now, will be home in about 2 hours. will push it then --

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5031 To

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .. Patch Set 2: Do we still think this is a useful change? -- To view, visit

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add Reinserts to tablet_history_gc-itest .. Patch Set 8: (1 comment)

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Workaround test failures running with MIT krb5 1.10 .. Workaround test failures running with MIT krb5 1.10 This fixes a variety of issues seen when

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4930 To unsubscribe, visit

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/7/CMakeLists.txt File

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4988 To unsubscribe,

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 8: Verified+1 Unrelated flake -- To view, visit http://gerrit.cloudera.org:8080/4996 To unsubscribe, visit

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-10 Thread Maxim Smyatkin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5007 to look at the new patch set (#2). Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup

[kudu-CR] KUDU-1634. TS and master should delete tmp metadata files on startup

2016-11-10 Thread Maxim Smyatkin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5007 to look at the new patch set (#3). Change subject: KUDU-1634. TS and master should delete tmp metadata files on startup

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/7/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] [java] Fix bug in RegexpKuduOperationsProducer

2016-11-10 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [java] Fix bug in RegexpKuduOperationsProducer .. [java] Fix bug in RegexpKuduOperationsProducer I've been experimenting with using FindBugs. It's not

[kudu-CR] [java] Fix bug in RegexpKuduOperationsProducer

2016-11-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [java] Fix bug in RegexpKuduOperationsProducer .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5032 To unsubscribe, visit

[kudu-CR] [java] Fix bug in RegexpKuduOperationsProducer

2016-11-10 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5032 Change subject: [java] Fix bug in RegexpKuduOperationsProducer .. [java] Fix bug in RegexpKuduOperationsProducer I've been

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-10 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#11). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-100 enable the ability to use RLE for the int64 type

2016-11-10 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4946 to look at the new patch set (#5). Change subject: KUDU-100 enable the ability to use RLE for the int64 type ..

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Consolidate Row/CompactionInputRow printing on compaction We are duplicating row

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

2016-11-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1638 - [python] Add Alter Table Support .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/4823/7/python/kudu/schema.pyx File

[kudu-CR] [docs] Python updates for development page

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4586/3/docs/developing.adoc File

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 1: (1 comment)

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Rename LogicalClock::NowForMetrics() to GetCurrentTime() This renames this method and