[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#31). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 30: (14 comments) I've added TODOs to expand the error handling

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#32). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#35). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] python: upgrade pip when building client and restore old workarounds

2017-10-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8406 ) Change subject: python: upgrade pip when building client and restore old workarounds .. python: upgrade pip when building

[kudu-CR] python: upgrade pip when building client and restore old workarounds

2017-10-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8406 ) Change subject: python: upgrade pip when building client and restore old workarounds .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 ) Change subject: [java client] improve AsyncKuduScanner logging .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 31: (1 comment)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#33). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#34). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Alexey Serbin, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7053 to look at the new patch set (#36). Change subject: KUDU-2191 (2/n): Hive Metastore client

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 30: (1 comment)

[kudu-CR] [webui] Add templates for tserver webui

2017-10-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8307 ) Change subject: [webui] Add templates for tserver webui .. Patch Set 7: (6 comments)

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 9: (1 comment)

[kudu-CR] Add a macro form for ScopedCleanup

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8416 ) Change subject: Add a macro form for ScopedCleanup .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2205. Improve error message for failed globs

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8415 ) Change subject: KUDU-2205. Improve error message for failed globs .. KUDU-2205. Improve error message for failed globs This

[kudu-CR] Add a macro form for ScopedCleanup

2017-10-30 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8416 to review the following change. Change subject: Add a macro form for ScopedCleanup .. Add a macro form for

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 36: (1 comment)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 36: (1 comment)

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 9: (1 comment)

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8422 to look at the new patch set (#2). Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8422 to look at the new patch set (#4). Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

[kudu-CR] cfile set: make FindRow more robust to errors

2017-10-30 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8423 Change subject: cfile_set: make FindRow more robust to errors .. cfile_set: make FindRow more robust to errors Previously, FindRow()

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8422 to look at the new patch set (#3). Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 9: Code-Review+2 (1 comment)

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8420 Change subject: Add a benchmark test for tablet deletion .. Add a benchmark test for tablet deletion Commit 15f3f9b2f optimizes the

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8420 ) Change subject: Add a benchmark test for tablet deletion .. Patch Set 2: (10 comments)

[kudu-CR] KUDU-2200: provide better diagnostics when connecting to a subset of masters

2017-10-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8393 to look at the new patch set (#2). Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters

[kudu-CR] KUDU-2200: provide better diagnostics when connecting to a subset of masters

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 ) Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters .. Patch Set 2: (6 comments)

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8420 ) Change subject: Add a benchmark test for tablet deletion .. Patch Set 2: (2 comments)

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-30 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8382 to look at the new patch set (#4). Change subject: [java client] improve AsyncKuduScanner logging

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8420 ) Change subject: Add a benchmark test for tablet deletion .. Patch Set 1: (10 comments)

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8422 Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode .. [mini-cluster] allow 18-bit PID in LOOPBACK bind mode This

[kudu-CR] [mini-cluster] allow 18-bit PID in LOOPBACK bind mode

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8422 ) Change subject: [mini-cluster] allow 18-bit PID in LOOPBACK bind mode .. Patch Set 1: (1 comment)

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8420 ) Change subject: Add a benchmark test for tablet deletion .. Patch Set 2: (2 comments)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-30 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#21). Change subject: mvcc: allow tablet shutdown without completing txs

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 21: (26 comments)

[kudu-CR] KUDU-2200: provide better diagnostics when connecting to a subset of masters

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 ) Change subject: KUDU-2200: provide better diagnostics when connecting to a subset of masters .. Patch Set 2: Code-Review+1 (3 comments)

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 29: (1 comment)

[kudu-CR] KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8345 ) Change subject: KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager .. Patch Set 1: > Moving to an overall better lock

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8420 ) Change subject: Add a benchmark test for tablet deletion .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8345 ) Change subject: KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Add a macro form for ScopedCleanup

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8416 ) Change subject: Add a macro form for ScopedCleanup .. Add a macro form for ScopedCleanup This adds a new macro SCOPED_CLEANUP({

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-30 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: mvcc: allow tablet shutdown without completing txs .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/7439 To

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8420 to look at the new patch set (#2). Change subject: Add a benchmark test for tablet deletion .. Add a

[kudu-CR] KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

2017-10-30 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8345 to look at the new patch set (#2). Change subject: KUDU-2193 (part 1): switch to a waiting mutex in TSTabletManager

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 ) Change subject: [java client] improve AsyncKuduScanner logging .. Patch Set 3: (1 comment)

[kudu-CR] Add a benchmark test for tablet deletion

2017-10-30 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8420 to look at the new patch set (#3). Change subject: Add a benchmark test for tablet deletion .. Add a

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 21: ...flake seemed unrelated... :) -- To view, visit

[kudu-CR] Add a macro form for ScopedCleanup

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8416 ) Change subject: Add a macro form for ScopedCleanup .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] WIP: KUDU-2200: provide better diagnostics when connecting to a subset of masters

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8393 ) Change subject: WIP: KUDU-2200: provide better diagnostics when connecting to a subset of masters .. Patch Set 1: (4 comments)

[kudu-CR] [webui] Add templates for tserver webui

2017-10-30 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8307 to look at the new patch set (#8). Change subject: [webui] Add templates for tserver webui

[kudu-CR] KUDU-2191 (2/n): Hive Metastore client

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7053 ) Change subject: KUDU-2191 (2/n): Hive Metastore client .. Patch Set 36: OK I think this is ready to review again. Sorry for the churn.

[kudu-CR] mini-cluster: support parallel multi-master clusters

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8280 ) Change subject: mini-cluster: support parallel multi-master clusters .. Patch Set 2: I got some time to bang on this on a recent flight,

[kudu-CR] mini-cluster: support parallel multi-master clusters

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8280 to look at the new patch set (#2). Change subject: mini-cluster: support parallel multi-master clusters

[kudu-CR] [build] fix OPENSSL ROOT DIR override on RH/CentOS

2017-10-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8407 ) Change subject: [build] fix OPENSSL_ROOT_DIR override on RH/CentOS .. [build] fix OPENSSL_ROOT_DIR override on RH/CentOS Due

[kudu-CR] mini-cluster: support parallel multi-master clusters

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8280 ) Change subject: mini-cluster: support parallel multi-master clusters .. Patch Set 2: It's coming back to me now; at least one of the

[kudu-CR] KUDU-2205. Improve error message for failed globs

2017-10-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8415 ) Change subject: KUDU-2205. Improve error message for failed globs .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8304 to look at the new patch set (#7). Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 6: -Verified (1 comment)

[kudu-CR] Update auth token validity seconds description

2017-10-30 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8413 to review the following change. Change subject: Update auth_token_validity_seconds description .. Update

[kudu-CR] [build] fix OPENSSL ROOT DIR override on RH/CentOS

2017-10-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8407 ) Change subject: [build] fix OPENSSL_ROOT_DIR override on RH/CentOS .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2205. Improve error message for failed globs

2017-10-30 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8415 to review the following change. Change subject: KUDU-2205. Improve error message for failed globs .. KUDU-2205.

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8304 to look at the new patch set (#8). Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8304 to look at the new patch set (#9). Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster

[kudu-CR] KUDU-2191 (3/n): Add mini HMS option to external mini cluster

2017-10-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8304 ) Change subject: KUDU-2191 (3/n): Add mini HMS option to external mini cluster .. Patch Set 9: This is ready for review again. Sorry for