[kudu-CR] KUDU-2012 Kudu Flume sink auth support

2018-09-11 Thread Ferenc Szabo (Code Review)
Hello Attila Bukor, Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11334 to look at the new patch set (#3). Change subject: KUDU-2012 Kudu Flume sink auth support

[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

2018-09-11 Thread Ferenc Szabo (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11391 to look at the new patch set (#4). Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-11 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11417 ) Change subject: [blog] Data Pipelines Simplified with Kudu .. Patch Set 1: Verified+1 (1 comment) verified that it's rendering

[kudu-CR] KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer.

2018-09-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11391 ) Change subject: KUDU-1882 Configuration improvements for Flume Kudu Sink regexp operations producer. .. Patch Set 4: Code-Review+1 --

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-11 Thread Jordan Birdsell (Code Review)
Hello Will Berkeley, Alexey Serbin, Attila Bukor, Todd Lipcon, Brock Noland, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11417 to look at the new patch set (#2). Change subject: [blog] Data Pipelines Simplified with Kudu

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-11 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11417 ) Change subject: [blog] Data Pipelines Simplified with Kudu .. Patch Set 2: (3 comments)

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-11 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11415 to look at the new patch set (#4). Change subject: move KUDU_NO_EXPORT attribute on methods ..

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-11 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11142 to look at the new patch set (#3). Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops ..

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-11 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11142 to look at the new patch set (#5). Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops ..

[kudu-CR] KUDU-2463 pt 2: adjust MVCC on Raft no-op

2018-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11427 Change subject: KUDU-2463 pt 2: adjust MVCC on Raft no-op .. KUDU-2463 pt 2: adjust MVCC on Raft no-op Based on the same rationale as

[kudu-CR] KUDU-2463 pt 3: don't scan if MVCC hasn't moved

2018-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11428 Change subject: KUDU-2463 pt 3: don't scan if MVCC hasn't moved .. KUDU-2463 pt 3: don't scan if MVCC hasn't moved In cases when a

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 8: (7 comments) Thank you for the

[kudu-CR] [KUDU-2521] Java Implementation for BloomFilter

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11333 ) Change subject: [KUDU-2521] Java Implementation for BloomFilter .. Patch Set 5: (18 comments)

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 10: Code-Review+1 Will should +2 since there

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 7: Code-Review+2 Carrying through Hao's +2

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: This is still failing on my

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Dan Burkert (Code Review)
Hello Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11413 to look at the new patch set (#4). Change subject: HMS integration: provide Java API to override owner during table create

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. HMS integration: set table owner field in HMS

[kudu-CR](gh-pages) Blogpost describing index skip scan optimization.

2018-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11263 ) Change subject: Blogpost describing index skip scan optimization. .. Patch Set 6: (14 comments) Almost all nits pretty much. Looking

[kudu-CR] Implement BloomFilter Predicate in server side.

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11100 ) Change subject: Implement BloomFilter Predicate in server side. .. Patch Set 5: (9 comments)

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-11 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11142 to look at the new patch set (#4). Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops ..

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11207 ) Change subject: [location_awareness] replica selection honors placement policy .. Patch Set 7: (1 comment)

[kudu-CR] [location awareness] replica selection honors placement policy

2018-09-11 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11207 to look at the new patch set (#10). Change subject: [location_awareness] replica selection honors placement policy

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (1 comment)

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 ) Change subject: move KUDU_NO_EXPORT attribute on methods .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (2 comments)

[kudu-CR] [catalog manager] optimization in AsyncAddReplicaTask

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11429 Change subject: [catalog_manager] optimization in AsyncAddReplicaTask .. [catalog_manager] optimization in AsyncAddReplicaTask

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11415 ) Change subject: move KUDU_NO_EXPORT attribute on methods .. move KUDU_NO_EXPORT attribute on methods The original location was

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. Patch Set 3: For simplicity of the patch, I've stripped away the

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 1: (7 comments)

[kudu-CR] [catalog manager] optimization in AsyncAddReplicaTask

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11429 ) Change subject: [catalog_manager] optimization in AsyncAddReplicaTask .. Patch Set 1: (2 comments)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (2 comments)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (1 comment)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (1 comment)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2463 pt 1: adjust MVCC when replaying no-ops

2018-09-11 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11142 ) Change subject: KUDU-2463 pt 1: adjust MVCC when replaying no-ops .. Patch Set 5: @mpercy Currently dist testing some seemingly

[kudu-CR] Add helper macro for tool invocations

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11411 ) Change subject: Add helper macro for tool invocations .. Patch Set 3: (1 comment)

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-11 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11417 ) Change subject: [blog] Data Pipelines Simplified with Kudu .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] build: add option to ignore test failures

2018-09-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 ) Change subject: build: add option to ignore test failures .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [blog] Data Pipelines Simplified with Kudu

2018-09-11 Thread Attila Bukor (Code Review)
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11417 ) Change subject: [blog] Data Pipelines Simplified with Kudu .. [blog] Data Pipelines Simplified with Kudu Change-Id:

[kudu-CR] KUDU-2012 Kudu Flume sink auth support

2018-09-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11334 ) Change subject: KUDU-2012 Kudu Flume sink auth support .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [catalog manager] optimization in AsyncAddReplicaTask

2018-09-11 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11429 to look at the new patch set (#2). Change subject: [catalog_manager] optimization in AsyncAddReplicaTask

[kudu-CR] Add helper macro for tool invocations

2018-09-11 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11411 to look at the new patch set (#3). Change subject: Add helper macro for tool invocations

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-11 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings .. KUDU-2566: Enhance rowset tree pruning and

[kudu-CR] WIP: Breakout the Java MiniKuduCluster

2018-09-11 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11418 Change subject: WIP: Breakout the Java MiniKuduCluster .. WIP: Breakout the Java MiniKuduCluster This change will simplify using the

[kudu-CR] [docs] Add basic advice on setting block cache size

2018-09-11 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11420 Change subject: [docs] Add basic advice on setting block cache size .. [docs] Add basic advice on setting block cache size This adds a

[kudu-CR] KUDU-2566: Enhance rowset tree pruning and stop copying strings

2018-09-11 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11381 ) Change subject: KUDU-2566: Enhance rowset tree pruning and stop copying strings .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] move KUDU NO EXPORT attribute on methods

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11415 ) Change subject: move KUDU_NO_EXPORT attribute on methods .. Patch Set 3: Code-Review+2 LINT failure is legit. -- To view, visit

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 6: The LINT failure is related to the other

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 3: (3 comments)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 3: (2 comments) Not sure what

[kudu-CR] HMS integration: set table owner field in HMS table metadata

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11398 ) Change subject: HMS integration: set table owner field in HMS table metadata .. Patch Set 6: Code-Review+1 -- To view, visit

[kudu-CR] Remove unnecessary friendship

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11416 ) Change subject: Remove unnecessary friendship .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11416 To

[kudu-CR] Remove unnecessary friendship

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11416 ) Change subject: Remove unnecessary friendship .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11416

[kudu-CR] Remove unnecessary friendship

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11416 ) Change subject: Remove unnecessary friendship .. Remove unnecessary friendship This commit removes unnecessary friendship and

[kudu-CR] [master] fix compilation warning of DCHECK NOTNULL

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11421 Change subject: [master] fix compilation warning of DCHECK_NOTNULL .. [master] fix compilation warning of DCHECK_NOTNULL Fixed

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-11 Thread Fengling Wang (Code Review)
Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11422 ) Change subject: [location_awareness] Add location info in ksck report .. Patch Set 1: The expected output is

[kudu-CR] [master] fix compilation warning of DCHECK NOTNULL

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11421 ) Change subject: [master] fix compilation warning of DCHECK_NOTNULL .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [location awareness] Add location info in ksck report

2018-09-11 Thread Fengling Wang (Code Review)
Fengling Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11422 Change subject: [location_awareness] Add location info in ksck report .. [location_awareness] Add location info in ksck report This

[kudu-CR] [master] fix compilation warning of DCHECK NOTNULL

2018-09-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11421 ) Change subject: [master] fix compilation warning of DCHECK_NOTNULL .. [master] fix compilation warning of DCHECK_NOTNULL

[kudu-CR] [catalog manager] optimization in AsyncAddReplicaTask

2018-09-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11429 ) Change subject: [catalog_manager] optimization in AsyncAddReplicaTask .. Patch Set 1: (2 comments)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 3: (1 comment)

[kudu-CR] HMS integration: provide Java API to override owner during table create

2018-09-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11413 ) Change subject: HMS integration: provide Java API to override owner during table create .. Patch Set 3: (3 comments)