[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Alexey Serbin (Code Review)
Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13022 to look at the new patch set (#2). Change subject: [docs] updated master-related scenarios w.r.t. CM roles

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13024 to look at the new patch set (#5). Change subject: [ksck] Make ksck tool more concurrent

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13064 Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1: Introduce CRoaring Introduce CRoaring and do a simple memory and disk

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12588 to look at the new patch set (#4). Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1:

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
helifu has abandoned this change. ( http://gerrit.cloudera.org:8080/13064 ) Change subject: KUDU-2038-p1: Introduce CRoaring .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13064 To unsubscribe, visit

[kudu-CR] KUDU-2038-p1: Introduce CRoaring

2019-04-18 Thread helifu (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12588 to look at the new patch set (#5). Change subject: KUDU-2038-p1: Introduce CRoaring .. KUDU-2038-p1:

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (1 comment)

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: Code-Review+2 (1 comment) LGTM but I second

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (3 comments)

[kudu-CR] [master] modernize code w.r.t. virtual/override keywords

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13066 Change subject: [master] modernize code w.r.t. virtual/override keywords .. [master] modernize code w.r.t. virtual/override keywords

[kudu-CR] Bump Sentry version

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13059/2/thirdparty/build-thirdparty.sh

[kudu-CR] Bump Sentry version

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: Bump Sentry version .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13059 To unsubscribe, visit

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13024 to look at the new patch set (#6). Change subject: [ksck] Make ksck tool more concurrent

[kudu-CR] Bump Sentry version

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/13059/1//COMMIT_MSG Commit Message:

[kudu-CR] Bump Sentry version

2019-04-18 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13059 to look at the new patch set (#2). Change subject: Bump Sentry version ..

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (3 comments) High level pass so far, so just

[kudu-CR] Bump Sentry version

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: Code-Review+1 (1 comment)

[kudu-CR] [master] modernize code w.r.t. virtual/override keywords

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13066 ) Change subject: [master] modernize code w.r.t. virtual/override keywords .. Patch Set 1: Verified+1 Unrelated flake in

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: > Patch Set 1: Code-Review+2 > > Hao and I had

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (2 comments)

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. [catalog_manager] simplify lifecycle of authz

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: (1 comment) > Patch Set 1: Code-Review+2 > >

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 6: (3 comments)

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: (3 comments)

[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: [docs] updated master-related scenarios w.r.t. CM roles .. Patch Set 2: (1 comment)

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: Code-Review+2 LGTM, although have same question that

[kudu-CR] Bump Sentry version

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: (1 comment)

[kudu-CR] [master] modernize code w.r.t. virtual/override keywords

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [master] modernize code w.r.t. virtual/override keywords .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13066 To

[kudu-CR] Bump Sentry version

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 2: Verified+1 Unrelated tsan failure. -- To view, visit

[kudu-CR] [sentry] enable sentry integration for master stress test

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12877 ) Change subject: [sentry] enable sentry integration for master stress test .. Patch Set 2: (16 comments)

[kudu-CR] WIP master: use AuthzProvider to generate authz tokens

2019-04-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13013 ) Change subject: WIP master: use AuthzProvider to generate authz tokens .. Patch Set 4: (1 comment)

[kudu-CR] [sentry] enable sentry integration for master stress test

2019-04-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12877 to look at the new patch set (#2). Change subject: [sentry] enable sentry integration for master stress test

[kudu-CR] [master] modernize code w.r.t. virtual/override keywords

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13066 ) Change subject: [master] modernize code w.r.t. virtual/override keywords .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 6: (3 comments)

[kudu-CR] [master] modernize code w.r.t. virtual/override keywords

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13066 ) Change subject: [master] modernize code w.r.t. virtual/override keywords .. [master] modernize code w.r.t. virtual/override

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13063 ) Change subject: WIP [master] RPC knobs to control authz privileges cache .. Patch Set 1: Verified+1 Unrelated flakes in Java tests &

[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [docs] updated master-related scenarios w.r.t. CM roles .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13022 To

[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: [docs] updated master-related scenarios w.r.t. CM roles .. Patch Set 2: Verified+1 unrelated test flakes -- To

[kudu-CR] WIP [master] RPC knobs to control authz privileges cache

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: WIP [master] RPC knobs to control authz privileges cache .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13063 To

[kudu-CR] Bump Sentry version

2019-04-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13059 ) Change subject: Bump Sentry version .. Patch Set 1: (5 comments)

[kudu-CR] [ksck] Make ksck tool more concurrent

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 ) Change subject: [ksck] Make ksck tool more concurrent .. Patch Set 5: (3 comments)

[kudu-CR] [docs] updated master-related scenarios w.r.t. CM roles

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13022 ) Change subject: [docs] updated master-related scenarios w.r.t. CM roles .. Patch Set 2: (1 comment)

[kudu-CR] [catalog manager] simplify lifecycle of authz provider

2019-04-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13062 ) Change subject: [catalog_manager] simplify lifecycle of authz provider .. Patch Set 1: Code-Review+2 Hao and I had a related discussion