[kudu-CR] [docs] Add docs for configuring maintenance priority for kudu tables

2020-05-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15915 Change subject: [docs] Add docs for configuring maintenance priority for kudu tables .. [docs] Add docs for configuring maintenance

[kudu-CR] [tools] multiple tablet ids in 'local replica delete'

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15909 ) Change subject: [tools] multiple tablet ids in 'local_replica delete' .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [tools] multiple tablet ids in 'local replica delete'

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15909 ) Change subject: [tools] multiple tablet ids in 'local_replica delete' .. [tools] multiple tablet ids in 'local_replica delete'

[kudu-CR] [tools] add --ignore nonexistent for 'local replica delete'

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15911 ) Change subject: [tools] add --ignore_nonexistent for 'local_replica delete' .. [tools] add --ignore_nonexistent for

[kudu-CR] [docs] Add docs for configuring maintenance priority for kudu tables

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15915 ) Change subject: [docs] Add docs for configuring maintenance priority for kudu tables .. [docs] Add docs for configuring

[kudu-CR] [docs] Add docs for configuring maintenance priority for kudu tables

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15915 ) Change subject: [docs] Add docs for configuring maintenance priority for kudu tables .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [master] basic master scale test scenario

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15865 ) Change subject: [master] basic master scale test scenario .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-3112. Fix WaitForBind method for checking service status

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15893 ) Change subject: KUDU-3112. Fix WaitForBind method for checking service status .. Patch Set 4: > Build Successful > >

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect Ranger to bind at wildcard address .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-14 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 7: (1 comment)

[kudu-CR] [fs] limit memory could consumpt by low live ratio blocks compacting during startup

2020-05-14 Thread wangning (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15830 to look at the new patch set (#5). Change subject: [fs] limit memory could consumpt by low live ratio blocks compacting during startup

[kudu-CR] [fs] limit memory could consume compacting low live ratio blocks during startup

2020-05-14 Thread wangning (Code Review)
wangning has posted comments on this change. ( http://gerrit.cloudera.org:8080/15830 ) Change subject: [fs] limit memory could consume compacting low live ratio blocks during startup .. Patch Set 6: (8 comments) Thx for

[kudu-CR] [fs] limit memory could consume compacting low live ratio blocks during startup

2020-05-14 Thread wangning (Code Review)
Hello Kudu Jenkins, Andrew Wong, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15830 to look at the new patch set (#6). Change subject: [fs] limit memory could consume compacting low live ratio blocks during startup

[kudu-CR] KUDU-3112. Fix WaitForBind method for checking service status

2020-05-14 Thread liusheng (Code Review)
liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15893 ) Change subject: KUDU-3112. Fix WaitForBind method for checking service status .. Patch Set 4: > > Build Successful > > > >

[kudu-CR] KUDU-3112. Fix WaitForBind method for checking service status

2020-05-14 Thread liusheng (Code Review)
liusheng has abandoned this change. ( http://gerrit.cloudera.org:8080/15893 ) Change subject: KUDU-3112. Fix WaitForBind method for checking service status .. Abandoned thanks, I have tested the

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread liusheng (Code Review)
liusheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect Ranger to bind at wildcard address .. Patch Set 2: Code-Review+1 Thanks @Alexey Serbin, I have tested

[kudu-CR] [tools] add --ignore nonexistent for 'local replica delete'

2020-05-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15911 to look at the new patch set (#3). Change subject: [tools] add --ignore_nonexistent for 'local_replica delete'

[kudu-CR] [tools] add --ignore nonexistent for 'local replica delete'

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15911 ) Change subject: [tools] add --ignore_nonexistent for 'local_replica delete' .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [mini ranger] expect ranger to bind to wildcard address

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect ranger to bind to wildcard address .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [mini ranger] expect ranger to bind to wildcard address

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect ranger to bind to wildcard address .. Patch Set 1: (1 comment)

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-14 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 7: Failure appears to be flaky test via ASAN.

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread Alexey Serbin (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15917 to look at the new patch set (#2). Change subject: [mini_ranger] expect Ranger to bind at wildcard address

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. Patch Set 1: (3 comments)

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. Patch Set 1: (8 comments)

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#3). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-14 Thread Brian McDevitt (Code Review)
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 6: (2 comments) New patch set. Having a hard

[kudu-CR] [metrics] fix MeanGauge::snapshot()

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [metrics] fix MeanGauge::snapshot() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15916 To unsubscribe, visit

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-14 Thread Brian McDevitt (Code Review)
Hello Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15882 to look at the new patch set (#7). Change subject: [KUDU-3116] Enhance KuduContext row operation metrics

[kudu-CR] [tools] add --ignore nonexistent for 'local replica delete'

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15911 ) Change subject: [tools] add --ignore_nonexistent for 'local_replica delete' .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [mini ranger] expect ranger to bind to wildcard address

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15917 Change subject: [mini_ranger] expect ranger to bind to wildcard address .. [mini_ranger] expect ranger to bind to wildcard address

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 7: (1 comment)

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect Ranger to bind at wildcard address .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 2: I uploaded

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect Ranger to bind at wildcard address .. Patch Set 2: Code-Review+1 Thanks! It'd be great if we could

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#2). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

[kudu-CR] [metrics] fix MeanGauge::snapshot()

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15916 ) Change subject: [metrics] fix MeanGauge::snapshot() .. Patch Set 1: Verified+1 Code-Review+2 Nice find! -- To view, visit

[kudu-CR] [KUDU-3116] Enhance KuduContext row operation metrics

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15882 ) Change subject: [KUDU-3116] Enhance KuduContext row operation metrics .. Patch Set 7: (1 comment)

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect Ranger to bind at wildcard address .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15922 Change subject: [site] update site for Kudu 1.12.0 release .. [site] update site for Kudu 1.12.0 release Change-Id:

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15922 ) Change subject: [site] update site for Kudu 1.12.0 release .. [site] update site for Kudu 1.12.0 release Change-Id:

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15922 ) Change subject: [site] update site for Kudu 1.12.0 release .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](gh-pages) [site] update site for Kudu 1.12.0 release

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15922 ) Change subject: [site] update site for Kudu 1.12.0 release .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-14 Thread RuiChen (Code Review)
RuiChen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 2:

[kudu-CR] KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread

2020-05-14 Thread RuiChen (Code Review)
RuiChen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 ) Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread .. Patch Set 2: > > Patch Set 1: > >

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Bankim Bhavsar (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15913 to look at the new patch set (#4). Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. Patch Set 4: (2 comments)

[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15918 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15919 Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. [C++ client] doxygenized C++ client API in

[kudu-CR] [mini ranger] expect Ranger to bind at wildcard address

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15917 ) Change subject: [mini_ranger] expect Ranger to bind at wildcard address .. Patch Set 2: > Thanks! It'd be great if we could confirm

[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15919 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] rebalancer: throttle logging when building cluster info

2020-05-14 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15920 to review the following change. Change subject: rebalancer: throttle logging when building cluster info ..

[kudu-CR] rebalancer: throttle logging when building cluster info

2020-05-14 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15920 ) Change subject: rebalancer: throttle logging when building cluster info .. Patch Set 1: (2 comments)

[kudu-CR] [metrics] fix MeanGauge::snapshot()

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15916 ) Change subject: [metrics] fix MeanGauge::snapshot() .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [metrics] fix MeanGauge::snapshot()

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15916 ) Change subject: [metrics] fix MeanGauge::snapshot() .. [metrics] fix MeanGauge::snapshot() MeanGauge::snapshot() will always

[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15918 Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. [C++ client] doxygenized C++ client API in

[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15918 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. [C++ client] doxygenized C++ client API in

[kudu-CR] [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15918 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. Patch Set 4: (10 comments)

[kudu-CR] [perf] Check range predicate first while evaluating Bloom filter predicate

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 ) Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate .. Patch Set 4: Code-Review+1 (1 comment)

[kudu-CR](branch-1.12.x) [C++ client] doxygenized C++ client API in columnar scan batch.h

2020-05-14 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15919 ) Change subject: [C++ client] doxygenized C++ client API in columnar_scan_batch.h .. [C++ client] doxygenized C++ client API in

[kudu-CR] rebalancer: throttle logging when building cluster info

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15920 ) Change subject: rebalancer: throttle logging when building cluster info .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [tools] multiple tablet ids in 'local replica delete'

2020-05-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15909 ) Change subject: [tools] multiple tablet ids in 'local_replica delete' .. Patch Set 1: (6 comments)

[kudu-CR] [tools] multiple tablet ids in 'local replica delete'

2020-05-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15909 to look at the new patch set (#2). Change subject: [tools] multiple tablet ids in 'local_replica delete'

[kudu-CR] [metrics] fix MeanGauge::snapshot()

2020-05-14 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15916 Change subject: [metrics] fix MeanGauge::snapshot() .. [metrics] fix MeanGauge::snapshot() MeanGauge::snapshot() will always return a