[kudu-CR] subprocess: allow Call() to read both stdout and stderr
Todd Lipcon has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4057/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 187: // Interrupted by a signal, do nothing. is this the appropriate thing instead of retrying on EINTR? (like RETRY_ON_EINTR macro in env_posix.cc) Line 487: *stdout_out = out[0]; maybe std::move or a swap() makes sense here just cuz the output could be large -- To view, visit http://gerrit.cloudera.org:8080/4057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5f2be94c2e5cc0644a5bb2340adc4a71d844247 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add release announcement blog for 0.10
Todd Lipcon has posted comments on this change. Change subject: Add release announcement blog for 0.10 .. Patch Set 1: Code-Review+2 Verified+1 Going to push this without review since I already sent the same text out on slack earlier, and would like to get this staged and ready to tweet/announce in the morning. Feel free to suggest changes if you find issues. -- To view, visit http://gerrit.cloudera.org:8080/4088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e9aa3e43a57e27953b867d733b8162b25ff76f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Add release announcement blog for 0.10
Todd Lipcon has submitted this change and it was merged. Change subject: Add release announcement blog for 0.10 .. Add release announcement blog for 0.10 Change-Id: I08e9aa3e43a57e27953b867d733b8162b25ff76f Reviewed-on: http://gerrit.cloudera.org:8080/4088 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- A _posts/2016-08-23-apache-kudu-0-10-0-released.md 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08e9aa3e43a57e27953b867d733b8162b25ff76f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x
Todd Lipcon has posted comments on this change. Change subject: Update docs from tip of branch-0.10.x .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If574b4addfe5fa37e091a8533eaf87db68214bd8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x
Todd Lipcon has submitted this change and it was merged. Change subject: Update docs from tip of branch-0.10.x .. Update docs from tip of branch-0.10.x Hash ffd8fa4758fd8598a8d06a79249a6ab57d72aa81 Change-Id: If574b4addfe5fa37e091a8533eaf87db68214bd8 Reviewed-on: http://gerrit.cloudera.org:8080/4091 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- M docs/configuration_reference.html M docs/configuration_reference_unsupported.html M docs/contributing.html M docs/kudu-master_configuration_reference.html M docs/kudu-master_configuration_reference_unsupported.html M docs/kudu-tserver_configuration_reference.html M docs/kudu-tserver_configuration_reference_unsupported.html M docs/release_notes.html M releases/0.10.0/docs/configuration_reference.html M releases/0.10.0/docs/configuration_reference_unsupported.html M releases/0.10.0/docs/contributing.html M releases/0.10.0/docs/kudu-master_configuration_reference.html M releases/0.10.0/docs/kudu-master_configuration_reference_unsupported.html M releases/0.10.0/docs/kudu-tserver_configuration_reference.html M releases/0.10.0/docs/kudu-tserver_configuration_reference_unsupported.html M releases/0.10.0/docs/release_notes.html 16 files changed, 68 insertions(+), 82 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: If574b4addfe5fa37e091a8533eaf87db68214bd8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4091 to review the following change. Change subject: Update docs from tip of branch-0.10.x .. Update docs from tip of branch-0.10.x Hash ffd8fa4758fd8598a8d06a79249a6ab57d72aa81 Change-Id: If574b4addfe5fa37e091a8533eaf87db68214bd8 --- M docs/configuration_reference.html M docs/configuration_reference_unsupported.html M docs/contributing.html M docs/kudu-master_configuration_reference.html M docs/kudu-master_configuration_reference_unsupported.html M docs/kudu-tserver_configuration_reference.html M docs/kudu-tserver_configuration_reference_unsupported.html M docs/release_notes.html M releases/0.10.0/docs/configuration_reference.html M releases/0.10.0/docs/configuration_reference_unsupported.html M releases/0.10.0/docs/contributing.html M releases/0.10.0/docs/kudu-master_configuration_reference.html M releases/0.10.0/docs/kudu-master_configuration_reference_unsupported.html M releases/0.10.0/docs/kudu-tserver_configuration_reference.html M releases/0.10.0/docs/kudu-tserver_configuration_reference_unsupported.html M releases/0.10.0/docs/release_notes.html 16 files changed, 68 insertions(+), 82 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/4091/1 -- To view, visit http://gerrit.cloudera.org:8080/4091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If574b4addfe5fa37e091a8533eaf87db68214bd8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy
[kudu-CR] Fix release notes formatting for multi-paragraph list items
Kudu Jenkins has posted comments on this change. Change subject: Fix release notes formatting for multi-paragraph list items .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3022/ -- To view, visit http://gerrit.cloudera.org:8080/4090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) Fix release notes formatting for multi-paragraph list items
Todd Lipcon has posted comments on this change. Change subject: Fix release notes formatting for multi-paragraph list items .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Fix release notes formatting for multi-paragraph list items
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4090 Change subject: Fix release notes formatting for multi-paragraph list items .. Fix release notes formatting for multi-paragraph list items If a list item spans multiple paragraphs in AsciiDoc, it needs a '+' in the intervening blank line, and the latter paragraphs should not be indented on their first line. The text is a bit uglier, but it fixes the rendering. Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Reviewed-on: http://gerrit.cloudera.org:8080/4089 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon (cherry picked from commit ffd8fa4758fd8598a8d06a79249a6ab57d72aa81) --- M docs/release_notes.adoc 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/4090/1 -- To view, visit http://gerrit.cloudera.org:8080/4090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon
[kudu-CR] Fix release notes formatting for multi-paragraph list items
Todd Lipcon has posted comments on this change. Change subject: Fix release notes formatting for multi-paragraph list items .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) Fix release notes formatting for multi-paragraph list items
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4089 Change subject: Fix release notes formatting for multi-paragraph list items .. Fix release notes formatting for multi-paragraph list items If a list item spans multiple paragraphs in AsciiDoc, it needs a '+' in the intervening blank line, and the latter paragraphs should not be indented on their first line. The text is a bit uglier, but it fixes the rendering. Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e --- M docs/release_notes.adoc 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/4089/1 -- To view, visit http://gerrit.cloudera.org:8080/4089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon
[kudu-CR](branch-0.10.x) Fix release notes formatting for multi-paragraph list items
Kudu Jenkins has posted comments on this change. Change subject: Fix release notes formatting for multi-paragraph list items .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3021/ -- To view, visit http://gerrit.cloudera.org:8080/4089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Fix release notes formatting for multi-paragraph list items
Todd Lipcon has submitted this change and it was merged. Change subject: Fix release notes formatting for multi-paragraph list items .. Fix release notes formatting for multi-paragraph list items If a list item spans multiple paragraphs in AsciiDoc, it needs a '+' in the intervening blank line, and the latter paragraphs should not be indented on their first line. The text is a bit uglier, but it fixes the rendering. Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Reviewed-on: http://gerrit.cloudera.org:8080/4089 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon (cherry picked from commit ffd8fa4758fd8598a8d06a79249a6ab57d72aa81) Reviewed-on: http://gerrit.cloudera.org:8080/4090 --- M docs/release_notes.adoc 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.10.x) Fix release notes formatting for multi-paragraph list items
Todd Lipcon has submitted this change and it was merged. Change subject: Fix release notes formatting for multi-paragraph list items .. Fix release notes formatting for multi-paragraph list items If a list item spans multiple paragraphs in AsciiDoc, it needs a '+' in the intervening blank line, and the latter paragraphs should not be indented on their first line. The text is a bit uglier, but it fixes the rendering. Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Reviewed-on: http://gerrit.cloudera.org:8080/4089 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- M docs/release_notes.adoc 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie65570ed32acef1c3025f351f7c4b4944f443f6e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) Add release announcement blog for 0.10
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4088 to review the following change. Change subject: Add release announcement blog for 0.10 .. Add release announcement blog for 0.10 Change-Id: I08e9aa3e43a57e27953b867d733b8162b25ff76f --- A _posts/2016-08-23-apache-kudu-0-10-0-released.md 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/4088/1 -- To view, visit http://gerrit.cloudera.org:8080/4088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08e9aa3e43a57e27953b867d733b8162b25ff76f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy
[kudu-CR](gh-pages) new range partitioning features blog post
Todd Lipcon has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 6: Code-Review+2 Verified+1 Going to push this tonight and schedule some tweets to go out in the morning -- To view, visit http://gerrit.cloudera.org:8080/4012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR](gh-pages) new range partitioning features blog post
Todd Lipcon has submitted this change and it was merged. Change subject: new range partitioning features blog post .. new range partitioning features blog post Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 Reviewed-on: http://gerrit.cloudera.org:8080/4012 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- A _posts/2016-08-23-new-range-partitioning-features.md A img/2016-08-23-new-range-partitioning-features/range-and-hash-partitioning.png A img/2016-08-23-new-range-partitioning-features/range-partitioning-on-time.png 3 files changed, 99 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR](gh-pages) Update site for 0.10.0 release
Todd Lipcon has submitted this change and it was merged. Change subject: Update site for 0.10.0 release .. Update site for 0.10.0 release - adds new docs - copies docs to 0.10.0 directory Change-Id: Icdf39b1810a8370fedf43fb190046cdcda080f16 Reviewed-on: http://gerrit.cloudera.org:8080/4085 Reviewed-by: Mike Percy Tested-by: Todd Lipcon --- M apidocs/allclasses-frame.html M apidocs/allclasses-noframe.html M apidocs/constant-values.html M apidocs/deprecated-list.html M apidocs/help-doc.html M apidocs/index-all.html M apidocs/index.html A apidocs/org/apache/kudu/ColumnSchema.html A apidocs/org/apache/kudu/Schema.html A apidocs/org/apache/kudu/Type.html A apidocs/org/apache/kudu/annotations/InterfaceAudience.html A apidocs/org/apache/kudu/annotations/InterfaceStability.html A apidocs/org/apache/kudu/annotations/class-use/InterfaceAudience.html A apidocs/org/apache/kudu/annotations/class-use/InterfaceStability.html A apidocs/org/apache/kudu/annotations/package-frame.html A apidocs/org/apache/kudu/annotations/package-summary.html A apidocs/org/apache/kudu/annotations/package-tree.html A apidocs/org/apache/kudu/annotations/package-use.html A apidocs/org/apache/kudu/class-use/ColumnSchema.html A apidocs/org/apache/kudu/class-use/Schema.html A apidocs/org/apache/kudu/class-use/Type.html A apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html A apidocs/org/apache/kudu/client/AlterTableOptions.html A apidocs/org/apache/kudu/client/AlterTableResponse.html A apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html A apidocs/org/apache/kudu/client/AsyncKuduClient.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.html A apidocs/org/apache/kudu/client/AsyncKuduSession.html A apidocs/org/apache/kudu/client/ColumnRangePredicate.html A apidocs/org/apache/kudu/client/CreateTableOptions.html A apidocs/org/apache/kudu/client/Delete.html A apidocs/org/apache/kudu/client/DeleteTableResponse.html A apidocs/org/apache/kudu/client/ExternalConsistencyMode.html A apidocs/org/apache/kudu/client/HasFailedRpcException.html A apidocs/org/apache/kudu/client/Insert.html A apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html A apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html A apidocs/org/apache/kudu/client/KuduClient.html A apidocs/org/apache/kudu/client/KuduException.html A apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html A apidocs/org/apache/kudu/client/KuduPredicate.html A apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html A apidocs/org/apache/kudu/client/KuduScanToken.html A apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html A apidocs/org/apache/kudu/client/KuduScanner.html A apidocs/org/apache/kudu/client/KuduSession.html A apidocs/org/apache/kudu/client/KuduTable.html A apidocs/org/apache/kudu/client/ListTablesResponse.html A apidocs/org/apache/kudu/client/ListTabletServersResponse.html A apidocs/org/apache/kudu/client/LocatedTablet.Replica.html A apidocs/org/apache/kudu/client/LocatedTablet.html A apidocs/org/apache/kudu/client/Operation.html A apidocs/org/apache/kudu/client/OperationResponse.html A apidocs/org/apache/kudu/client/PartialRow.html A apidocs/org/apache/kudu/client/PleaseThrottleException.html A apidocs/org/apache/kudu/client/RangePartitionBound.html A apidocs/org/apache/kudu/client/RowError.html A apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html A apidocs/org/apache/kudu/client/RowResult.html A apidocs/org/apache/kudu/client/RowResultIterator.html A apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html A apidocs/org/apache/kudu/client/SessionConfiguration.html A apidocs/org/apache/kudu/client/Statistics.Statistic.html A apidocs/org/apache/kudu/client/Statistics.html A apidocs/org/apache/kudu/client/Status.html A apidocs/org/apache/kudu/client/Update.html A apidocs/org/apache/kudu/client/Upsert.html A apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html A apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html A apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.ReadMode.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduSession.html A apidocs/org/apache/kudu/client/class-use/ColumnRangePredicate.html A apidocs/org/apache/kudu/client/class-use/CreateTableOptions.html A apidocs/org/apache/kudu/client/class-use/Delete.html A apidocs/org/apache/kudu/client/class-use/Delete
[kudu-CR](gh-pages) Update site for 0.10.0 release
Todd Lipcon has posted comments on this change. Change subject: Update site for 0.10.0 release .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdf39b1810a8370fedf43fb190046cdcda080f16 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) Link to new range partitioning features blog post from release notes
Kudu Jenkins has posted comments on this change. Change subject: Link to new range partitioning features blog post from release notes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3020/ -- To view, visit http://gerrit.cloudera.org:8080/4087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) Link to new range partitioning features blog post from release notes
Todd Lipcon has posted comments on this change. Change subject: Link to new range partitioning features blog post from release notes .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) Link to new range partitioning features blog post from release notes
Todd Lipcon has submitted this change and it was merged. Change subject: Link to new range partitioning features blog post from release notes .. Link to new range partitioning features blog post from release notes Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Reviewed-on: http://gerrit.cloudera.org:8080/4086 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon (cherry picked from commit 157ff14d85083906e7475378a54c5dd78f19127e) Reviewed-on: http://gerrit.cloudera.org:8080/4087 Tested-by: Todd Lipcon --- M docs/release_notes.adoc 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.10.x) Link to new range partitioning features blog post from release notes
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4087 Change subject: Link to new range partitioning features blog post from release notes .. Link to new range partitioning features blog post from release notes Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Reviewed-on: http://gerrit.cloudera.org:8080/4086 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon (cherry picked from commit 157ff14d85083906e7475378a54c5dd78f19127e) --- M docs/release_notes.adoc 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/4087/1 -- To view, visit http://gerrit.cloudera.org:8080/4087 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Dan Burkert
[kudu-CR] Link to new range partitioning features blog post from release notes
Todd Lipcon has submitted this change and it was merged. Change subject: Link to new range partitioning features blog post from release notes .. Link to new range partitioning features blog post from release notes Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Reviewed-on: http://gerrit.cloudera.org:8080/4086 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M docs/release_notes.adoc 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Link to new range partitioning features blog post from release notes
Todd Lipcon has posted comments on this change. Change subject: Link to new range partitioning features blog post from release notes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 20: Build Started http://104.196.14.100/job/kudu-gerrit/3019/ -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#20). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for the Kudu C++ client library. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if total amount of data for pending operations reaches the buffer size limit. The limit on the buffer size can be set by the KuduSession::SetMutationBufferSpace() method. The background flush logic checks whether at least one of the following two conditions is satisfied to determine whether it's time to flush the accumulated write operations: * The over-the-watermark criterion: check whether the total size of the freshly submitted (i.e. not-yet-scheduled-for-flush) write operations is over the threshold. The threshold can be set as a percentage of the total buffer size using the KuduSession::SetMutationBufferFlushWatermark() method. * The maximum wait time criterion: check whether the current batch of operations has been accumulating for more than the maximum wait time. The maximum wait time can be specified in milliseconds using the KuduSession::SetMutationBufferFlushInterva() method. A KuduSession object uses RPC messenger's thread pool to monitor batches' maximum wait time. This change also addresses the following JIRA issue: KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 --- M python/kudu/tests/test_client.py M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/client/write_op.cc M src/kudu/client/write_op.h 11 files changed, 1,178 insertions(+), 174 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3952/20 -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 20 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Alexey Serbin has posted comments on this change.
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
Patch Set 18:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:
PS18, Line 522: Add
> Does it make sense to add a coment that callers are expected to serialize d
I think the original design of the Batch class is to accommodate multiple
callers of this method.
http://gerrit.cloudera.org:8080/#/c/3952/16/src/kudu/client/batcher.h
File src/kudu/client/batcher.h:
Line 168:
> typo: the the
Done
PS16, Line 169: ck
> s/is/are/
Done
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/client.cc
File src/kudu/client/client.cc:
Line 692: : data_(new KuduSession::Data(client, client->data_->messenger_)) {
> I haven't looked at how data_ being set, just wondering if data_ could be N
The data_ is allocated in the constructor of the Kudu::Client() object, so it
should not be nullptr: if there is not enough memory, std::bad_alloc() should
be thrown and it will be termination with SIGABRT due to the unexpected
exception.
PS18, Line 736: int
> uint ?
Good point -- I added this to be in line with SetTimeoutMillis(), but using
unit would be better. Will change.
PS18, Line 740: int
> uint ?
This comes from the interface which is already published. I'm not sure whether
it's OK to change it in an incompatible way now.
http://gerrit.cloudera.org:8080/#/c/3952/16/src/kudu/client/client.h
File src/kudu/client/client.h:
Line 1017: /// Modes of flush operations.
> Is there a default mode of op here ? if so, can we mention it in comment ?
Yes, there is. You could find it in the description for the AUTO_FLUSH_SYNC
mode.
Line 1038: /// batch is sent and the reclamed space is available for new
operations.
> typo: reclamed
Done
Line 1040: /// @todo Provide an API for the user to specify a callback to
do their own
> If this is not specific to this mode alone, we could move this todo in the
No, this is specific only for this mode. In all other cases it's either
possible to specify a callback or it's clear that the callback is not needed
(because the flush operation is synchronous).
Line 1044: /// (probably the messenger IO threads?).
> I guess this todo is already addressed ?
Yes, this is clear that it's not needed now -- will remove.
http://gerrit.cloudera.org:8080/#/c/3952/19/src/kudu/client/session-internal.cc
File src/kudu/client/session-internal.cc:
PS19, Line 233: weak_session
> any significance of usage of 'weak' session ? :)
Yes -- this is to avoid circular dependencies later when NextBatcher is called.
It's possible to use shared_ptr here as well, but it should be transformed
into weak_ptr in the batcher anyway.
PS19, Line 263: (
> Isn't this redundant ? We could as well place NextBatcher above ?
No, it's not. Only in rare cases the additional pre-flush is needed (i.e. call
of NextBatcher()). Please read on the diagram which you liked.
PS19, Line 270: lock_
> I thought whole routine is serialized, so why another spinlock here ?
Because there is another actor -- the background 'periodic' flush task which
calls NextBatcher() and replaces batcher_.
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/session-internal.h
File src/kudu/client/session-internal.h:
PS18, Line 126: to
> s/to/for ?
Done
PS18, Line 165: cond_mutex_
> Trivial nit: I suggest to rename this to flow_control_cond_mutex_ which cou
Good idea -- thanks!
I'll rename it and leave the comment since it explains why this is different
from the lock_ and gives info in which order it's necessary to acquire both, if
needed (actually, the code never acquires both).
--
To view, visit http://gerrit.cloudera.org:8080/3952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8
Gerrit-PatchSet: 18
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Dinesh Bhat
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] Link to new range partitioning features blog post from release notes
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/4086 Change subject: Link to new range partitioning features blog post from release notes .. Link to new range partitioning features blog post from release notes Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 --- M docs/release_notes.adoc 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4086/1 -- To view, visit http://gerrit.cloudera.org:8080/4086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert
[kudu-CR] Link to new range partitioning features blog post from release notes
Kudu Jenkins has posted comments on this change. Change subject: Link to new range partitioning features blog post from release notes .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3018/ -- To view, visit http://gerrit.cloudera.org:8080/4086 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53116c0c33c00acef8474a14c983822b79388a24 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata
Mike Percy has posted comments on this change.
Change subject: KUDU-1500: Data race in
RaftConsensusITest.TestCorruptReplicaMetadata
..
Patch Set 8:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/3823/8/src/kudu/integration-tests/cluster_itest_util.h
File src/kudu/integration-tests/cluster_itest_util.h:
Line 242: Status ListTabletsDuringTabletCopy(const TServerDetails* ts,
I don't think this utility is generic enough to put here. It is very specific.
Let's move it to the test.
http://gerrit.cloudera.org:8080/#/c/3823/8/src/kudu/integration-tests/tablet_copy-itest.cc
File src/kudu/integration-tests/tablet_copy-itest.cc:
Line 42: DEFINE_int32(num_test_threads, 16,
Let's follow the convention of the other params and name this test_num_threads
Line 262: // Step 4: Verify that at least one thread caught the state
transition.
Let's just remove step 4.
Line 287: for (int i = 0; i < cluster_->num_tablet_servers(); i++) {
This check is not needed. WaitForServersToAgree() already effectively achieves
this.
Line 298: // Find out who is leader so that we can tombstone a follower
It doesn't matter whether you kill a leader or a follower, does it? We only
care that one of the servers eventually becomes leader and starts a tablet copy
on our tombstoned replica.
That said, even though this isn't necessary for correctness, it makes average
test time lower since we don't have to wait for an election to get the tablet
copy kicked off. Let's just document that as the reason for doing this.
Line 306: AtomicBool transition(false);
These days, prefer std::atomic_bool or std::atomic (the former is a
typedef of the latter) from C++11 to this older C++03 compatible atomics
library.
Line 327: << " on TS " << follower_ts->uuid();
nit: it's prettier / more readable to align the << with the one on the previous
line
Line 347: if (!transition.Load())
Hmm. I think we should remove this since it's not really doing anything, and
trying to rely on it would make this test racy. No one will ever check this
test log output and if they did it wouldn't tell them very much.
Line 351: ASSERT_TRUE(cluster_->tablet_server(kTsIndex)->IsProcessAlive());
This can be replaced with NO_FATALS(cluster_->AssertNoCrashes());
http://gerrit.cloudera.org:8080/#/c/3823/8/src/kudu/tablet/tablet_metadata.cc
File src/kudu/tablet/tablet_metadata.cc:
Line 283: table_id_ = superblock.table_id();
What about table_id_? Shouldn't this also be inside the "if" statement below?
Also the table_name_. Right now, we don't support renaming tables. I think we
should add a DHECK that these things didn't change and then put them inside the
"if".
Line 298: LOG_WITH_PREFIX(WARNING) << "Upgrading from Kudu 0.5.0 directly
to this"
This seems like it should be a FATAL error to me. Dan?
Line 300: << " moving to a higher version." << std::endl;
std::endl is not required here and should be removed
Line 303: if (state_ == kNotLoadedYet) {
Please add a comment here explaining why we only do this when the
TabletMetadata is uninitialized.
--
To view, visit http://gerrit.cloudera.org:8080/3823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If57617e22b41296b8d4e8ad131220f1ebb235019
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Dinesh Bhat
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) new range partitioning features blog post
Hello Misty Stanley-Jones, Will Berkeley, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4012 to look at the new patch set (#6). Change subject: new range partitioning features blog post .. new range partitioning features blog post Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 --- A _posts/2016-08-23-new-range-partitioning-features.md A img/2016-08-23-new-range-partitioning-features/range-and-hash-partitioning.png A img/2016-08-23-new-range-partitioning-features/range-partitioning-on-time.png 3 files changed, 99 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4012/6 -- To view, visit http://gerrit.cloudera.org:8080/4012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] Predicate evaluation pushdown
Todd Lipcon has posted comments on this change.
Change subject: Predicate evaluation pushdown
..
Patch Set 4:
(39 comments)
did a first pass of comments. i think splitting out the optimization on
predicate evaluation to avoid the extra indirections is a worthy thing to do
separately from the pushdown stuff
http://gerrit.cloudera.org:8080/#/c/3990/4/src/kudu/cfile/block_encodings.h
File src/kudu/cfile/block_encodings.h:
Line 138: virtual Status SeekForward(size_t* n) = 0;
I think it'd be better to use 'int' here, so you can DCHECK_GE(*n, 0) at the
start. We used to use size_t more (this is old code) but int's safer because an
underflow bug will be more obvious
Line 157: // function is that ctx->eval_complete() is true, and false
otherwise.
I think there's a subtle requirement here that, given a particular encoding
type and a particular predicate, this must completely determine whether
eval_complete will get set. In other words, a decoder can't be data-dependent
on whether to set eval_complete, right?
Otherwise we could have something like:
cfile block 1: decoder says "not complete"
cfile block 2: decode says "complete"
top-level iterator code says "aha! it's complete" and decides that it doesn't
need to evaluate predicates.
Making 'eval_complete' a tri-state (EvaluationState) with an enum like
{NOT_STARTED, EVALUATED, NOT_EVALUATED} and ensuring that you can only move
from NOT_STARTED to one of the others, but not between the other two, would be
a good way to add some safety here
Line 162: CopyNextValues(n, dst);
RETURN_NOT_OK
http://gerrit.cloudera.org:8080/#/c/3990/4/src/kudu/cfile/cfile_reader.cc
File src/kudu/cfile/cfile_reader.cc:
Line 670: // If seeking within the dasta block results in NotFound, then that
indicates that the
typo
Line 728: // No ctx_->sel() defined implies there is no predicate
evaluation at the
I think a getter like 'ctx_->try_decoder_predicate_evaluation()' would be a bit
nicer here
Line 733: // this happens are kept for compatibility with older test cases.
would rather add a wrapper in the test code instead of adding a compatibility
path here in the real code
Line 747: LOG(INFO) << BitmapToString(pred_set_->bitmap(),
pred_set_->nrows());
should remove this
Line 977: // These will be null if gflag for decoder eval is off
again a getter would centralize these checks and make the code more readable
here
http://gerrit.cloudera.org:8080/#/c/3990/4/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:
Line 24: #include "kudu/common/column_eval_context.h"
forward decl is sufficient
Line 222: virtual Status PrepareScan(rowid_t ord_idx, ColumnEvalContext *ctx)
= 0;
would be nice to avoid this "duplicate API" thing where one set of things gets
called when the feature is on, and the other gets called otherwise. It ends up
being multiplicative in the number of code paths that you have to consider when
thinking about the API, which is a lot of cognitive overhead. Can we change
things such that we _always_ have a ColumnEvalContext, but just set some flag
in it when we don't want to attempt the pushdown?
Line 261: virtual Status Scan(ColumnEvalContext *ctx) = 0;
see above, would be good to collapse the two APIs
Line 394: // single set of satisfying predicates.
this isn't returning a set of predicates, though -- it's returning a set of
codeword indexes
Line 395: SelectionVector* GetPredicateSet() { return pred_set_.get();}
should rename to something more specifically about dictionary... maybe
GetCodeWordsMatchingPredicate or something?
Line 468: std::unique_ptrpred_set_;
rename (per above)
http://gerrit.cloudera.org:8080/#/c/3990/4/src/kudu/common/column_eval_context.h
File src/kudu/common/column_eval_context.h:
Line 1: #pragma once
nit: license header
Line 6: // A ColumnEvalContext provides a clean interface to the set of objects
that get passed down to
doc belongs above the class, not above the namespace
Line 7: // the decoders during predicate pushdown
nit: add period at end of sentence
Line 12: ColumnEvalContext(const size_t col_idx,
const primitive doesn't make much sense
Line 16: bool* eval_complete) :
please document the lifetime of these pointer arguments (i.e they must outlive
the context object)
also, I wonder whether some of these items could actually just be made members
of ColumnEvalContext itself instead of passed in as pointers? (in particular
eval_complete)
http://gerrit.cloudera.org:8080/#/c/3990/4/src/kudu/common/column_predicate.cc
File src/kudu/common/column_predicate.cc:
Line 361: void ColumnPredicate::Evaluate(const ColumnBlock& block,
SelectionVector* sel) const {
it seems like this optimization is entirely separate from the "push down
predicate evaluation into the block decoders" work, right? can we split it into
a separate patch to properly quan
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Dinesh Bhat has posted comments on this change.
Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode
..
Patch Set 19:
(17 comments)
Hi Alexey,
went through this patch more from knowledge point of view, so feel free to
ignore any review comments you find not useful. Also I haven't completely
digested all the routines in sesion-internal.cc, so I may as well take a second
pass tomorrow later if time permits.
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:
PS18, Line 522: we
Does it make sense to add a coment that callers are expected to serialize
during Add ?
http://gerrit.cloudera.org:8080/#/c/3952/16/src/kudu/client/batcher.h
File src/kudu/client/batcher.h:
Line 168:
typo: the the
PS16, Line 169: ck
s/is/are/
http://gerrit.cloudera.org:8080/#/c/3952/17/src/kudu/client/batcher.h
File src/kudu/client/batcher.h:
PS17, Line 122: int64_t
Naive doubt here: If Load() is returning a non-atomic value we seem to be
accessing the atomic value of buffer_bytes_used_ in write path vs non-atomic in
read path ?
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/client.cc
File src/kudu/client/client.cc:
Line 692: : data_(new KuduSession::Data(client, client->data_->messenger_)) {
I haven't looked at how data_ being set, just wondering if data_ could be NULL
since it seems to be a regular ptr.
PS18, Line 736: int
uint ?
PS18, Line 740: int
uint ?
http://gerrit.cloudera.org:8080/#/c/3952/16/src/kudu/client/client.h
File src/kudu/client/client.h:
Line 1017: /// Modes of flush operations.
Is there a default mode of op here ? if so, can we mention it in comment ?
Line 1038: /// batch is sent and the reclamed space is available for new
operations.
typo: reclamed
Line 1040: /// @todo Provide an API for the user to specify a callback to
do their own
If this is not specific to this mode alone, we could move this todo in the
beginning perhaps ?
Line 1044: /// (probably the messenger IO threads?).
I guess this todo is already addressed ?
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/session-internal.cc
File src/kudu/client/session-internal.cc:
PS18, Line 448:
Nice !! Liked these ascii diagrams.
http://gerrit.cloudera.org:8080/#/c/3952/19/src/kudu/client/session-internal.cc
File src/kudu/client/session-internal.cc:
PS19, Line 233: weak_session
any significance of usage of 'weak' session ? :)
PS19, Line 263: (
Isn't this redundant ? We could as well place NextBatcher above ?
do {
NextBatcher();
CanApplyWriteOp(&need_pre_flush);
} while (need_pre_flush)
PS19, Line 270: lock_
I thought whole routine is serialized, so why another spinlock here ?
http://gerrit.cloudera.org:8080/#/c/3952/18/src/kudu/client/session-internal.h
File src/kudu/client/session-internal.h:
PS18, Line 126: to
s/to/for ?
PS18, Line 165: cond_mutex_
Trivial nit: I suggest to rename this to flow_control_cond_mutex_ which could
be self explanatory(and remove al the comment associated). Just a suggestion,
feel free to ignore this.
--
To view, visit http://gerrit.cloudera.org:8080/3952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8
Gerrit-PatchSet: 19
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Dinesh Bhat
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] Predicate evaluation pushdown
Alexey Serbin has posted comments on this change.
Change subject: Predicate evaluation pushdown
..
Patch Set 3:
(22 comments)
First pass -- I just saw a new version has appeared. Will continue with the
new version.
http://gerrit.cloudera.org:8080/#/c/3990/3//COMMIT_MSG
Commit Message:
Line 16:
https://github.com/anjuwong/kudu/blob/pred-pushdown/docs/decoder-eval-perf.md
Nit: it would be nice to have the document in the Kudu source tree when it's
time to submit the changes. I.e., please add that .md file into the
changelist. Probably, $REPO_ROOT/docs/design-docs is the right place to add
the file. Don't forget to update the comment once it's time to push the change
into the central repo. Better is to put the correct, relative link here, and
add the temporary location of the documents into some sort of gerrit-specific
comment.
Line 20:
https://github.com/anjuwong/kudu/blob/sorted-dict-block/docs/design-docs/predicate-eval-pushdown.md
Ditto.
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/benchmarks/tpch/tpch_real_world.cc
File src/kudu/benchmarks/tpch/tpch_real_world.cc:
Line 87: DEFINE_string(tpch_path_to_dbgen_dir, "/Users/andrew.wong/tpch-dbgen",
This does not look as a good default. I think ".", "./tpch" or "./tpch-dbgen"
would be better.
http://gerrit.cloudera.org:8080/#/c/3990/2/src/kudu/cfile/binary_dict_block.cc
File src/kudu/cfile/binary_dict_block.cc:
Line 252: // store their min/max values. CopyNextAndEval in these blocks could
Ditto for the asterisk (star) as for the corresponding header file.
Line 289: // Row is included in predicate, copy data to block.
nit: if I'm not mistaken, the style guide mentions if/else should be formatted
like
if (...) {
...
} else {
...
}
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_dict_block.cc
File src/kudu/cfile/binary_dict_block.cc:
Line 191: dict_decoder_ = iter->GetDictDecoder();
Why not to move those into the initializer list?
http://gerrit.cloudera.org:8080/#/c/3990/2/src/kudu/cfile/binary_dict_block.h
File src/kudu/cfile/binary_dict_block.h:
Line 131: Status CopyNextAndEval(size_t *n,
Nit: it seems in the majority of the code in this file the asterisk tends to be
with parameter type, not parameter name. It would be nice to have the same for
the newly added members/methods/functions.
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_dict_block.h
File src/kudu/cfile/binary_dict_block.h:
Line 131: Status CopyNextAndEval(size_t *n,
Style nit: the rest of this file uses the "asterisk is closer to the type"
convention. Consider following it here as well, if it makes sense.
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_plain_block.cc
File src/kudu/cfile/binary_plain_block.cc:
Line 290: size_t i;
If the 'i' variable is not needed outside of the cycle, why not to move it
inside the cycle's visibility, like
for (size_t i = 0; ...)
http://gerrit.cloudera.org:8080/#/c/3990/2/src/kudu/cfile/binary_plain_block.h
File src/kudu/cfile/binary_plain_block.h:
Line 110:
What if SeekForward returned OK only if it moved forward at the specified
number of bytes and returned Status::Incomplete() otherwise?
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/binary_plain_block.h
File src/kudu/cfile/binary_plain_block.h:
Line 111: virtual Status SeekForward(size_t* n) OVERRIDE {
Does it make sense to implement this method in the base class instead?
Line 112: DCHECK(HasNext());
Why not to return non-OK status in that case instead? I.e., always assign the
actual number of positions it was forwarded into the output parameter and
return non-OK status when it's not possible to seek forward to the specified
number of positions.
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/block_encodings.h
File src/kudu/cfile/block_encodings.h:
Line 162: CopyNextValues(n, dst);
What if CopyNextValues() returned non-OK code? Would it make sense to check
for that and return right away in that case?
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/bshuf_block.h
File src/kudu/cfile/bshuf_block.h:
Line 278: Status SeekForward(size_t* n) OVERRIDE {
Consider returning non-OK status code (like Status::Incomplete()) instead of
DCHECK()) if it's not possible to advance current index as far as desired.
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/cfile/plain_block.h
File src/kudu/cfile/plain_block.h:
Line 211: virtual Status SeekForward(size_t* n) OVERRIDE {
Does it make sense to implement this method in the base class instead?
http://gerrit.cloudera.org:8080/#/c/3990/3/src/kudu/common/rowblock.h
File src/kudu/common/rowblock.h:
Line 123: explicit SelectionVectorView(SelectionVector *sel_vec, size_t
first_row_idx = 0)
It's not clear why it would be necessary to have this wrapper for nullptr
SelectionVector. Could you add a comment to clarify t
[kudu-CR](gh-pages) Update site for 0.10.0 release
Mike Percy has posted comments on this change. Change subject: Update site for 0.10.0 release .. Patch Set 1: Code-Review+2 This is a yuuuge patch. Definitely the best Kudu release I've ever seen, by far. By far! -- To view, visit http://gerrit.cloudera.org:8080/4085 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdf39b1810a8370fedf43fb190046cdcda080f16 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Predicate evaluation pushdown
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#4). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown The premise of this patch is to avoid the excessive use of CPU when evaluating column predicates in specific cases. Dictionary blocks, for instance, can evaluate predicates by comparing codewords (UINT32) rather than doing string comparisons. See the performance doc for a look into the performance differences for dictionary encoding and plain encoding: https://github.com/anjuwong/kudu/blob/pred-pushdown/docs/decoder-eval-perf.md See the design-doc for predicate-eval-pushdown for a brief overview of the considered implementations: https://github.com/anjuwong/kudu/blob/sorted-dict-block/docs/design-docs/predicate-eval-pushdown.md This patch uses the predicate-set approach using a bitmap. Change-Id: I31e4cce21e99f63b089d7c84410af8ed914cb576 --- M src/kudu/cfile/binary_dict_block.cc M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/binary_plain_block.cc M src/kudu/cfile/binary_plain_block.h M src/kudu/cfile/binary_prefix_block.h M src/kudu/cfile/block_encodings.h M src/kudu/cfile/bshuf_block.h M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_reader.h M src/kudu/cfile/gvint_block.h M src/kudu/cfile/plain_bitmap_block.h M src/kudu/cfile/plain_block.h M src/kudu/cfile/rle_block.h A src/kudu/common/column_eval_context.h M src/kudu/common/column_predicate.cc M src/kudu/common/column_predicate.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/generic_iterators.h M src/kudu/common/iterator.h M src/kudu/common/rowblock.h M src/kudu/common/schema.h M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/delta_applier.cc M src/kudu/tablet/delta_applier.h M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h A src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h 38 files changed, 809 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/3990/4 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I31e4cce21e99f63b089d7c84410af8ed914cb576 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Predicate evaluation pushdown
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3017/ -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31e4cce21e99f63b089d7c84410af8ed914cb576 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1571. Generate "deprecated" metrics in MDL
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4067/1/java/kudu-csd/check_csd_compatibility.py
File java/kudu-csd/check_csd_compatibility.py:
Line 34: Return a set() representing the metrics in the given MDL JSON object.
nit: set() --> set ?
Line 42: for entity_def in mdl['metricEntityTypeDefinitions']:
What if 'metricDefinitions' key is absent in the MDL? Should it be an error or
the script should with that like if the list of metric type entities is empty?
Line 62: for m_type, m_entity, m_name in added_metrics:
nit: consider using '_' for unused fields:
for _, m_entity, m_name in added_metrics:
...
Line 64: if len(removed_metrics):
> nit: This isn't very pythonic. Should be `if removed_metrics:`, I think.
nit: consider writing it with less code duplication, like
for metrics, tag in [(added_metrics, "Added"), (removed_metrics), "Removed"]:
print "%s %d metric(s):" % (tag, len(metrics))
for _, m_entity, m_name in metrics:
print " %s metric %s" % (m_entity, m_name)
print "Compatibility check %s" % ("FAILED" if removed_metrics else "PASSED")
PS1, Line 77: May also generate a file containing JSON
Probably I missed something, but I could not see how this script can do this
without a slight modification :)
--
To view, visit http://gerrit.cloudera.org:8080/4067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Update site for 0.10.0 release
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4085 to review the following change. Change subject: Update site for 0.10.0 release .. Update site for 0.10.0 release - adds new docs - copies docs to 0.10.0 directory Change-Id: Icdf39b1810a8370fedf43fb190046cdcda080f16 --- M apidocs/allclasses-frame.html M apidocs/allclasses-noframe.html M apidocs/constant-values.html M apidocs/deprecated-list.html M apidocs/help-doc.html M apidocs/index-all.html M apidocs/index.html A apidocs/org/apache/kudu/ColumnSchema.html A apidocs/org/apache/kudu/Schema.html A apidocs/org/apache/kudu/Type.html A apidocs/org/apache/kudu/annotations/InterfaceAudience.html A apidocs/org/apache/kudu/annotations/InterfaceStability.html A apidocs/org/apache/kudu/annotations/class-use/InterfaceAudience.html A apidocs/org/apache/kudu/annotations/class-use/InterfaceStability.html A apidocs/org/apache/kudu/annotations/package-frame.html A apidocs/org/apache/kudu/annotations/package-summary.html A apidocs/org/apache/kudu/annotations/package-tree.html A apidocs/org/apache/kudu/annotations/package-use.html A apidocs/org/apache/kudu/class-use/ColumnSchema.html A apidocs/org/apache/kudu/class-use/Schema.html A apidocs/org/apache/kudu/class-use/Type.html A apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html A apidocs/org/apache/kudu/client/AlterTableOptions.html A apidocs/org/apache/kudu/client/AlterTableResponse.html A apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html A apidocs/org/apache/kudu/client/AsyncKuduClient.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html A apidocs/org/apache/kudu/client/AsyncKuduScanner.html A apidocs/org/apache/kudu/client/AsyncKuduSession.html A apidocs/org/apache/kudu/client/ColumnRangePredicate.html A apidocs/org/apache/kudu/client/CreateTableOptions.html A apidocs/org/apache/kudu/client/Delete.html A apidocs/org/apache/kudu/client/DeleteTableResponse.html A apidocs/org/apache/kudu/client/ExternalConsistencyMode.html A apidocs/org/apache/kudu/client/HasFailedRpcException.html A apidocs/org/apache/kudu/client/Insert.html A apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html A apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html A apidocs/org/apache/kudu/client/KuduClient.html A apidocs/org/apache/kudu/client/KuduException.html A apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html A apidocs/org/apache/kudu/client/KuduPredicate.html A apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html A apidocs/org/apache/kudu/client/KuduScanToken.html A apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html A apidocs/org/apache/kudu/client/KuduScanner.html A apidocs/org/apache/kudu/client/KuduSession.html A apidocs/org/apache/kudu/client/KuduTable.html A apidocs/org/apache/kudu/client/ListTablesResponse.html A apidocs/org/apache/kudu/client/ListTabletServersResponse.html A apidocs/org/apache/kudu/client/LocatedTablet.Replica.html A apidocs/org/apache/kudu/client/LocatedTablet.html A apidocs/org/apache/kudu/client/Operation.html A apidocs/org/apache/kudu/client/OperationResponse.html A apidocs/org/apache/kudu/client/PartialRow.html A apidocs/org/apache/kudu/client/PleaseThrottleException.html A apidocs/org/apache/kudu/client/RangePartitionBound.html A apidocs/org/apache/kudu/client/RowError.html A apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html A apidocs/org/apache/kudu/client/RowResult.html A apidocs/org/apache/kudu/client/RowResultIterator.html A apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html A apidocs/org/apache/kudu/client/SessionConfiguration.html A apidocs/org/apache/kudu/client/Statistics.Statistic.html A apidocs/org/apache/kudu/client/Statistics.html A apidocs/org/apache/kudu/client/Status.html A apidocs/org/apache/kudu/client/Update.html A apidocs/org/apache/kudu/client/Upsert.html A apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html A apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html A apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.ReadMode.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.html A apidocs/org/apache/kudu/client/class-use/AsyncKuduSession.html A apidocs/org/apache/kudu/client/class-use/ColumnRangePredicate.html A apidocs/org/apache/kudu/client/class-use/CreateTableOptions.html A apidocs/org/apache/kudu/client/class-use/Delete.html A apidocs/org/apache/kudu/client/class-use/DeleteTableResponse.h
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 19: Build Started http://104.196.14.100/job/kudu-gerrit/3016/ -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#19). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for the Kudu C++ client library. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if total amount of data for pending operations reaches the buffer size limit. The limit on the buffer size can be set by the KuduSession::SetMutationBufferSpace() method. The background flush logic checks whether at least one of the following two conditions is satisfied to determine whether it's time to flush the accumulated write operations: * The over-the-watermark criterion: check whether the total size of the freshly submitted (i.e. not-yet-scheduled-for-flush) write operations is over the threshold. The threshold can be set as a percentage of the total buffer size using the KuduSession::SetMutationBufferFlushWatermark() method. * The maximum wait time criterion: check whether the current batch of operations has been accumulating for more than the maximum wait time. The maximum wait time can be specified in milliseconds using the KuduSession::SetMutationBufferFlushInterva() method. A KuduSession object uses RPC messenger's thread pool to monitor batches' maximum wait time. This change also addresses the following JIRA issue: KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 --- M python/kudu/tests/test_client.py M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/client/write_op.cc M src/kudu/client/write_op.h 11 files changed, 1,184 insertions(+), 171 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3952/19 -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1571 (follow-up): fix review comments from Mike
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1571 (follow-up): fix review comments from Mike .. KUDU-1571 (follow-up): fix review comments from Mike Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 Reviewed-on: http://gerrit.cloudera.org:8080/4082 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M java/kudu-csd/check_csd_compatibility.py M java/kudu-csd/generate_mdl.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/3015/ -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#18). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for the Kudu C++ client library. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if total amount of data for pending operations reaches the buffer size limit. The limit on the buffer size can be set by the KuduSession::SetMutationBufferSpace() method. The background flush logic checks whether at least one of the following two conditions is satisfied to determine whether it's time to flush the accumulated write operations: * The over-the-watermark criterion: check whether the total size of the freshly submitted (i.e. not-yet-scheduled-for-flush) write operations is over the threshold. The threshold can be set as a percentage of the total buffer size using the KuduSession::SetMutationBufferFlushWatermark() method. * The maximum wait time criterion: check whether the current batch of operations has been accumulating for more than the maximum wait time. The maximum wait time can be specified in milliseconds using the KuduSession::SetMutationBufferFlushInterva() method. A KuduSession object uses RPC messenger's thread pool to monitor batches' maximum wait time. This change also addresses the following JIRA issue: KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 --- M python/kudu/tests/test_client.py M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/client/write_op.cc M src/kudu/client/write_op.h 11 files changed, 1,184 insertions(+), 171 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3952/18 -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1571 (follow-up): fix review comments from Mike
Mike Percy has posted comments on this change. Change subject: KUDU-1571 (follow-up): fix review comments from Mike .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/3014/ -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#17). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for the Kudu C++ client library. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if total amount of data for pending operations reaches the buffer size limit. The limit on the buffer size can be set by the KuduSession::SetMutationBufferSpace() method. The background flush logic checks whether at least one of the following two conditions is satisfied to determine whether it's time to flush the accumulated write operations: * The over-the-watermark criterion: check whether the total size of the freshly submitted (i.e. not-yet-scheduled-for-flush) write operations is over the threshold. The threshold can be set as a percentage of the total buffer size using the KuduSession::SetMutationBufferFlushWatermark() method. * The maximum wait time criterion: check whether the current batch of operations has been accumulating for more than the maximum wait time. The maximum wait time can be specified in milliseconds using the KuduSession::SetMutationBufferFlushInterva() method. A KuduSession object uses RPC messenger's thread pool to monitor batches' maximum wait time. This change also addresses the following JIRA issue: KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 --- M python/kudu/tests/test_client.py M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/client/write_op.cc M src/kudu/client/write_op.h 11 files changed, 1,184 insertions(+), 171 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3952/17 -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Predicate evaluation pushdown
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#3). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown The premise of this patch is to avoid the excessive use of CPU when evaluating column predicates in specific cases. Dictionary blocks, for instance, can evaluate predicates by comparing codewords (UINT32) rather than doing string comparisons. See the performance doc for a look into the performance differences for dictionary encoding and plain encoding: https://github.com/anjuwong/kudu/blob/pred-pushdown/docs/decoder-eval-perf.md See the design-doc for predicate-eval-pushdown for a brief overview of the considered implementations: https://github.com/anjuwong/kudu/blob/sorted-dict-block/docs/design-docs/predicate-eval-pushdown.md This patch uses the predicate-set approach using a bitmap. Change-Id: I31e4cce21e99f63b089d7c84410af8ed914cb576 --- M src/kudu/benchmarks/tpch/tpch_real_world.cc M src/kudu/cfile/binary_dict_block.cc M src/kudu/cfile/binary_dict_block.h M src/kudu/cfile/binary_plain_block.cc M src/kudu/cfile/binary_plain_block.h M src/kudu/cfile/binary_prefix_block.h M src/kudu/cfile/block_encodings.h M src/kudu/cfile/bshuf_block.h M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_reader.h M src/kudu/cfile/gvint_block.h M src/kudu/cfile/plain_bitmap_block.h M src/kudu/cfile/plain_block.h M src/kudu/cfile/rle_block.h A src/kudu/common/column_eval_context.h M src/kudu/common/column_predicate.cc M src/kudu/common/column_predicate.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/generic_iterators.h M src/kudu/common/iterator.h M src/kudu/common/rowblock.h M src/kudu/common/schema.h M src/kudu/common/types.cc M src/kudu/common/types.h M src/kudu/tablet/CMakeLists.txt M src/kudu/tablet/cfile_set.cc M src/kudu/tablet/cfile_set.h M src/kudu/tablet/delta_applier.cc M src/kudu/tablet/delta_applier.h M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltafile.cc M src/kudu/tablet/deltafile.h M src/kudu/tablet/deltamemstore.cc M src/kudu/tablet/deltamemstore.h A src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h 39 files changed, 814 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/3990/3 -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I31e4cce21e99f63b089d7c84410af8ed914cb576 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Predicate evaluation pushdown
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3013/ -- To view, visit http://gerrit.cloudera.org:8080/3990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31e4cce21e99f63b089d7c84410af8ed914cb576 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Convert pbc-dump over to new tool infrastructure
Todd Lipcon has posted comments on this change. Change subject: Convert pbc-dump over to new tool infrastructure .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4037/1/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h: Line 253: // Returns a new "pbc" mode node. > I was thinking that modes would correspond directly to contexts. Which mean I think my preference is for a not overly-deep hierarchy. The nice thing about a relatively flat hierarchy is that you can just run "kudu -help" and see a good list of all the tools, whereas with a deep hierarchy, you'd have to go hunting through "sub menus" to find the tool you're looking for. Another way to think about it is that tools should mostly have the form "kudu " or in some cases "kudu ". Do you disagree? -- To view, visit http://gerrit.cloudera.org:8080/4037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1571 (follow-up): fix review comments from Mike
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4082 to review the following change. Change subject: KUDU-1571 (follow-up): fix review comments from Mike .. KUDU-1571 (follow-up): fix review comments from Mike Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 --- M java/kudu-csd/check_csd_compatibility.py M java/kudu-csd/generate_mdl.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4082/1 -- To view, visit http://gerrit.cloudera.org:8080/4082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1571 (follow-up): fix review comments from Mike
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1571 (follow-up): fix review comments from Mike .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3012/ -- To view, visit http://gerrit.cloudera.org:8080/4082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58175bc77d741474c3d80e202fc1ce96fb02ec55 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL
Todd Lipcon has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 2: Oops, just realized I missed Mike's code review comments above. Will address these in a follow-on -- To view, visit http://gerrit.cloudera.org:8080/4067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/3011/ -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#16). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode Implemented AUTO_FLUSH_BACKGROUND for the Kudu C++ client library. In AUTO_FLUSH_BACKGROUND mode, the KuduSession::Apply() method blocks if total amount of data for pending operations reaches the buffer size limit. The limit on the buffer size can be set by the KuduSession::SetMutationBufferSpace() method. The background flush logic checks whether at least one of the following two conditions is satisfied to determine whether it's time to flush the accumulated write operations: * The over-the-watermark criterion: check whether the total size of the freshly submitted (i.e. not-yet-scheduled-for-flush) write operations is over the threshold. The threshold can be set as a percentage of the total buffer size using the KuduSession::SetMutationBufferFlushWatermark() method. * The maximum wait time criterion: check whether the current batch of operations has been accumulating for more than the maximum wait time. The maximum wait time can be specified in milliseconds using the KuduSession::SetMutationBufferFlushInterva() method. A KuduSession object uses RPC messenger's thread pool to monitor batches' maximum wait time. This change also addresses the following JIRA issue: KUDU-1376 KuduSession::SetMutationBufferSpace is not defined Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 --- M python/kudu/tests/test_client.py M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/session-internal.cc M src/kudu/client/session-internal.h M src/kudu/client/write_op.cc M src/kudu/client/write_op.h 11 files changed, 1,189 insertions(+), 170 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/3952/16 -- To view, visit http://gerrit.cloudera.org:8080/3952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I34905c30b3aad96f53cf7a1822b1cde6d25f33a8 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) new range partitioning features blog post
Dan Burkert has posted comments on this change. Change subject: new range partitioning features blog post .. Patch Set 5: @aserbin, that restriction pretty much still stands, to alter the table schema would be more akin to changing the set of columns in the range partitioning, or changing the number of buckets in a hash partition. It's definitely a subtle difference though, and the schema design guide needs to be updated to take these new features into account. -- To view, visit http://gerrit.cloudera.org:8080/4012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53504d849c2aca9ff613b11e67d1533536283931 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) docs: Add instructions for upgrading to 0.10.0
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4077 Change subject: docs: Add instructions for upgrading to 0.10.0 .. docs: Add instructions for upgrading to 0.10.0 Also add documentation of the caveats involved when attempting to downgrade to an older version of Kudu. Additionally: 1. Fix layout problem with installation page The broken layout had to do with a stray "" before the ".OSX Build Script" section. 2. Fix asciidoc warning messages in index.adoc and release_notes.adoc The warning messages in release_notes.adoc were related to skipping a header level between h1 and h3. So I reduced all headings by one level except for the h1. Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Reviewed-on: http://gerrit.cloudera.org:8080/4069 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon (cherry picked from commit b3371aba3c1bd24e4be56abdb47be9d2cadbd747) --- M docs/index.adoc M docs/installation.adoc M docs/release_notes.adoc 3 files changed, 135 insertions(+), 89 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/4077/1 -- To view, visit http://gerrit.cloudera.org:8080/4077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy
[kudu-CR](branch-0.10.x) docs: Add instructions for upgrading to 0.10.0
Todd Lipcon has submitted this change and it was merged. Change subject: docs: Add instructions for upgrading to 0.10.0 .. docs: Add instructions for upgrading to 0.10.0 Also add documentation of the caveats involved when attempting to downgrade to an older version of Kudu. Additionally: 1. Fix layout problem with installation page The broken layout had to do with a stray "" before the ".OSX Build Script" section. 2. Fix asciidoc warning messages in index.adoc and release_notes.adoc The warning messages in release_notes.adoc were related to skipping a header level between h1 and h3. So I reduced all headings by one level except for the h1. Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Reviewed-on: http://gerrit.cloudera.org:8080/4069 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon (cherry picked from commit b3371aba3c1bd24e4be56abdb47be9d2cadbd747) Reviewed-on: http://gerrit.cloudera.org:8080/4077 Tested-by: Todd Lipcon --- M docs/index.adoc M docs/installation.adoc M docs/release_notes.adoc 3 files changed, 135 insertions(+), 89 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.10.x) docs: Add instructions for upgrading to 0.10.0
Todd Lipcon has posted comments on this change. Change subject: docs: Add instructions for upgrading to 0.10.0 .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) docs: Add instructions for upgrading to 0.10.0
Kudu Jenkins has posted comments on this change. Change subject: docs: Add instructions for upgrading to 0.10.0 .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3010/ -- To view, visit http://gerrit.cloudera.org:8080/4077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) KUDU-1517 Implement doc feedback from Sue M
Todd Lipcon has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) KUDU-1517 Implement doc feedback from Sue M
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3009/ -- To view, visit http://gerrit.cloudera.org:8080/4076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) KUDU-1517 Implement doc feedback from Sue M
Todd Lipcon has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: cherry-picking to the 0.10.x branch so this shows up in our docs when we publish the 0.10 docs -- To view, visit http://gerrit.cloudera.org:8080/4076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) KUDU-1517 Implement doc feedback from Sue M
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1517 Implement doc feedback from Sue M .. KUDU-1517 Implement doc feedback from Sue M Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Reviewed-on: http://gerrit.cloudera.org:8080/3638 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy (cherry picked from commit b5aa19de62650da83ebb145cbedf04bf5b39d352) Reviewed-on: http://gerrit.cloudera.org:8080/4076 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- M docs/index.adoc M docs/release_notes.adoc 2 files changed, 55 insertions(+), 61 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Misty Stanley-Jones Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.10.x) KUDU-1517 Implement doc feedback from Sue M
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4076 Change subject: KUDU-1517 Implement doc feedback from Sue M .. KUDU-1517 Implement doc feedback from Sue M Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Reviewed-on: http://gerrit.cloudera.org:8080/3638 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy (cherry picked from commit b5aa19de62650da83ebb145cbedf04bf5b39d352) --- M docs/index.adoc M docs/release_notes.adoc 2 files changed, 55 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/4076/1 -- To view, visit http://gerrit.cloudera.org:8080/4076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8a7647b3e5d4d36e82e06ce02a45a8811e4efed3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Misty Stanley-Jones
[kudu-CR](branch-0.10.x) KUDU-1571. Generate "deprecated" metrics in MDL
Todd Lipcon has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) KUDU-1571. Generate "deprecated" metrics in MDL
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. KUDU-1571. Generate "deprecated" metrics in MDL This checks in the "--dump_metrics_json" output from already-released versions, and changes the generate_mdl.py script so that any metrics which were ever present in an earlier version are carried through to the current version of the MDL, but marked as deprecated. This works around an issue in which Cloudera Manager doesn't properly handle the removal of metrics. Namely, if a dashboard (user-generated or built-in) references a removed metric, it will produce an NPE. This will now become part of the release process: after a release, we should check in the output of 'dump_metrics_json' so that the metrics in that release will be carried forward. I verified the results using both the newly included 'check_csd_compatibility' script as well as installing a newly built 0.10.x CSD on a cluster. Whereas the tablet server status page was previously broken, now it shows the remote bootstrap metrics as DEPRECATED. Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Reviewed-on: http://gerrit.cloudera.org:8080/4067 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy (cherry picked from commit 062996ad7d1c3aa90cd9ea5ec11b73dc17e085d6) Reviewed-on: http://gerrit.cloudera.org:8080/4075 Reviewed-by: Todd Lipcon Tested-by: Todd Lipcon --- M build-support/release/rat_exclude_files.txt A java/kudu-csd/check_csd_compatibility.py M java/kudu-csd/generate_mdl.py A java/kudu-csd/old-version-metrics/0.10.0-master.json A java/kudu-csd/old-version-metrics/0.10.0-tserver.json A java/kudu-csd/old-version-metrics/0.9.1-master.json A java/kudu-csd/old-version-metrics/0.9.1-tserver.json 7 files changed, 4,831 insertions(+), 17 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/4075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.10.x) KUDU-1571. Generate "deprecated" metrics in MDL
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3008/ -- To view, visit http://gerrit.cloudera.org:8080/4075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.10.x) KUDU-1571. Generate "deprecated" metrics in MDL
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4075 Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. KUDU-1571. Generate "deprecated" metrics in MDL This checks in the "--dump_metrics_json" output from already-released versions, and changes the generate_mdl.py script so that any metrics which were ever present in an earlier version are carried through to the current version of the MDL, but marked as deprecated. This works around an issue in which Cloudera Manager doesn't properly handle the removal of metrics. Namely, if a dashboard (user-generated or built-in) references a removed metric, it will produce an NPE. This will now become part of the release process: after a release, we should check in the output of 'dump_metrics_json' so that the metrics in that release will be carried forward. I verified the results using both the newly included 'check_csd_compatibility' script as well as installing a newly built 0.10.x CSD on a cluster. Whereas the tablet server status page was previously broken, now it shows the remote bootstrap metrics as DEPRECATED. Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Reviewed-on: http://gerrit.cloudera.org:8080/4067 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy (cherry picked from commit 062996ad7d1c3aa90cd9ea5ec11b73dc17e085d6) --- M build-support/release/rat_exclude_files.txt A java/kudu-csd/check_csd_compatibility.py M java/kudu-csd/generate_mdl.py A java/kudu-csd/old-version-metrics/0.10.0-master.json A java/kudu-csd/old-version-metrics/0.10.0-tserver.json A java/kudu-csd/old-version-metrics/0.9.1-master.json A java/kudu-csd/old-version-metrics/0.9.1-tserver.json 7 files changed, 4,831 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/4075/1 -- To view, visit http://gerrit.cloudera.org:8080/4075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.10.x Gerrit-Owner: Todd Lipcon
[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. KUDU-1571. Generate "deprecated" metrics in MDL This checks in the "--dump_metrics_json" output from already-released versions, and changes the generate_mdl.py script so that any metrics which were ever present in an earlier version are carried through to the current version of the MDL, but marked as deprecated. This works around an issue in which Cloudera Manager doesn't properly handle the removal of metrics. Namely, if a dashboard (user-generated or built-in) references a removed metric, it will produce an NPE. This will now become part of the release process: after a release, we should check in the output of 'dump_metrics_json' so that the metrics in that release will be carried forward. I verified the results using both the newly included 'check_csd_compatibility' script as well as installing a newly built 0.10.x CSD on a cluster. Whereas the tablet server status page was previously broken, now it shows the remote bootstrap metrics as DEPRECATED. Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Reviewed-on: http://gerrit.cloudera.org:8080/4067 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M build-support/release/rat_exclude_files.txt A java/kudu-csd/check_csd_compatibility.py M java/kudu-csd/generate_mdl.py A java/kudu-csd/old-version-metrics/0.10.0-master.json A java/kudu-csd/old-version-metrics/0.10.0-tserver.json A java/kudu-csd/old-version-metrics/0.9.1-master.json A java/kudu-csd/old-version-metrics/0.9.1-tserver.json 7 files changed, 4,831 insertions(+), 17 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL
Todd Lipcon has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: To fill in anyone following along, adar and I had an offline discussion about this over the weekend (he was mostly AFK). The gist is that he doesn't like this change but willing to take it as a temporary workaround until CM has some releases which avoid this problem. -- To view, visit http://gerrit.cloudera.org:8080/4067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: Add instructions for upgrading to 0.10.0
Todd Lipcon has submitted this change and it was merged. Change subject: docs: Add instructions for upgrading to 0.10.0 .. docs: Add instructions for upgrading to 0.10.0 Also add documentation of the caveats involved when attempting to downgrade to an older version of Kudu. Additionally: 1. Fix layout problem with installation page The broken layout had to do with a stray "" before the ".OSX Build Script" section. 2. Fix asciidoc warning messages in index.adoc and release_notes.adoc The warning messages in release_notes.adoc were related to skipping a header level between h1 and h3. So I reduced all headings by one level except for the h1. Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Reviewed-on: http://gerrit.cloudera.org:8080/4069 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M docs/index.adoc M docs/installation.adoc M docs/release_notes.adoc 3 files changed, 135 insertions(+), 89 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: Add instructions for upgrading to 0.10.0
Todd Lipcon has posted comments on this change. Change subject: docs: Add instructions for upgrading to 0.10.0 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86e071efcda05b017776a7de4f64eb6f1b12cd3 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1571. Generate "deprecated" metrics in MDL
Adar Dembo has posted comments on this change. Change subject: KUDU-1571. Generate "deprecated" metrics in MDL .. Patch Set 1: -Code-Review Removing my -1 based on our discussion. -- To view, visit http://gerrit.cloudera.org:8080/4067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I121203d781ab593cb94d7248d164cdad7bf26e78 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
