[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-01 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#44). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-06-01 Thread Andrew Wong (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#43). Change subject: KUDU-1952 Remove round-robin for block placement ..

[kudu-CR] tablet: Get rid of TabletStatusListener

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: tablet: Get rid of TabletStatusListener .. tablet: Get rid of TabletStatusListener There is no need for this interface. We don't have a circular ownership

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 1: (2 comments) I think this is a good idea because it's a relatively safe thing and we should

[kudu-CR] tool: add a 'pbc edit' command

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/tool_action_pbc.cc File

[kudu-CR] tablet: Get rid of TabletStatusListener

2017-06-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet: Get rid of TabletStatusListener .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7039 To unsubscribe, visit

[kudu-CR] WIP: Add basic Hive MetaStore client

2017-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/7053 Change subject: WIP: Add basic Hive MetaStore client .. WIP: Add basic Hive MetaStore client This is a work-in-progress patch to create a

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/6845/16/src/kudu/fs/fs_manager.h File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.cc

[kudu-CR] ts recovery-itest: bump timeouts

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ts_recovery-itest: bump timeouts .. ts_recovery-itest: bump timeouts In TSAN mode this test seems to be relatively flaky due to not crashing within the

[kudu-CR] Add a workaround for LSAN bug #757

2017-06-01 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7052 to review the following change. Change subject: Add a workaround for LSAN bug #757 .. Add a workaround for LSAN bug

[kudu-CR] tablet: Get rid of TabletStatusListener

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet: Get rid of TabletStatusListener .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7039/2/src/kudu/tablet/tablet_replica.h File

[kudu-CR] ts recovery-itest: bump timeouts

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: ts_recovery-itest: bump timeouts .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7050 To unsubscribe, visit

[kudu-CR] tool: add a 'pbc edit' command

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: add a 'pbc edit' command .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7048/1/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] ts recovery-itest: bump timeouts

2017-06-01 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7050 to review the following change. Change subject: ts_recovery-itest: bump timeouts .. ts_recovery-itest: bump timeouts

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. Patch Set 1: curious whether you think this is still useful considering the 'kudu pbc edit' that I also have

[kudu-CR] tool: add a 'local-replica cmeta set-term' tool

2017-06-01 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7049 to review the following change. Change subject: tool: add a 'local-replica cmeta set-term' tool .. tool: add a

[kudu-CR] tool: add a 'pbc edit' command

2017-06-01 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7048 to review the following change. Change subject: tool: add a 'pbc edit' command .. tool: add a 'pbc edit' command This

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.h

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/tablet/diskrowset.h File

[kudu-CR](gh-pages) WIP: Kudu Consistency Blog Post Pt1

2017-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: WIP: Kudu Consistency Blog Post Pt1 .. Patch Set 3: (30 comments) http://gerrit.cloudera.org:8080/#/c/7019/3/_posts/2017-05-30-kudu-consistency-pt1.md File

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

2017-06-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. [consensus_queue] fix race in UpdateLagMetrics() TSAN reports warnings on races on writing/reading

[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus

2017-06-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus .. [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus Stop injecting a

[kudu-CR] tablet: Get rid of TabletStatusListener

2017-06-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tablet: Get rid of TabletStatusListener .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7039/2/src/kudu/tablet/tablet_replica.h File

[kudu-CR] [consensus queue] fix race in UpdateLagMetrics()

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [consensus_queue] fix race in UpdateLagMetrics() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7032 To unsubscribe, visit

[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7017 To

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: > Uploaded patch set 6. This is still going to change quite a bit when all of Mike's

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#6). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] consensus: Remove Consensus interface

2017-06-01 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7040 to look at the new patch set (#2). Change subject: consensus: Remove Consensus interface ..

[kudu-CR] tablet: Get rid of TabletStatusListener

2017-06-01 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7039 to look at the new patch set (#2). Change subject: tablet: Get rid of TabletStatusListener .. tablet: Get rid of

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#5). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] tablet: Get rid of TabletStatusListener

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet: Get rid of TabletStatusListener .. Patch Set 1: Ignoring Tidy comments since they're unrelated -- To view, visit http://gerrit.cloudera.org:8080/7039 To

[kudu-CR] consensus: Add DCHECK(is locked()) in all unlocked methods

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: Add DCHECK(is_locked()) in all unlocked methods .. consensus: Add DCHECK(is_locked()) in all unlocked methods Now that RaftConsensus owns

[kudu-CR] consensus: Get rid of LockFor*() methods

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7012/8/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] consensus: Get rid of LockFor*() methods

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: Get rid of LockFor*() methods .. consensus: Get rid of LockFor*() methods Simplify the locking logic by removing layers of abstraction. Also

[kudu-CR] consensus: Get rid of LockFor*() methods

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7012 To unsubscribe, visit

[kudu-CR] consensus: Get rid of LockFor*() methods

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7012/8/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] consensus: Get rid of LockFor*() methods

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7012/8/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] consensus: Get rid of LockFor*() methods

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7012/8/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. [tools] Use PrintTable to format ksck's consensus matrix The first version of ksck's

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7043 To unsubscribe,

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7043 To unsubscribe,

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7043 to look at the new patch set (#2). Change subject: [tools] Use PrintTable to format ksck's consensus matrix ..

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7043/1/src/kudu/tools/ksck.cc File

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. Patch Set 1: (2 comments) Nice, just a few style nits. I'd be in favor of cherry-picking this to

[kudu-CR] [tools] Use PrintTable to format ksck's consensus matrix

2017-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/7043 Change subject: [tools] Use PrintTable to format ksck's consensus matrix .. [tools] Use PrintTable to format ksck's consensus matrix

[kudu-CR] external minicluster: expand EMC dir usage

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: external minicluster: expand EMC dir usage .. Patch Set 16: (6 comments)

[kudu-CR] consensus: Remove Consensus interface

2017-06-01 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7040 to review the following change. Change subject: consensus: Remove Consensus interface .. consensus: