[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-30 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9783 to look at the new patch set (#11). Change subject: KUDU-16 pt 1: add server-side limits on scanners

[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9871 ) Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems .. docs: add troubleshooting info on

[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9871 ) Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-30 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9835 to look at the new patch set (#4). Change subject: KUDU-2384. Don't collect thread stacks when running under debugger

[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9871 ) Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems .. Patch Set 1: (1 comment)

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9760 ) Change subject: meta_cache: improve multi-threaded scalability .. meta_cache: improve multi-threaded scalability When profiling

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9867 ) Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow .. KUDU-2361. Fix flaky

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9867

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9867 ) Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow .. Patch Set 2: Verified+1 -- To view, visit

[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems

2018-03-30 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9871 ) Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 ) Change subject: KUDU-16 pt 1: add server-side limits on scanners .. Patch Set 10: (1 comment)

[kudu-CR] thirdparty: add patch to fix printing large span stats in /memz

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9870 ) Change subject: thirdparty: add patch to fix printing large span stats in /memz .. thirdparty: add patch to fix printing large

[kudu-CR] docs: add troubleshooting info on detecting ext2 and ext3 filesystems

2018-03-30 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9871 to review the following change. Change subject: docs: add troubleshooting info on detecting ext2 and ext3 filesystems

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 ) Change subject: KUDU-16 pt 1: add server-side limits on scanners .. Patch Set 10: (1 comment)

[kudu-CR] thirdparty: add patch to fix printing large span stats in /memz

2018-03-30 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9870 ) Change subject: thirdparty: add patch to fix printing large span stats in /memz .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] thirdparty: add patch to fix printing large span stats in /memz

2018-03-30 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9870 to review the following change. Change subject: thirdparty: add patch to fix printing large span stats in /memz ..

[kudu-CR] KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9863 ) Change subject: KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 ) Change subject: KUDU-16 pt 1: add server-side limits on scanners .. Patch Set 10: (1 comment)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 7: (1 comment)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-30 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9372 to look at the new patch set (#7). Change subject: rowset_metadata: cache min/max encoded keys

[kudu-CR] KUDU-2191 (7/n): HmsCatalog

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9862 ) Change subject: KUDU-2191 (7/n): HmsCatalog .. Patch Set 2: (14 comments) The IWYU failures are weird; could you bug Alexey?

[kudu-CR] KUDU-2191 (6/n): Fixups to the C++ HMS client

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9861 ) Change subject: KUDU-2191 (6/n): Fixups to the C++ HMS client .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 3: > > That said, the test in question

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration .. Patch Set 10: (7 comments)

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 3: > Patch Set 3: > That said, the test

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9867 ) Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9867 ) Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9867 to look at the new patch set (#2). Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9864 ) Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. Patch Set 3: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9864 ) Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot This test was

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-30 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9864 to look at the new patch set (#3). Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot ..

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9864 ) Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9866 ) Change subject: KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp .. KUDU-2388. Fix TSAN race in

[kudu-CR] KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp

2018-03-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9866 ) Change subject: KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9867 ) Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9866 ) Change subject: KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9864 ) Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2293 fix cleanup after failed copies

2018-03-30 Thread Andrew Wong (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9452 to look at the new patch set (#5). Change subject: KUDU-2293 fix cleanup after failed copies ..

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 ) Change subject: KUDU-16 pt 1: add server-side limits on scanners .. Patch Set 9: (7 comments)

[kudu-CR] KUDU-16 pt 2: add client-side limits on scanners

2018-03-30 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9790 to look at the new patch set (#5). Change subject: KUDU-16 pt 2: add client-side limits on scanners