[kudu-CR] Release notes for the Java client in 1.1

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Release notes for the Java client in 1.1 .. Release notes for the Java client in 1.1 Change-Id: Idf04d1db4769e19e6421628bbe980cb4c058c62c Reviewed-

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java] Add checkstyle coverage to Java build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5016/1/java/kudu_style.xml File java/kudu_styl

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4930 To unsubscribe, vis

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 7: Code-Review+2 -- To view, visit htt

[kudu-CR] log block manager: fix when append exceeds preallocated space

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: log block manager: fix when append exceeds preallocated space .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5024 To unsub

[kudu-CR] Check sanity of standard file descriptors when starting daemons

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Check sanity of standard file descriptors when starting daemons .. Patch Set 1: Code-Review+1 All java tests pass on macOS with this patch, as they should.

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5031/1/java/kudu-client/src/test/ja

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4989 To unsubscrib

[kudu-CR] KUDU-180. Fix handling of defaults when creating tables

2016-11-10 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-180. Fix handling of defaults when creating tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5031 To unsubscribe

[kudu-CR] Bump version to 1.2.0-SNAPSHOT

2016-11-12 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5060 to review the following change. Change subject: Bump version to 1.2.0-SNAPSHOT .. Bump version to 1.2.0-SNAPSHOT Chan

[kudu-CR] Bump version to 1.2.0-SNAPSHOT

2016-11-13 Thread Jean-Daniel Cryans (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5060 to look at the new patch set (#2). Change subject: Bump version to 1.2.0-SNAPSHOT .. Bump version to 1

[kudu-CR] Bump version to 1.2.0-SNAPSHOT

2016-11-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Bump version to 1.2.0-SNAPSHOT .. Bump version to 1.2.0-SNAPSHOT Change-Id: I624b7fa917abab0b29daf657714ebe976e48b46e Reviewed-on: http://gerrit.cl

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java] Add checkstyle coverage to Java build .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5016 To unsubscribe, visit htt

[kudu-CR] Fix RAT issues for 1.1

2016-11-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix RAT issues for 1.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5075 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR](branch-1.1.x) Fix RAT issues for 1.1

2016-11-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix RAT issues for 1.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5076 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR](branch-1.1.x) Change version in branch to non-SNAPSHOT

2016-11-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Change version in branch to non-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5077 To unsubscribe, visit http://

[kudu-CR] Release note updates for 1.1

2016-11-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release note updates for 1.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5079 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/4996/8//COMMIT_MSG Commit Message: Line 23: WIPish: This

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4934 To unsubscribe, visit

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4993/2/src/kudu

[kudu-CR] Reject CREATE TABLE ops with even replication factor

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4945/5//COMMIT_MSG Commit Message: L

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4934 To unsubscribe, visit

[kudu-CR] java-client: clean up intermediate tables in TestKuduTable

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java-client: clean up intermediate tables in TestKuduTable .. Patch Set 1: So what was the issue? -- To view, visit http://gerrit.cloudera.org:8080/5112 T

[kudu-CR] java-client: clean up intermediate tables in TestKuduTable

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java-client: clean up intermediate tables in TestKuduTable .. Patch Set 1: Should we just have a "delete all tables" after test method then? -- To view, v

[kudu-CR] java-client: clean up intermediate tables in TestKuduTable

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java-client: clean up intermediate tables in TestKuduTable .. Patch Set 1: > We pretty routinely create test tables and don't clean them up, > this is some

[kudu-CR] java-client: fix test execution-order race in TestKuduTable

2016-11-16 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java-client: fix test execution-order race in TestKuduTable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5113 To unsubsc

[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions

2016-11-17 Thread Jean-Daniel Cryans (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5130 to review the following change. Change subject: [docs] Add krb5-devel to the SLES12 instructions .. [docs

[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions

2016-11-17 Thread Jean-Daniel Cryans (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5130 to look at the new patch set (#2). Change subject: [docs] Add krb5-devel to the SLES12 instructions ..

[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions

2016-11-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Add krb5-devel to the SLES12 instructions .. Patch Set 1: (1 comment) > (2 comments) > > I bet you need the equivalent of krb5-devel in the other

[kudu-CR](gh-pages) Add 1.1.0 release docs

2016-11-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 1.1.0 release docs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5160 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 1: (1 comment) Can you add tests for this? http://gerrit.cloudera.org:8080/#/c/5188/1/

[kudu-CR] [java client] fixed typo in AsyncKuduScanner

2016-11-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] fixed typo in AsyncKuduScanner .. [java client] fixed typo in AsyncKuduScanner Removed an extra call to NewScanRequestPB.Builder::set

[kudu-CR] [java client] fixed typo in AsyncKuduScanner

2016-11-22 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] fixed typo in AsyncKuduScanner .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5174 To unsubscribe, visit htt

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 2: Code-Review+2 I like the version where we don't

[kudu-CR] WIP workaround for KUDU-1524

2016-12-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has abandoned this change. Change subject: WIP workaround for KUDU-1524 .. Abandoned Todd wrote a new workaround. -- To view, visit http://gerrit.cloudera.org:8080/3621 To unsubscribe, visit http://gerrit.c

[kudu-CR] KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1789. Fix ScannerKeepAlive leaking RPCs when scanner is already expired .. Patch Set 1: Code-Review+2 Really nice find. -- To view, visit http://ger

[kudu-CR] client: don't log retriable scanner errors

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: client: don't log retriable scanner errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5380 To unsubscribe, visit http:

[kudu-CR] Update partition syntax for single value range partitions

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update partition syntax for single value range partitions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5368 To unsubscri

[kudu-CR] [docs] Add krb5-devel to the SLES12 instructions

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Add krb5-devel to the SLES12 instructions .. Patch Set 2: > This is still relevant. We discussed it on slack on November 17th > around 12:45pm. Th

[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions

2016-12-06 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5130 to look at the new patch set (#3). Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions ..

[kudu-CR] Reduce default client tablet locations cache TTL

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reduce default client tablet locations cache TTL .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5397 To unsubscribe, visit

[kudu-CR] [java] KUDU-1746/KUDU-1747 Improve addColumn API

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java] KUDU-1746/KUDU-1747 Improve addColumn API .. [java] KUDU-1746/KUDU-1747 Improve addColumn API Previously, the java client permitted adding

[kudu-CR] [java] KUDU-1746/KUDU-1747 Improve addColumn API

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java] KUDU-1746/KUDU-1747 Improve addColumn API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5132 To unsubscribe, visit

[kudu-CR] [build] Update syntax of gen version info.py

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [build] Update syntax of gen_version_info.py .. [build] Update syntax of gen_version_info.py Got bit by a SyntaxError here while accidentally build

[kudu-CR] [build] Update syntax of gen version info.py

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [build] Update syntax of gen_version_info.py .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5396 To unsubscribe, visit htt

[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions .. [docs] Add missing krb deps to the SLES12 and Ubuntu instructions Change-Id:

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5420 Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Revert "KUDU-861 Support changing default, storage

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Patch Set 1: Thanks Will, like we discussed on Slack let's put up this patch again when it

[kudu-CR] Revert "KUDU-861 Support changing default, storage attributes"

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Revert "KUDU-861 Support changing default, storage attributes" .. Revert "KUDU-861 Support changing default, storage attributes" This reverts commi

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1757: add PartialRow.toString .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5237/7/java/kudu-client/src/test/java/org/apache/kudu/cl

[kudu-CR] KUDU-1757: add PartialRow.toString

2016-12-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1757: add PartialRow.toString .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit

[kudu-CR](branch-1.2.x) KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5

[kudu-CR](branch-1.2.x) KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address .. KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard addres

[kudu-CR] KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5443

[kudu-CR] csd: two minor changes

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: csd: two minor changes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5435 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] csd: two minor changes

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: csd: two minor changes .. csd: two minor changes Revert the memory limit scaleFactor to the default value (1.0). 1.3 is recommended for Java proces

[kudu-CR](branch-1.2.x) csd: two minor changes

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: csd: two minor changes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5450 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR](branch-1.2.x) csd: two minor changes

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5450 Change subject: csd: two minor changes .. csd: two minor changes Revert the memory limit scaleFactor to the default value (1.0). 1.

[kudu-CR](branch-1.2.x) KUDU-1798: [env] File manager broken on OS X 10.11

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1798: [env] File manager broken on OS X 10.11 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5452 To unsubscribe, vis

[kudu-CR](branch-1.2.x) KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging

2016-12-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1799: AsyncKuduClient.discoverTablets has very expensive logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5451

[kudu-CR] push to asf.py: Use check output() from kudu util

2016-12-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: push_to_asf.py: Use check_output() from kudu_util .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5469 To unsubscribe, visi

[kudu-CR] KUDU-1767. Add java test for client operation interleaving

2016-12-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1767. Add java test for client operation interleaving .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5465/2/java/kudu-client/src/tes

[kudu-CR] KUDU-1806. java: fetching scan tokens should fetch larger batches

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1806. java: fetching scan tokens should fetch larger batches .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5498 To

[kudu-CR] java: don't preallocate log segments in java tests

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: java: don't preallocate log segments in java tests .. java: don't preallocate log segments in java tests This disables log segment preallocation fo

[kudu-CR] java: don't preallocate log segments in java tests

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: don't preallocate log segments in java tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5499 To unsubscribe, vis

[kudu-CR] KUDU-1806. java: fetching scan tokens should fetch larger batches

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1806. java: fetching scan tokens should fetch larger batches .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5498 To

[kudu-CR](branch-1.2.x) Remove gcc/libstdcxx from thirdparty/LICENSE.txt

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Remove gcc/libstdcxx from thirdparty/LICENSE.txt .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5509 To unsubscribe, visit

[kudu-CR](branch-1.2.x) Modify the default value of log dir flag.

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Modify the default value of log_dir flag. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5511 To unsubscribe, visit http:/

[kudu-CR](branch-1.2.x) macOS: update brew install instructions

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: macOS: update brew install instructions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5514 To unsubscribe, visit http://g

[kudu-CR](branch-1.2.x) docs: fix gflag name

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: fix gflag name .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5510 To unsubscribe, visit http://gerrit.cloudera.org:

[kudu-CR](branch-1.2.x) KUDU-1801: catalog manager: change TableInfo lock to a rwlock

2016-12-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1801: catalog_manager: change TableInfo lock to a rwlock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5512 To unsub

[kudu-CR](branch-1.2.x) KUDU-1806. java: fetching scan tokens should fetch larger batches

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1806. java: fetching scan tokens should fetch larger batches .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5516 To

[kudu-CR](branch-1.2.x) KUDU-1806. java: fetching scan tokens should fetch larger batches

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1806. java: fetching scan tokens should fetch larger batches .. KUDU-1806. java: fetching scan tokens should fetch larger batches This change

[kudu-CR](branch-1.2.x) KUDU-1775 (part 3): enforce max cell size and max PK size

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1775 (part 3): enforce max cell size and max PK size .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5513 To unsubscri

[kudu-CR](branch-1.2.x) KUDU-1775 (part 3): enforce max cell size and max PK size

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1775 (part 3): enforce max cell size and max PK size .. KUDU-1775 (part 3): enforce max cell size and max PK size This adds limits on the size

[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5521 Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key .. KUDU-1775 (fixup): fix error message for too-large

[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key .. Patch Set 1: Pulling this patch in since it fixes the previous patch in this branch. --

[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key .. KUDU-1775 (fixup): fix error message for too-large encoded key The previous patch

[kudu-CR](branch-1.2.x) KUDU-1775 (fixup): fix error message for too-large encoded key

2016-12-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1775 (fixup): fix error message for too-large encoded key .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5521 To unsu

[kudu-CR](branch-1.2.x) spark: continue scanning after encountering empty batch

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: spark: continue scanning after encountering empty batch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5541 To unsubscribe

[kudu-CR](branch-1.2.x) spark: continue scanning after encountering empty batch

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: spark: continue scanning after encountering empty batch .. spark: continue scanning after encountering empty batch The Spark connector would previo

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5549 Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812: don't log user data in the Java client I manually i

[kudu-CR] KUDU-1812: redact sensitive partition keys from logs

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: redact sensitive partition keys from logs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5548 To unsubscribe, v

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5549 to look at the new patch set (#2). Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812:

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5549/1/java/kudu-client/src/main/java/or

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5549/2/java/kudu-client/src/main/java/org

[kudu-CR] [java-client] add missing check for open client

2017-01-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] add missing check for open client .. Patch Set 1: > Somehow the buffers are not flushed by the time the close() method > returns, and from a

[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ

2017-01-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5601 To unsubscr

[kudu-CR](gh-pages) KUDU-1818. Add link to Cloudera training in FAQ

2017-01-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1818. Add link to Cloudera training in FAQ .. KUDU-1818. Add link to Cloudera training in FAQ Additionally I snuck in a formatting fix I notic

[kudu-CR] Restructure release notes in preparation for 1.2 release

2017-01-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 1: (3 comments) Mind also generating site we can look at while reviewing? http://ger

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5604/2/docs/release_notes.adoc File

[kudu-CR] KUDU-1733. Update consistency semantics doc

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1733. Update consistency semantics doc .. Patch Set 1: I didn't do a diff but did you look at https://gerrit.cloudera.org/#/c/1504/ ? -- To view, vis

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 2: Do you have a rendering? -- To view, visit http://gerrit.cloudera.org:8080/5604 To

[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5612 Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml .. KUDU-1817. Fix kudu-spark2 artifactId in pom.xml kudu-spark2 po

[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml

2017-01-05 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml .. KUDU-1817. Fix kudu-spark2 artifactId in pom.xml kudu-spark2 pom.xml is malformed due to a mave

[kudu-CR] Initial draft of release notes and doc updates for 1.2

2017-01-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Initial draft of release notes and doc updates for 1.2 .. Patch Set 2: (1 comment) Got my own rendering and saw one issue. http://gerrit.cloudera.org:8080

[kudu-CR] Restructure release notes in preparation for 1.2 release

2017-01-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Restructure release notes in preparation for 1.2 release .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5602 To unsubscrib

[kudu-CR] KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart

2017-01-06 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1741: Make MiniCluster and ExternalMiniCluster follow one semantic for Restart .. Patch Set 1: Intuitively restart means "stop then start" for me, and

<    4   5   6   7   8   9   10   >