[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review) 
Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..

[Java] Use Yetus annotations in place of @VisibleForTesting

We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).

kudu-hive is an exception to the rule because it can not
have any dependencies that are not provided by the
hive-metastore. This limitation is noted in the kudu-hive
build files.

I also elimated an uneccesary usage of ImmutableList
and Lists while making this change. Scala has
straightforward syntax for making lists without Guava.

The primary reason for this change is to use
Yetus as the single annotation library for defining
InterfaceAudience, but this has the added benefit
of eliminating any Guava use in kudu-spark,
kudu-spark-tools which didn’t
have Gauva marked as a dependency.

Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Reviewed-on: http://gerrit.cloudera.org:8080/10077
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
Reviewed-by: Dan Burkert 
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
25 files changed, 51 insertions(+), 64 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, but someone else must approve
  Dan Burkert: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle
File java/kudu-spark-tools/build.gradle:

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle@34
PS7, Line 34:   provided libs.yetusAnnotations
> oh yeah, I should comment on this. Scala is noisy about missing annotations
Scratch that. It's only a problem if the dependency is not defined at all. The 
next patch in my series makes this optional.


http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/pom.xml@92
PS7, Line 92: provided
> likewise
The next patch in my series makes this optional.



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 19 Apr 2018 19:40:36 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle
File java/kudu-spark-tools/build.gradle:

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle@34
PS7, Line 34:   provided libs.yetusAnnotations
> Seems like this should either be compile or optional.  Who would be providi
oh yeah, I should comment on this. Scala is noisy about missing annotations 
that it stubs. So I used provided to make it available on the classpath, but 
prevent it from being a downstream dependency.



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 19 Apr 2018 19:35:48 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 7: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle
File java/kudu-spark-tools/build.gradle:

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/build.gradle@34
PS7, Line 34:   provided libs.yetusAnnotations
Seems like this should either be compile or optional.  Who would be providing 
it?


http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

http://gerrit.cloudera.org:8080/#/c/10077/7/java/kudu-spark-tools/pom.xml@92
PS7, Line 92: provided
likewise



-- 
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 19 Apr 2018 18:53:12 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 7: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 19 Apr 2018 16:59:09 +
Gerrit-HasComments: No

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-19 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10077/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/6//COMMIT_MSG@10
PS6, Line 10: This patch replaces Guava’s @VisibleForTesting with
: @InterfaceAudience.LimitedPrivate("Test”).
> Should comment on the exception for kudu-hive.
Done



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 19 Apr 2018 13:25:26 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-18 Thread Grant Henke (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10077

to look at the new patch set (#7).

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..

[Java] Use Yetus annotations in place of @VisibleForTesting

We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).

kudu-hive is an exception to the rule because it can not
have any dependencies that are not provided by the
hive-metastore. This limitation is noted in the kudu-hive
build files.

I also elimated an uneccesary usage of ImmutableList
and Lists while making this change. Scala has
straightforward syntax for making lists without Guava.

The primary reason for this change is to use
Yetus as the single annotation library for defining
InterfaceAudience, but this has the added benefit
of eliminating any Guava use in kudu-spark,
kudu-spark-tools which didn’t
have Gauva marked as a dependency.

Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
25 files changed, 51 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/10077/7
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-18 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10077/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/6//COMMIT_MSG@10
PS6, Line 10: This patch replaces Guava’s @VisibleForTesting with
: @InterfaceAudience.LimitedPrivate("Test”).
Should comment on the exception for kudu-hive.



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Wed, 18 Apr 2018 19:22:59 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-17 Thread Grant Henke (Code Review) 
Grant Henke has removed a vote on this change.

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-17 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Tue, 17 Apr 2018 21:03:27 +
Gerrit-HasComments: No

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-17 Thread Grant Henke (Code Review) 
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10077

to look at the new patch set (#5).

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..

[Java] Use Yetus annotations in place of @VisibleForTesting

We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).

I also elimated an uneccesary usage of ImmutableList
and Lists while making this change. Scala has
straightforward syntax for making lists without Guava.

The primary reason for this change is to use
Yetus as the single annotation library for defining
InterfaceAudience, but this has the added benefit
of eliminating any Guava use in kudu-spark,
kudu-spark-tools which didn’t
have Gauva marked as a dependency.

Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
25 files changed, 51 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/10077/5
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 4: Code-Review+1

(2 comments)

I'd also like Dan to review this.

http://gerrit.cloudera.org:8080/#/c/10077/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/3//COMMIT_MSG@10
PS3, Line 10: This patch replaces Guava’s @VisibleForTesting with
: @InterfaceAudience.LimitedPrivate("Test”)
> I think we can blacklist modules from being used via checkstyle. I can make
Sounds good to me.


http://gerrit.cloudera.org:8080/#/c/10077/3//COMMIT_MSG@19
PS3, Line 19: eliminating any Guava use in kudu-spark,
: kudu-spark-tools and kudu-hive which didn’t
: have Gauva marked as a dependency
> We can be strict about using undeclared dependencies. Something we probably
Okay.



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:44:19 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10077/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/3//COMMIT_MSG@10
PS3, Line 10: This patch replaces Guava’s @VisibleForTesting with
: @InterfaceAudience.LimitedPrivate("Test”)
How can we enforce that new @VisibleForTesting instances don't find their way 
back into the code?


http://gerrit.cloudera.org:8080/#/c/10077/3//COMMIT_MSG@19
PS3, Line 19: eliminating any Guava use in kudu-spark,
: kudu-spark-tools and kudu-hive which didn’t
: have Gauva marked as a dependency
How can we enforce that Guava usage doesn't return? Clearly the missing 
dependency didn't break the build...


http://gerrit.cloudera.org:8080/#/c/10077/3/java/kudu-spark-tools/pom.xml
File java/kudu-spark-tools/pom.xml:

http://gerrit.cloudera.org:8080/#/c/10077/3/java/kudu-spark-tools/pom.xml@51
PS3, Line 51: org.apache.yetus
Not provided scope like for kudu-hive?



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:21:21 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Grant Henke (Code Review) 
Hello Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10077

to look at the new patch set (#3).

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..

[Java] Use Yetus annotations in place of @VisibleForTesting

We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).

I also elimated an uneccesary usage of ImmutableList
and Lists while making this change.

The primary reason for this change is to use
Yetus as the single annotation library for defining
InterfaceAudience, but this has the added benefit
of eliminating any Guava use in kudu-spark,
kudu-spark-tools and kudu-hive which didn’t
have Gauva marked as a dependency.

Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-hive/build.gradle
M java/kudu-hive/pom.xml
M 
java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M 
java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
29 files changed, 71 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/10077/3
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10077/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/1//COMMIT_MSG@18
PS1, Line 18: have Gauva marked as a dependency.
> what's the advantage of eliminating guava usage? don't we shade it anyway?
It wasn't a primary goal, just something I noticed when making this change. I 
have updated the commit message to make that more clear.

The change to not use Guava was smaller than a change to add it as a 
dependency. And since it's not really used a lot I didn't see a reason to keep 
it.

We actually weren't shading Guava in kudu-spark, kudu-spark-tools or kudu-hive. 
I think that's mostly because they weren't listed as dependencies and were 
pulled in transitively.

Even if we shade Guava while we continue to use Maven as our build tool we can 
still get weird compatibility issues due to Mavens shading order issues. I am 
trying to finish up the Gradle work asap so that's no longer a problem.



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:03:37 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Grant Henke (Code Review) 
Hello Kudu Jenkins, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10077

to look at the new patch set (#2).

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..

[Java] Use Yetus annotations in place of @VisibleForTesting

We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).

I also elimated an uneccesary usage of ImmutableList
and Lists while making this change.

This eliminates any Guava use in kudu-spark,
kudu-spark-tools  which didn’t have Gauva
marked as a dependency.

Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-hive/build.gradle
M 
java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
27 files changed, 54 insertions(+), 68 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/10077/2
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10077 )

Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10077/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10077/1//COMMIT_MSG@18
PS1, Line 18: have Gauva marked as a dependency.
what's the advantage of eliminating guava usage? don't we shade it anyway?



--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 16 Apr 2018 17:48:50 +
Gerrit-HasComments: Yes

[kudu-CR] [Java] Use Yetus annotations in place of @VisibleForTesting

2018-04-16 Thread Grant Henke (Code Review) 
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10077


Change subject: [Java] Use Yetus annotations in place of @VisibleForTesting
..

[Java] Use Yetus annotations in place of @VisibleForTesting

We use yetus for marking our intended InterfaceAudience.
This patch replaces Guava’s @VisibleForTesting with
@InterfaceAudience.LimitedPrivate("Test”).

I also elimated an uneccesary usage of ImmutableList
and Lists while making this change.

This eliminates any Guava use in kudu-spark,
kudu-spark-tools, and kudu-hive which didn’t
have Gauva marked as a dependency.

Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
---
M java/kudu-client-tools/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/client/SecurityContext.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
M java/kudu-client/src/main/java/org/apache/kudu/client/TableLocationsCache.java
M java/kudu-client/src/main/java/org/apache/kudu/util/ByteVec.java
M java/kudu-flume-sink/src/main/java/org/apache/kudu/flume/sink/KuduSink.java
M java/kudu-hive/build.gradle
M 
java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M 
java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
M java/kudu-spark-tools/build.gradle
M java/kudu-spark-tools/pom.xml
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
28 files changed, 58 insertions(+), 72 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/10077/1
--
To view, visit http://gerrit.cloudera.org:8080/10077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0d8845e8cbbf5ea81345c46c5487121d1098f91
Gerrit-Change-Number: 10077
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke