[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: > Here is a tserver node of our online cluster, and it has

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. [fs]: wrapping up containers in scoped_refptr It's necessary to

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 6: Here is a tserver node of our online cluster, and it has been

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-08 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#6) to the change originally created by helifu. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. [fs]: wrapping up containers in

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 5: Code-Review+2 (1 comment) Looks good, though I'd still

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread helifu (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#5). Change subject: [fs]: wrapping up containers in scoped_refptr

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-07 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (1 comment)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (1 comment)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (1 comment)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 4: (2 comments)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#4). Change subject: [fs]: wrapping up containers in scoped_refptr ..

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-04 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: (4 comments)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: (4 comments)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2019-01-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: > I compiled the kudu code on debian 8.9 locally, and the

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2018-12-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: I compiled the kudu code on debian 8.9 locally, and the unit

[kudu-CR] [fs]: wrapping up containers in scoped refptr

2018-12-26 Thread helifu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12121 to look at the new patch set (#2). Change subject: [fs]: wrapping up containers in scoped_refptr .. [fs]: wrapping