[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 2: (2 comments) Thank you very much for doing this!

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#3). Change subject: WIP: iwyu: standardize on libc++

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 2: (3 comments) Thanks for addressing this issue, Adar.

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15492/2//COMMIT_MSG

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15492 to look at the new patch set (#2). Change subject: WIP: iwyu: standardize on libc++

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 ) Change subject: WIP: iwyu: standardize on libc++ .. Patch Set 1: You can see the output of iwyu.py --all here:

[kudu-CR] WIP: iwyu: standardize on libc++

2020-03-19 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15492 to review the following change. Change subject: WIP: iwyu: standardize on libc++ .. WIP: