[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 1: (5 comments) I'm +1 on moving boost into thirdparty. I like that it removes complexity

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 2: Code-Review+1 LGTM except for Todd's comment -- To view, visit

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3497 To unsubscribe,

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 4: Build Started

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3080 to look at the new patch set (#13). Change subject: Integrate the request tracker with the client .. Integrate the

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc:

[kudu-CR] locks: switch from boost::shared lock to kudu::shared lock

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: locks: switch from boost::shared_lock to kudu::shared_lock .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3498 To unsubscribe,

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc:

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 15: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2030/ -- To view, visit

[kudu-CR] locks: stop using errno around base::NumCPUs and base::MaxCPUIndex

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: locks: stop using errno around base::NumCPUs and base::MaxCPUIndex .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3495 To

[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal .. Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal This test was flaky because it was

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2029/ -- To view,

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: (1 comment)

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings in raft_consensus-test.cc In this test

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 2: unrelated flake

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 13: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2022/ -- To view, visit

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 2: Build Started

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3504 to look at the new patch set (#2). Change subject: Make RequestTracker not return Status on FirstIncomplete() ..

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 13: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2015/ -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/3080/8//COMMIT_MSG Commit Message: Line

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2009/ -- To view, visit

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2011/ -- To view, visit

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2014/ --

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3504 Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Make RequestTracker not return Status on

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3506 Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Disable exactly once semantics

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#14). Change subject: Integrate the ResultTracker into the rpc subsystem ..

<    1   2